ImpressCMS/impresscms

View on GitHub
htdocs/modules/system/language/english/admin/users.php

Summary

Maintainability
F
4 days
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
// $Id: users.php 11034 2011-02-19 20:12:41Z skenow $
//%%%%%%    Admin Module Name  Users     %%%%%
if (!defined('_AM_DBUPDATED')) {define("_AM_DBUPDATED","Database Updated Successfully!");}

Severity: Major
Found in htdocs/modules/system/language/english/admin/users.php and 1 other location - About 4 days to fix
htdocs/modules/system/language/nederlands/admin/users.php on lines 1..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 821.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

No space found after comma in function call
Open

define("_AM_YMCACF","You must complete all required fields");

No space found after comma in function call
Open

define("_AM_ADDUSER","Add User");

No space found after comma in function call
Open

define("_AM_AVATAR","Avatar");

No space found after comma in function call
Open

define("_AM_CNGUSERID","Could not get user IDS");

No space found after comma in function call
Open

define("_AM_USERS_DELETEED","deleted");

No space found after comma in function call
Open

define("_AM_MODIFYUSER","Modify User");

No space found after comma in function call
Open

define("_AM_ICQ","ICQ");

No space found after comma in function call
Open

define("_AM_AIM","AIM");

No space found after comma in function call
Open

define("_AM_NSRID","No Special Ranks in Database");

No space found after comma in function call
Open

define("_AM_RETYPEPD","Retype Password");

No space found after comma in function call
Open

define("_AM_CNGTST","Could not get total stories");

No space found after comma in function call
Open

define('_AM_BADPWD','Bad Password, Password can not contain username.');

No space found after comma in function call
Open

define("_AM_A_USER_WITH_THIS_EMAIL_ADDRESS","A user with this email address");

Newline required after opening brace
Open

if (!defined('_AM_DBUPDATED')) {define("_AM_DBUPDATED","Database Updated Successfully!");}

No space found after comma in function call
Open

define("_AM_GO","Go!");

No space found after comma in function call
Open

define("_AM_NAME","Name");

No space found after comma in function call
Open

define("_AM_CNGTCOM","Could not get total comments");

No space found after comma in function call
Open

define("_AM_DELUSER","Delete User");

No space found after comma in function call
Open

define("_AM_ADMIN_CAN_NOT_BE_DELETEED","Admin user cannot be deleted");

No space found after comma in function call
Open

define("_AM_NICKNAME","Displayname");

No space found after comma in function call
Open

define("_AM_THEME","Theme");

No space found after comma in function call
Open

define("_AM_NOTACTIVE","This user has not been activated. Do you wish to activate this user?");

No space found after comma in function call
Open

define("_AM_LOCATION","Location");

No space found after comma in function call
Open

define("_AM_USERPOST","User Posts");

No space found after comma in function call
Open

define("_AM_CNRNU","Could not register new user.");

No space found after comma in function call
Open

if (!defined('_AM_DBUPDATED')) {define("_AM_DBUPDATED","Database Updated Successfully!");}

No space found after comma in function call
Open

define("_AM_EDEUSER","Edit/Delete Users");

No space found after comma in function call
Open

define("_AM_NSRA","No Special Rank Assigned");

No space found after comma in function call
Open

define("_AM_CHANGEONLY","(for changes only)");

No space found after comma in function call
Open

define("_AM_PTBBTSDIYT","Push the button below to synchronize data if you think the above user posts info does not seem to indicate the actual status");

No space found after comma in function call
Open

define("_AM_CNUUSER","Could not update user");

No space found after comma in function call
Open

define("_AM_LOGINNAME","Loginname");

Closing brace must be on a line by itself
Open

if (!defined('_AM_DBUPDATED')) {define("_AM_DBUPDATED","Database Updated Successfully!");}

No space found after comma in function call
Open

define("_AM_NO","No");

No space found after comma in function call
Open

define("_AM_STORIES","Stories");

No space found after comma in function call
Open

define("_AM_COMMENTS","Comments");

No space found after comma in function call
Open

define("_AM_SYNCHRONIZE","Synchronize");

No space found after comma in function call
Open

define("_AM_COULD_NOT_DELETE","Could not delete");

No space found after comma in function call
Open

define("_AM_YES","Yes");

No space found after comma in function call
Open

define("_AM_INTEREST","Interest");

No space found after comma in function call
Open

define("_AM_UPDATEUSER","Update User");

No space found after comma in function call
Open

define("_AM_USERINFO","User Info");

No space found after comma in function call
Open

define("_AM_BYTHIS","By doing this all the info for this user will be removed permanently.");

No space found after comma in function call
Open

define("_AM_AOUTVTEAD","Allow other users to view this email address");

No space found after comma in function call
Open

define("_AM_OCCUPATION","Occupation");

No space found after comma in function call
Open

define("_AM_PASSWORD","Password");

No space found after comma in function call
Open

define("_AM_ALREADY_EXISTS","already exists");

No space found after comma in function call
Open

define("_AM_AYSYWTDU","Are you sure you want to delete user %s?");

No space found after comma in function call
Open

define("_AM_OPTION","Option");

No space found after comma in function call
Open

define("_AM_YIM","YIM");

No space found after comma in function call
Open

define("_AM_MSNM","MSNM");

No space found after comma in function call
Open

define("_AM_ACCESSLEV","Access Level");

No space found after comma in function call
Open

define("_AM_INDICATECOF","* indicates required fields");

No space found after comma in function call
Open

define("_AM_REMOVED_USERS","Removed Users");

No space found after comma in function call
Open

define("_AM_EMAIL","Email");

No space found after comma in function call
Open

define("_AM_SIGNATURE","Signature");

No space found after comma in function call
Open

define("_AM_USERDONEXIT","User doesn't exist!");

No space found after comma in function call
Open

define("_AM_CNRNU2","The new user could not be added to groups: %s.");

No space found after comma in function call
Open

define("_AM_USERID","User ID");

No space found after comma in function call
Open

define("_AM_STNPDNM","Sorry, the new passwords do not match. Click back and try again");

No space found after comma in function call
Open

define("_AM_URL","URL");

No space found after comma in function call
Open

define("_AM_RANK","Rank");

No space found after comma in function call
Open

define("_AM_LIST","List");

There are no issues that match your filters.

Category
Status