ImpressCMS/impresscms

View on GitHub
htdocs/modules/system/language/schinese/admin/smilies.php

Summary

Maintainability
B
6 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
// $Id: blauer-fisch $
//%%%%%%    Admin Module Name  Smilies     %%%%%
define('_AM_DBUPDATED','Database Updated Successfully!');

Severity: Major
Found in htdocs/modules/system/language/schinese/admin/smilies.php and 1 other location - About 6 hrs to fix
htdocs/modules/system/language/schinese/plugins.php on lines 1..24

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 223.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File contains UTF-8 byte order mark, which may corrupt your application
Open

<?php

No space found after comma in function call
Open

define('_AM_WAYSYWTDTS','警告: 真的要删除此表情符吗?');

No space found after comma in function call
Open

define('_AM_EDITSMILE','编辑表情符');

Expected 1 newline at end of file; 0 found
Open

?>

No space found after comma in function call
Open

define('_AM_SMILECODE','表情符代码:');

No space found after comma in function call
Open

define('_AM_DEL','删除');

No space found after comma in function call
Open

define('_AM_SMILEEMOTION','说明:');

No space found after comma in function call
Open

define('_AM_SAVE','保存');

No space found after comma in function call
Open

define('_AM_DBUPDATED','Database Updated Successfully!');

No space found after comma in function call
Open

define('_AM_CODE','代码');

No space found after comma in function call
Open

define('_AM_CNRFTSD','从数据库中检索不到这个表情符.');

No space found after comma in function call
Open

define('_AM_SMILEURL','图像URL链接:');

No space found after comma in function call
Open

define('_AM_ADD','添加');

No space found after comma in function call
Open

define('_AM_SMILIE','表情');

No space found after comma in function call
Open

define('_AM_ACTION','动作');

No space found after comma in function call
Open

define('_AM_ADDSMILE','添加表情符');

No space found after comma in function call
Open

define('_AM_SMILESCONTROL','表情符控制');

No space found after comma in function call
Open

define('_AM_EDIT','编辑');

Unexpected spaces found.
Open

<?php

There are no issues that match your filters.

Category
Status