ImpressCMS/impresscms

View on GitHub
upgrade/language/english/upgrade.php

Summary

Maintainability
A
0 mins
Test Coverage

Reference to undeclared constant \_CHARSET
Open

define('_UPGRADE_CHARSET', _CHARSET);
Severity: Minor
Found in upgrade/language/english/upgrade.php by phan

Expected 1 space after comma in function call; 2 found
Open

define( "DB_COLLATION_HELP",  "MySQL includes character set support that enables you to store data using a variety of character sets and perform comparisons according to a variety of collations.<br /><p>If you don't know much about Character encodings, we <b>STRONGLY</b> recommend you to use '<b>none</b>' as default to keep your current configurations.<p>This is about to change your entire database and the information in it. We've tested rather extensively, but your experience may be different.</p><p><span style=\"color: red;\">We've already warned you once and we're not going to tell you again - this is your last chance to make a backup of your database!</span></p>");

Expected 1 space after comma in function call; 2 found
Open

define( "DB_SALT_HELP",  "This salt key will be appended to passwords in function icms_encryptPass(), and is used to create a totally unique secure password.<BR />Do Not change this key once your site is live, doing so will render ALL passwords invalid. If you are unsure, just keep the default"); // L97

Space after opening parenthesis of function call prohibited
Open

define( "_PROCEED_UPGRADE", "Proceed to upgrade" );

Expected 0 spaces before closing bracket; 1 found
Open

define( "_PROCEED_UPGRADE", "Proceed to upgrade" );

Space after opening parenthesis of function call prohibited
Open

define( "_FINISH", "Finish" );

Space after opening parenthesis of function call prohibited
Open

define( "TRUST_PATH_HELP", "This is the physical location of your ImpressCMS trust path. The trust path is a folder where ImpressCMS and its modules will store some sensible code and information for more security. It is recommended that this folder be outside of the web root, making it not accessible by a browser. If the folder does not exist, ImpressCMS will try and create it. If this is not possible, you will need to create it.<br /><br /><a target='_blank' href='https://www.impresscms.org/modules/simplywiki/index.php?page=Trust_Path'>Click here</a> to learn more about the Trust path." ); // L59

Space after opening parenthesis of function call prohibited
Open

define( "ERR_NO_PHP5_CONTENT","PHP 5.2.0 minimum is required for ImpressCMS to function properly - your installation cannot continue. Please work with your hosting provider to upgrade your environment to a version of PHP that is newer than 5.2.0 (5.2.8 + is recommended) before attempting to install again. For more information, read <a href='https://www.impresscms.org/modules/news/article.php?article_id=122' >ImpressCMS on PHP5 </a>.");

Expected 0 spaces before closing bracket; 1 found
Open

define( "_XOOPS_UPGRADE", "ImpressCMS Upgrade" );

Space after opening parenthesis of function call prohibited
Open

define( "_NO_NEED_UPGRADE", "No upgrade necessary. Please remove this folder from your server" );

Space after opening parenthesis of function call prohibited
Open

define( "_SYS_NEED_UPGRADE", "In order to Complete the upgrade proccess, please click here, and upgrade system module." );

Space after opening parenthesis of function call prohibited
Open

define( "_FAILED_PATCH", "Failed to patch %s" );

Expected 0 spaces before closing bracket; 1 found
Open

define( "_FAILED_PATCH", "Failed to patch %s" );

Space after opening parenthesis of function call prohibited
Open

define( "_APPLY_NEXT", "Apply next upgrade (%s)" );

Expected 1 newline at end of file; 0 found
Open

?>

Space after opening parenthesis of function call prohibited
Open

define( "_SET_FILES_WRITABLE", "Make the following files writable before proceeding:" );

Expected 0 spaces before closing bracket; 1 found
Open

define( "_NO_NEED_UPGRADE", "No upgrade necessary. Please remove this folder from your server" );

Space after opening parenthesis of function call prohibited
Open

define( "_MANUAL_INSTRUCTIONS", "Manual installation instructions" );

Space after opening parenthesis of function call prohibited
Open

define( '_I_AM_AWARE', '<p><span style="color: red;">You are about to upgrade your existing web site - your pride and joy, or maybe your livelihood. If you like to take risks, check the box and proceed without making any backups. Otherwise, it might be wise to make sure your backups are recent before going ahead. Either way, you have to check the box and take some responsibility to continue.</span></p>' );

Space after opening parenthesis of function call prohibited
Open

define( "_CHECKING_APPLIED", "Checking applied upgrades:" );

Expected 0 spaces before closing bracket; 1 found
Open

define( "_CHECKING_APPLIED", "Checking applied upgrades:" );

Expected 0 spaces before closing bracket; 1 found
Open

define( "_SYS_NEED_UPGRADE", "In order to Complete the upgrade proccess, please click here, and upgrade system module." );

Expected 0 spaces before closing bracket; 1 found
Open

define( "TRUST_PATH_HELP", "This is the physical location of your ImpressCMS trust path. The trust path is a folder where ImpressCMS and its modules will store some sensible code and information for more security. It is recommended that this folder be outside of the web root, making it not accessible by a browser. If the folder does not exist, ImpressCMS will try and create it. If this is not possible, you will need to create it.<br /><br /><a target='_blank' href='https://www.impresscms.org/modules/simplywiki/index.php?page=Trust_Path'>Click here</a> to learn more about the Trust path." ); // L59

Expected 0 spaces before closing bracket; 1 found
Open

define( "_MANUAL_INSTRUCTIONS", "Manual installation instructions" );

Expected 0 spaces before closing bracket; 1 found
Open

define( "_FINISH", "Finish" );

Space after opening parenthesis of function call prohibited
Open

define( "DB_COLLATION_HELP",  "MySQL includes character set support that enables you to store data using a variety of character sets and perform comparisons according to a variety of collations.<br /><p>If you don't know much about Character encodings, we <b>STRONGLY</b> recommend you to use '<b>none</b>' as default to keep your current configurations.<p>This is about to change your entire database and the information in it. We've tested rather extensively, but your experience may be different.</p><p><span style=\"color: red;\">We've already warned you once and we're not going to tell you again - this is your last chance to make a backup of your database!</span></p>");

Expected 0 spaces before closing bracket; 1 found
Open

define( "LEGEND_DATABASE", "Database Character Set" );

Space after opening parenthesis of function call prohibited
Open

define( "DB_COLLATION_LABEL", "Database character set and collation" );

Expected 0 spaces before closing bracket; 1 found
Open

define( "_SET_FILES_WRITABLE", "Make the following files writable before proceeding:" );

Expected 0 spaces before closing bracket; 1 found
Open

define( "_COPY_RED_LINES", "Copy the following red lines to %s" );

A closing tag is not permitted at the end of a PHP file
Open

?>

Space after opening parenthesis of function call prohibited
Open

define( "ERR_COULD_NOT_WRITE_MAINFILE", "Error writing content to mainfile.php, write the content into mainfile.php manually." );

Expected 0 spaces before closing bracket; 1 found
Open

define( "_PERFORMING_UPGRADE", "Performing %s upgrade" );

Expected 0 spaces before closing bracket; 1 found
Open

define( "_RELOAD", "Reload" );

Expected 0 spaces before closing bracket; 1 found
Open

define( "ERR_COULD_NOT_WRITE_MAINFILE", "Error writing content to mainfile.php, write the content into mainfile.php manually." );

Expected 0 spaces before closing bracket; 1 found
Open

define( "DB_SALT_LABEL", "Password Salt Key" );    // L98

No space found after comma in function call
Open

define( "ERR_NO_PHP5_CONTENT","PHP 5.2.0 minimum is required for ImpressCMS to function properly - your installation cannot continue. Please work with your hosting provider to upgrade your environment to a version of PHP that is newer than 5.2.0 (5.2.8 + is recommended) before attempting to install again. For more information, read <a href='https://www.impresscms.org/modules/news/article.php?article_id=122' >ImpressCMS on PHP5 </a>.");

Space after opening parenthesis of function call prohibited
Open

define( "_RELOAD", "Reload" );

Space after opening parenthesis of function call prohibited
Open

define( "DB_SALT_HELP",  "This salt key will be appended to passwords in function icms_encryptPass(), and is used to create a totally unique secure password.<BR />Do Not change this key once your site is live, doing so will render ALL passwords invalid. If you are unsure, just keep the default"); // L97

Expected 0 spaces before closing bracket; 1 found
Open

define( "_USER_LOGIN", "User login" );

Space after opening parenthesis of function call prohibited
Open

define( "_XOOPS_UPGRADE", "ImpressCMS Upgrade" );

Expected 0 spaces before closing bracket; 1 found
Open

define( "_NEED_UPGRADE", "Upgrade needed" );

Space after opening parenthesis of function call prohibited
Open

define( "_PERFORMING_UPGRADE", "Performing %s upgrade" );

Space after opening parenthesis of function call prohibited
Open

define( "_NEED_UPGRADE", "Upgrade needed" );

Expected 0 spaces before closing bracket; 1 found
Open

define( "_APPLY_NEXT", "Apply next upgrade (%s)" );

Space after opening parenthesis of function call prohibited
Open

define( "LEGEND_DATABASE", "Database Character Set" );

Expected 0 spaces before closing bracket; 1 found
Open

define( "DB_COLLATION_LABEL", "Database character set and collation" );

Space after opening parenthesis of function call prohibited
Open

define( "DB_SALT_LABEL", "Password Salt Key" );    // L98

Space after opening parenthesis of function call prohibited
Open

define( "_USER_LOGIN", "User login" );

Space after opening parenthesis of function call prohibited
Open

define( "_COPY_RED_LINES", "Copy the following red lines to %s" );

Expected 0 spaces before closing bracket; 1 found
Open

define( '_I_AM_AWARE', '<p><span style="color: red;">You are about to upgrade your existing web site - your pride and joy, or maybe your livelihood. If you like to take risks, check the box and proceed without making any backups. Otherwise, it might be wise to make sure your backups are recent before going ahead. Either way, you have to check the box and take some responsibility to continue.</span></p>' );

There are no issues that match your filters.

Category
Status