ImpressCMS/impresscms

View on GitHub
upgrade/upd-2.0.18-to-impresscms-1.0/index.php

Summary

Maintainability
C
1 day
Test Coverage

query accesses the super-global variable $GLOBALS.
Open

    function query($sql) {
        //echo "<li>" . $sql . "</li>";
        $db = $GLOBALS['xoopsDB'];
        if (!($ret = $db->queryF($sql))) {
            echo "<li style='font-weight: bold; color: red;'>" . $db->error() . "</li>";

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_alter_tables accesses the super-global variable $GLOBALS.
Open

    function apply_alter_tables() {
        $db = $GLOBALS['xoopsDB'];
        $this->fields = array (
            "config" => array (
                "conf_desc" => "varchar(100)"

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_new_blocks accesses the super-global variable $GLOBALS.
Open

    function apply_new_blocks() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db,'newblocks','bid',' show_func="b_system_multilanguage_show"') != 0) {return true;}
        $this->query(" INSERT INTO " . $db->prefix("newblocks") . " VALUES ('', 1, 0, '', 'Language Selection', 'Language Selection', '', 1, 0, 0, 'S', 'H', 1, 'system', 'system_blocks.php', 'b_system_multilanguage_show', '', 'system_block_multilanguage.html', 0, " . time() . ")");
        $new_block_id = $db->getInsertId();

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf_config accesses the super-global variable $GLOBALS.
Open

    function apply_conf_config() {
        $db = $GLOBALS['xoopsDB'];
        // Insert config values
        $table = $db->prefix('config');
        $data = array (

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_templates accesses the super-global variable $GLOBALS.
Open

    function apply_templates() {
        $db = $GLOBALS['xoopsDB'];
        $table = $db->prefix('tplfile');
        $table1 = $db->prefix('tplsource');
        $tpl_files = array(

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

check_conf_config accesses the super-global variable $GLOBALS.
Open

    function check_conf_config() {
        $db = $GLOBALS['xoopsDB'];
        $value = getDbValue($db, 'config', 'conf_id', "`conf_name` = 'rank_width' AND `conf_catid` = " . XOOPS_CONF_USER);
        return (bool) ($value);
    }

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_ml_config accesses the super-global variable $GLOBALS.
Open

    function apply_ml_config() {
        $db = $GLOBALS['xoopsDB'];
        // Insert config values
        $table = $db->prefix('config');
        $data = array (

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf_configcategory accesses the super-global variable $GLOBALS.
Open

    function apply_conf_configcategory() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db,'configcategory','confcat_id',' confcat_name="_MD_AM_MULTILANGUAGE"') != 0) {return true;}
        return $this->query(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id,confcat_name) VALUES ('','_MD_AM_MULTILANGUAGE')");
    }

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

blocks_engine_upgrade accesses the super-global variable $GLOBALS.
Open

    function blocks_engine_upgrade() {
        echo '<h2>Updating blocks engine </h2>';
        if (!$this->table_exists('block_positions')) {
            $xoopsDB = $GLOBALS['xoopsDB'];
            $query = "CREATE TABLE `" . $xoopsDB->prefix('block_positions') . "` (

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

The class upgrade_impcms05 has 13 public methods. Consider refactoring upgrade_impcms05 to keep number of public methods under 10.
Open

class upgrade_impcms05 {
    var $usedFiles = array ();
    function isApplied() {
        return ($this->check_conf_config());
    }

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

Method blocks_engine_upgrade has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function blocks_engine_upgrade() {
        echo '<h2>Updating blocks engine </h2>';
        if (!$this->table_exists('block_positions')) {
            $xoopsDB = $GLOBALS['xoopsDB'];
            $query = "CREATE TABLE `" . $xoopsDB->prefix('block_positions') . "` (
Severity: Major
Found in upgrade/upd-2.0.18-to-impresscms-1.0/index.php - About 2 hrs to fix

    Function blocks_engine_upgrade has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        function blocks_engine_upgrade() {
            echo '<h2>Updating blocks engine </h2>';
            if (!$this->table_exists('block_positions')) {
                $xoopsDB = $GLOBALS['xoopsDB'];
                $query = "CREATE TABLE `" . $xoopsDB->prefix('block_positions') . "` (
    Severity: Minor
    Found in upgrade/upd-2.0.18-to-impresscms-1.0/index.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function cleaning_write_folders has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        function cleaning_write_folders() {
            $dir = array();
            $dir['templates_c'] = ICMS_COMPILE_PATH . "/";
            $dir['cache'] = ICMS_CACHE_PATH . "/";
    
    
    Severity: Minor
    Found in upgrade/upd-2.0.18-to-impresscms-1.0/index.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function apply_templates has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        function apply_templates() {
            $db = $GLOBALS['xoopsDB'];
            $table = $db->prefix('tplfile');
            $table1 = $db->prefix('tplsource');
            $tpl_files = array(
    Severity: Minor
    Found in upgrade/upd-2.0.18-to-impresscms-1.0/index.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid assigning values to variables in if clauses and the like (line '220', column '10').
    Open

        function apply_templates() {
            $db = $GLOBALS['xoopsDB'];
            $table = $db->prefix('tplfile');
            $table1 = $db->prefix('tplsource');
            $tpl_files = array(

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($foo = 'bar') { // possible typo
                // ...
            }
            if ($baz = 0) { // always false
                // ...
            }
        }
    }

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Avoid assigning values to variables in if clauses and the like (line '150', column '9').
    Open

        function query($sql) {
            //echo "<li>" . $sql . "</li>";
            $db = $GLOBALS['xoopsDB'];
            if (!($ret = $db->queryF($sql))) {
                echo "<li style='font-weight: bold; color: red;'>" . $db->error() . "</li>";

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($foo = 'bar') { // possible typo
                // ...
            }
            if ($baz = 0) { // always false
                // ...
            }
        }
    }

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Avoid unused local variables such as '$err'.
    Open

                $err = 0;

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
        public function doSomething()
        {
            $i = 5; // Unused
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Avoid unused local variables such as '$ret'.
    Open

            if (!($ret = $db->queryF($sql))) {

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
        public function doSomething()
        {
            $i = 5; // Unused
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Reference to undeclared property \upgrade_impcms05->fields
    Open

                    foreach ($this->fields as $table => $data) {

    Reference to undeclared property \upgrade_impcms05->fields
    Open

            $this->fields = array (

    Reference to undeclared constant \XOOPS_CONF_USER
    Open

            $value = getDbValue($db, 'config', 'conf_id', "`conf_name` = 'rank_width' AND `conf_catid` = " . XOOPS_CONF_USER);

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        function cleaning_write_folders() {
            $dir = array();
            $dir['templates_c'] = ICMS_COMPILE_PATH . "/";
            $dir['cache'] = ICMS_CACHE_PATH . "/";
    
    
    Severity: Major
    Found in upgrade/upd-2.0.18-to-impresscms-1.0/index.php and 1 other location - About 3 hrs to fix
    upgrade/upd-icms-1.0-to-1.1/index.php on lines 50..68

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 153.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class upgrade_impcms05 {

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

            $db = $GLOBALS['xoopsDB'];

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

            $db = $GLOBALS['xoopsDB'];

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $dd. Configured minimum length is 3.
    Open

                $dd = opendir($d);

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    The class upgrade_impcms05 is not named in CamelCase.
    Open

    class upgrade_impcms05 {
        var $usedFiles = array ();
        function isApplied() {
            return ($this->check_conf_config());
        }

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
    }

    Source

    Avoid variables with short names like $fp. Configured minimum length is 3.
    Open

                        if ($fp = fopen('../modules/system/templates/'.$tpl_file, 'r')) {

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

            $db = $GLOBALS['xoopsDB'];

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

            $db = $GLOBALS['xoopsDB'];

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

            $db = $GLOBALS['xoopsDB'];

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

            $db = $GLOBALS['xoopsDB'];

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

            $db = $GLOBALS['xoopsDB'];

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

            $db = $GLOBALS['xoopsDB'];

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    Method name "upgrade_impcms05::check_conf_config" is not in camel caps format
    Open

        function check_conf_config() {

    The var keyword must not be used to declare a property
    Open

        var $usedFiles = array ();

    Visibility must be declared on method "blocks_engine_upgrade"
    Open

        function blocks_engine_upgrade() {

    Visibility must be declared on method "isApplied"
    Open

        function isApplied() {

    Method name "upgrade_impcms05::apply_conf_configcategory" is not in camel caps format
    Open

        function apply_conf_configcategory() {

    Method name "upgrade_impcms05::check_file_patch" is not in camel caps format
    Open

        function check_file_patch() {

    Visibility must be declared on method "apply_new_blocks"
    Open

        function apply_new_blocks() {

    Visibility must be declared on method "check_file_patch"
    Open

        function check_file_patch() {

    Method name "upgrade_impcms05::cleaning_write_folders" is not in camel caps format
    Open

        function cleaning_write_folders() {

    Visibility must be declared on method "apply_conf_configcategory"
    Open

        function apply_conf_configcategory() {

    Method name "upgrade_impcms05::apply_ml_config" is not in camel caps format
    Open

        function apply_ml_config() {

    Visibility must be declared on method "apply_ml_config"
    Open

        function apply_ml_config() {

    Method name "upgrade_impcms05::apply_templates" is not in camel caps format
    Open

        function apply_templates() {

    Visibility must be declared on property "$usedFiles"
    Open

        var $usedFiles = array ();

    Visibility must be declared on method "cleaning_write_folders"
    Open

        function cleaning_write_folders() {

    Method name "upgrade_impcms05::apply_new_blocks" is not in camel caps format
    Open

        function apply_new_blocks() {

    Visibility must be declared on method "check_conf_config"
    Open

        function check_conf_config() {

    Visibility must be declared on method "apply_conf_config"
    Open

        function apply_conf_config() {

    Expected 1 space after "=>"; 0 found
    Open

                foreach ($tpl_files as $tpl_file=>$desc) {

    Visibility must be declared on method "table_exists"
    Open

        function table_exists($tablename) {

    Method name "upgrade_impcms05::apply_conf_config" is not in camel caps format
    Open

        function apply_conf_config() {

    Visibility must be declared on method "apply_alter_tables"
    Open

        function apply_alter_tables() {

    Visibility must be declared on method "apply"
    Open

        function apply() {

    Method name "upgrade_impcms05::table_exists" is not in camel caps format
    Open

        function table_exists($tablename) {

    Visibility must be declared on method "apply_templates"
    Open

        function apply_templates() {

    Visibility must be declared on method "query"
    Open

        function query($sql) {

    Expected 1 space before "=>"; 0 found
    Open

                foreach ($tpl_files as $tpl_file=>$desc) {

    Method name "upgrade_impcms05::blocks_engine_upgrade" is not in camel caps format
    Open

        function blocks_engine_upgrade() {

    Method name "upgrade_impcms05::apply_alter_tables" is not in camel caps format
    Open

        function apply_alter_tables() {

    Newline required after opening brace
    Open

            if (getDbValue($db,'configcategory','confcat_id',' confcat_name="_MD_AM_MULTILANGUAGE"') != 0) {return true;}

    Expected 1 space after closing parenthesis; found 17
    Open

                    if (is_file($d.$file) && ($file != 'index.html' && $file != 'php.ini' && $file != '.htaccess'))

    No space found after comma in function call
    Open

            if (getDbValue($db,'configcategory','confcat_id',' confcat_name="_MD_AM_MULTILANGUAGE"') != 0) {return true;}

    Expected 1 space after closing parenthesis; found 13
    Open

                while ($file = readdir($dd))

    Expected 1 space after closing parenthesis; found 9
    Open

            foreach ($dir as $d)

    No space found after comma in function call
    Open

            if (getDbValue($db,'newblocks','bid',' show_func="b_system_multilanguage_show"') != 0) {return true;}

    No space found after comma in function call
    Open

                    if (!getDbValue($db,'tplfile','tpl_id',' tpl_file="'.$tpl_file.'"')) {

    Expected 1 newline at end of file; 0 found
    Open

    ?>

    A closing tag is not permitted at the end of a PHP file
    Open

    ?>

    No space found after comma in function call
    Open

            if (getDbValue($db,'newblocks','bid',' show_func="b_system_multilanguage_show"') != 0) {return true;}

    Line indented incorrectly; expected 3 tabs, found 4
    Open

                    if (!getDbValue($db,'tplfile','tpl_id',' tpl_file="'.$tpl_file.'"')) {

    Line indented incorrectly; expected 2 tabs, found 3
    Open

                }

    No space found after comma in function call
    Open

            if (getDbValue($db,'newblocks','bid',' show_func="b_system_multilanguage_show"') != 0) {return true;}

    No space found after comma in function call
    Open

            if (getDbValue($db,'configcategory','confcat_id',' confcat_name="_MD_AM_MULTILANGUAGE"') != 0) {return true;}

    No space found after comma in function call
    Open

            if (getDbValue($db,'configcategory','confcat_id',' confcat_name="_MD_AM_MULTILANGUAGE"') != 0) {return true;}

    Newline required after opening brace
    Open

            if (getDbValue($db,'newblocks','bid',' show_func="b_system_multilanguage_show"') != 0) {return true;}

    Closing brace must be on a line by itself
    Open

            if (getDbValue($db,'newblocks','bid',' show_func="b_system_multilanguage_show"') != 0) {return true;}

    No space found after comma in function call
    Open

                    if (!getDbValue($db,'tplfile','tpl_id',' tpl_file="'.$tpl_file.'"')) {

    Line indented incorrectly; expected 4 tabs, found 5
    Open

                        if ($fp = fopen('../modules/system/templates/'.$tpl_file, 'r')) {

    Line indented incorrectly; expected 4 tabs, found 5
    Open

                        }

    Line indented incorrectly; expected 3 tabs, found 5
    Open

                        }

    Expected 0 spaces before closing bracket; newline found
    Open

                'priv_policy' => "'_MD_AM_PRIVPOLICY', '" . addslashes(_UPGRADE_PRIVPOLICY

    Line indented incorrectly; expected 2 tabs, found 3
    Open

                foreach ($tpl_files as $tpl_file=>$desc) {

    Closing brace must be on a line by itself
    Open

            if (getDbValue($db,'configcategory','confcat_id',' confcat_name="_MD_AM_MULTILANGUAGE"') != 0) {return true;}

    Line indented incorrectly; expected 2 tabs, found 4
    Open

                    }

    No space found after comma in function call
    Open

                    if (!getDbValue($db,'tplfile','tpl_id',' tpl_file="'.$tpl_file.'"')) {

    Line indented incorrectly; expected 3 tabs, found 4
    Open

                    }

    Line indented incorrectly; expected 2 tabs, found 4
    Open

                    foreach ($this->fields as $table => $data) {

    Class name "upgrade_impcms05" is not in camel caps format
    Open

    class upgrade_impcms05 {

    Line indented incorrectly; expected 3 tabs, found 5
    Open

                        foreach ($data as $field => $property) {

    The variable $new_tpl_source is not named in camelCase.
    Open

        function apply_new_blocks() {
            $db = $GLOBALS['xoopsDB'];
            if (getDbValue($db,'newblocks','bid',' show_func="b_system_multilanguage_show"') != 0) {return true;}
            $this->query(" INSERT INTO " . $db->prefix("newblocks") . " VALUES ('', 1, 0, '', 'Language Selection', 'Language Selection', '', 1, 0, 0, 'S', 'H', 1, 'system', 'system_blocks.php', 'b_system_multilanguage_show', '', 'system_block_multilanguage.html', 0, " . time() . ")");
            $new_block_id = $db->getInsertId();

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $new_block_id is not named in camelCase.
    Open

        function apply_new_blocks() {
            $db = $GLOBALS['xoopsDB'];
            if (getDbValue($db,'newblocks','bid',' show_func="b_system_multilanguage_show"') != 0) {return true;}
            $this->query(" INSERT INTO " . $db->prefix("newblocks") . " VALUES ('', 1, 0, '', 'Language Selection', 'Language Selection', '', 1, 0, 0, 'S', 'H', 1, 'system', 'system_blocks.php', 'b_system_multilanguage_show', '', 'system_block_multilanguage.html', 0, " . time() . ")");
            $new_block_id = $db->getInsertId();

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $new_tpl_source is not named in camelCase.
    Open

        function apply_templates() {
            $db = $GLOBALS['xoopsDB'];
            $table = $db->prefix('tplfile');
            $table1 = $db->prefix('tplsource');
            $tpl_files = array(

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $new_tplfile_id is not named in camelCase.
    Open

        function apply_new_blocks() {
            $db = $GLOBALS['xoopsDB'];
            if (getDbValue($db,'newblocks','bid',' show_func="b_system_multilanguage_show"') != 0) {return true;}
            $this->query(" INSERT INTO " . $db->prefix("newblocks") . " VALUES ('', 1, 0, '', 'Language Selection', 'Language Selection', '', 1, 0, 0, 'S', 'H', 1, 'system', 'system_blocks.php', 'b_system_multilanguage_show', '', 'system_block_multilanguage.html', 0, " . time() . ")");
            $new_block_id = $db->getInsertId();

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $curr_block_schema is not named in camelCase.
    Open

        function blocks_engine_upgrade() {
            echo '<h2>Updating blocks engine </h2>';
            if (!$this->table_exists('block_positions')) {
                $xoopsDB = $GLOBALS['xoopsDB'];
                $query = "CREATE TABLE `" . $xoopsDB->prefix('block_positions') . "` (

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $tpl_file is not named in camelCase.
    Open

        function apply_templates() {
            $db = $GLOBALS['xoopsDB'];
            $table = $db->prefix('tplfile');
            $table1 = $db->prefix('tplsource');
            $tpl_files = array(

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $new_block_id is not named in camelCase.
    Open

        function apply_new_blocks() {
            $db = $GLOBALS['xoopsDB'];
            if (getDbValue($db,'newblocks','bid',' show_func="b_system_multilanguage_show"') != 0) {return true;}
            $this->query(" INSERT INTO " . $db->prefix("newblocks") . " VALUES ('', 1, 0, '', 'Language Selection', 'Language Selection', '', 1, 0, 0, 'S', 'H', 1, 'system', 'system_blocks.php', 'b_system_multilanguage_show', '', 'system_block_multilanguage.html', 0, " . time() . ")");
            $new_block_id = $db->getInsertId();

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $new_tpl_source is not named in camelCase.
    Open

        function apply_new_blocks() {
            $db = $GLOBALS['xoopsDB'];
            if (getDbValue($db,'newblocks','bid',' show_func="b_system_multilanguage_show"') != 0) {return true;}
            $this->query(" INSERT INTO " . $db->prefix("newblocks") . " VALUES ('', 1, 0, '', 'Language Selection', 'Language Selection', '', 1, 0, 0, 'S', 'H', 1, 'system', 'system_blocks.php', 'b_system_multilanguage_show', '', 'system_block_multilanguage.html', 0, " . time() . ")");
            $new_block_id = $db->getInsertId();

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $new_block_id is not named in camelCase.
    Open

        function apply_new_blocks() {
            $db = $GLOBALS['xoopsDB'];
            if (getDbValue($db,'newblocks','bid',' show_func="b_system_multilanguage_show"') != 0) {return true;}
            $this->query(" INSERT INTO " . $db->prefix("newblocks") . " VALUES ('', 1, 0, '', 'Language Selection', 'Language Selection', '', 1, 0, 0, 'S', 'H', 1, 'system', 'system_blocks.php', 'b_system_multilanguage_show', '', 'system_block_multilanguage.html', 0, " . time() . ")");
            $new_block_id = $db->getInsertId();

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $curr_block_schema is not named in camelCase.
    Open

        function blocks_engine_upgrade() {
            echo '<h2>Updating blocks engine </h2>';
            if (!$this->table_exists('block_positions')) {
                $xoopsDB = $GLOBALS['xoopsDB'];
                $query = "CREATE TABLE `" . $xoopsDB->prefix('block_positions') . "` (

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $new_block_id is not named in camelCase.
    Open

        function apply_new_blocks() {
            $db = $GLOBALS['xoopsDB'];
            if (getDbValue($db,'newblocks','bid',' show_func="b_system_multilanguage_show"') != 0) {return true;}
            $this->query(" INSERT INTO " . $db->prefix("newblocks") . " VALUES ('', 1, 0, '', 'Language Selection', 'Language Selection', '', 1, 0, 0, 'S', 'H', 1, 'system', 'system_blocks.php', 'b_system_multilanguage_show', '', 'system_block_multilanguage.html', 0, " . time() . ")");
            $new_block_id = $db->getInsertId();

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $new_tpl_source is not named in camelCase.
    Open

        function apply_templates() {
            $db = $GLOBALS['xoopsDB'];
            $table = $db->prefix('tplfile');
            $table1 = $db->prefix('tplsource');
            $tpl_files = array(

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $curr_block_schema is not named in camelCase.
    Open

        function blocks_engine_upgrade() {
            echo '<h2>Updating blocks engine </h2>';
            if (!$this->table_exists('block_positions')) {
                $xoopsDB = $GLOBALS['xoopsDB'];
                $query = "CREATE TABLE `" . $xoopsDB->prefix('block_positions') . "` (

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $tpl_files is not named in camelCase.
    Open

        function apply_templates() {
            $db = $GLOBALS['xoopsDB'];
            $table = $db->prefix('tplfile');
            $table1 = $db->prefix('tplsource');
            $tpl_files = array(

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $curr_block_schema_id is not named in camelCase.
    Open

        function blocks_engine_upgrade() {
            echo '<h2>Updating blocks engine </h2>';
            if (!$this->table_exists('block_positions')) {
                $xoopsDB = $GLOBALS['xoopsDB'];
                $query = "CREATE TABLE `" . $xoopsDB->prefix('block_positions') . "` (

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $curr_block_schema_id is not named in camelCase.
    Open

        function blocks_engine_upgrade() {
            echo '<h2>Updating blocks engine </h2>';
            if (!$this->table_exists('block_positions')) {
                $xoopsDB = $GLOBALS['xoopsDB'];
                $query = "CREATE TABLE `" . $xoopsDB->prefix('block_positions') . "` (

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $new_tplfile_id is not named in camelCase.
    Open

        function apply_templates() {
            $db = $GLOBALS['xoopsDB'];
            $table = $db->prefix('tplfile');
            $table1 = $db->prefix('tplsource');
            $tpl_files = array(

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $new_tplfile_id is not named in camelCase.
    Open

        function apply_templates() {
            $db = $GLOBALS['xoopsDB'];
            $table = $db->prefix('tplfile');
            $table1 = $db->prefix('tplsource');
            $tpl_files = array(

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $new_tplfile_id is not named in camelCase.
    Open

        function apply_new_blocks() {
            $db = $GLOBALS['xoopsDB'];
            if (getDbValue($db,'newblocks','bid',' show_func="b_system_multilanguage_show"') != 0) {return true;}
            $this->query(" INSERT INTO " . $db->prefix("newblocks") . " VALUES ('', 1, 0, '', 'Language Selection', 'Language Selection', '', 1, 0, 0, 'S', 'H', 1, 'system', 'system_blocks.php', 'b_system_multilanguage_show', '', 'system_block_multilanguage.html', 0, " . time() . ")");
            $new_block_id = $db->getInsertId();

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $curr_block_schema is not named in camelCase.
    Open

        function blocks_engine_upgrade() {
            echo '<h2>Updating blocks engine </h2>';
            if (!$this->table_exists('block_positions')) {
                $xoopsDB = $GLOBALS['xoopsDB'];
                $query = "CREATE TABLE `" . $xoopsDB->prefix('block_positions') . "` (

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $new_block_id is not named in camelCase.
    Open

        function apply_new_blocks() {
            $db = $GLOBALS['xoopsDB'];
            if (getDbValue($db,'newblocks','bid',' show_func="b_system_multilanguage_show"') != 0) {return true;}
            $this->query(" INSERT INTO " . $db->prefix("newblocks") . " VALUES ('', 1, 0, '', 'Language Selection', 'Language Selection', '', 1, 0, 0, 'S', 'H', 1, 'system', 'system_blocks.php', 'b_system_multilanguage_show', '', 'system_block_multilanguage.html', 0, " . time() . ")");
            $new_block_id = $db->getInsertId();

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $new_block_id is not named in camelCase.
    Open

        function apply_new_blocks() {
            $db = $GLOBALS['xoopsDB'];
            if (getDbValue($db,'newblocks','bid',' show_func="b_system_multilanguage_show"') != 0) {return true;}
            $this->query(" INSERT INTO " . $db->prefix("newblocks") . " VALUES ('', 1, 0, '', 'Language Selection', 'Language Selection', '', 1, 0, 0, 'S', 'H', 1, 'system', 'system_blocks.php', 'b_system_multilanguage_show', '', 'system_block_multilanguage.html', 0, " . time() . ")");
            $new_block_id = $db->getInsertId();

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $curr_block_schema is not named in camelCase.
    Open

        function blocks_engine_upgrade() {
            echo '<h2>Updating blocks engine </h2>';
            if (!$this->table_exists('block_positions')) {
                $xoopsDB = $GLOBALS['xoopsDB'];
                $query = "CREATE TABLE `" . $xoopsDB->prefix('block_positions') . "` (

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $curr_block_schema is not named in camelCase.
    Open

        function blocks_engine_upgrade() {
            echo '<h2>Updating blocks engine </h2>';
            if (!$this->table_exists('block_positions')) {
                $xoopsDB = $GLOBALS['xoopsDB'];
                $query = "CREATE TABLE `" . $xoopsDB->prefix('block_positions') . "` (

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $curr_block_schema is not named in camelCase.
    Open

        function blocks_engine_upgrade() {
            echo '<h2>Updating blocks engine </h2>';
            if (!$this->table_exists('block_positions')) {
                $xoopsDB = $GLOBALS['xoopsDB'];
                $query = "CREATE TABLE `" . $xoopsDB->prefix('block_positions') . "` (

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $curr_block_schema is not named in camelCase.
    Open

        function blocks_engine_upgrade() {
            echo '<h2>Updating blocks engine </h2>';
            if (!$this->table_exists('block_positions')) {
                $xoopsDB = $GLOBALS['xoopsDB'];
                $query = "CREATE TABLE `" . $xoopsDB->prefix('block_positions') . "` (

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $curr_block_schema is not named in camelCase.
    Open

        function blocks_engine_upgrade() {
            echo '<h2>Updating blocks engine </h2>';
            if (!$this->table_exists('block_positions')) {
                $xoopsDB = $GLOBALS['xoopsDB'];
                $query = "CREATE TABLE `" . $xoopsDB->prefix('block_positions') . "` (

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $curr_block_schema_id is not named in camelCase.
    Open

        function blocks_engine_upgrade() {
            echo '<h2>Updating blocks engine </h2>';
            if (!$this->table_exists('block_positions')) {
                $xoopsDB = $GLOBALS['xoopsDB'];
                $query = "CREATE TABLE `" . $xoopsDB->prefix('block_positions') . "` (

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $tpl_files is not named in camelCase.
    Open

        function apply_templates() {
            $db = $GLOBALS['xoopsDB'];
            $table = $db->prefix('tplfile');
            $table1 = $db->prefix('tplsource');
            $tpl_files = array(

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $tpl_file is not named in camelCase.
    Open

        function apply_templates() {
            $db = $GLOBALS['xoopsDB'];
            $table = $db->prefix('tplfile');
            $table1 = $db->prefix('tplsource');
            $tpl_files = array(

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $tpl_file is not named in camelCase.
    Open

        function apply_templates() {
            $db = $GLOBALS['xoopsDB'];
            $table = $db->prefix('tplfile');
            $table1 = $db->prefix('tplsource');
            $tpl_files = array(

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $new_block_id is not named in camelCase.
    Open

        function apply_new_blocks() {
            $db = $GLOBALS['xoopsDB'];
            if (getDbValue($db,'newblocks','bid',' show_func="b_system_multilanguage_show"') != 0) {return true;}
            $this->query(" INSERT INTO " . $db->prefix("newblocks") . " VALUES ('', 1, 0, '', 'Language Selection', 'Language Selection', '', 1, 0, 0, 'S', 'H', 1, 'system', 'system_blocks.php', 'b_system_multilanguage_show', '', 'system_block_multilanguage.html', 0, " . time() . ")");
            $new_block_id = $db->getInsertId();

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $new_block_id is not named in camelCase.
    Open

        function apply_new_blocks() {
            $db = $GLOBALS['xoopsDB'];
            if (getDbValue($db,'newblocks','bid',' show_func="b_system_multilanguage_show"') != 0) {return true;}
            $this->query(" INSERT INTO " . $db->prefix("newblocks") . " VALUES ('', 1, 0, '', 'Language Selection', 'Language Selection', '', 1, 0, 0, 'S', 'H', 1, 'system', 'system_blocks.php', 'b_system_multilanguage_show', '', 'system_block_multilanguage.html', 0, " . time() . ")");
            $new_block_id = $db->getInsertId();

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $curr_block_schema is not named in camelCase.
    Open

        function blocks_engine_upgrade() {
            echo '<h2>Updating blocks engine </h2>';
            if (!$this->table_exists('block_positions')) {
                $xoopsDB = $GLOBALS['xoopsDB'];
                $query = "CREATE TABLE `" . $xoopsDB->prefix('block_positions') . "` (

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $curr_block_schema is not named in camelCase.
    Open

        function blocks_engine_upgrade() {
            echo '<h2>Updating blocks engine </h2>';
            if (!$this->table_exists('block_positions')) {
                $xoopsDB = $GLOBALS['xoopsDB'];
                $query = "CREATE TABLE `" . $xoopsDB->prefix('block_positions') . "` (

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $curr_block_schema is not named in camelCase.
    Open

        function blocks_engine_upgrade() {
            echo '<h2>Updating blocks engine </h2>';
            if (!$this->table_exists('block_positions')) {
                $xoopsDB = $GLOBALS['xoopsDB'];
                $query = "CREATE TABLE `" . $xoopsDB->prefix('block_positions') . "` (

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $curr_block_schema is not named in camelCase.
    Open

        function blocks_engine_upgrade() {
            echo '<h2>Updating blocks engine </h2>';
            if (!$this->table_exists('block_positions')) {
                $xoopsDB = $GLOBALS['xoopsDB'];
                $query = "CREATE TABLE `" . $xoopsDB->prefix('block_positions') . "` (

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $curr_block_schema_id is not named in camelCase.
    Open

        function blocks_engine_upgrade() {
            echo '<h2>Updating blocks engine </h2>';
            if (!$this->table_exists('block_positions')) {
                $xoopsDB = $GLOBALS['xoopsDB'];
                $query = "CREATE TABLE `" . $xoopsDB->prefix('block_positions') . "` (

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $tpl_file is not named in camelCase.
    Open

        function apply_templates() {
            $db = $GLOBALS['xoopsDB'];
            $table = $db->prefix('tplfile');
            $table1 = $db->prefix('tplsource');
            $tpl_files = array(

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $tpl_file is not named in camelCase.
    Open

        function apply_templates() {
            $db = $GLOBALS['xoopsDB'];
            $table = $db->prefix('tplfile');
            $table1 = $db->prefix('tplsource');
            $tpl_files = array(

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The method apply_alter_tables is not named in camelCase.
    Open

        function apply_alter_tables() {
            $db = $GLOBALS['xoopsDB'];
            $this->fields = array (
                "config" => array (
                    "conf_desc" => "varchar(100)"

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
        public function get_name() {
        }
    }

    Source

    The method apply_conf_configcategory is not named in camelCase.
    Open

        function apply_conf_configcategory() {
            $db = $GLOBALS['xoopsDB'];
            if (getDbValue($db,'configcategory','confcat_id',' confcat_name="_MD_AM_MULTILANGUAGE"') != 0) {return true;}
            return $this->query(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id,confcat_name) VALUES ('','_MD_AM_MULTILANGUAGE')");
        }

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
        public function get_name() {
        }
    }

    Source

    The method check_conf_config is not named in camelCase.
    Open

        function check_conf_config() {
            $db = $GLOBALS['xoopsDB'];
            $value = getDbValue($db, 'config', 'conf_id', "`conf_name` = 'rank_width' AND `conf_catid` = " . XOOPS_CONF_USER);
            return (bool) ($value);
        }

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
        public function get_name() {
        }
    }

    Source

    The method apply_conf_config is not named in camelCase.
    Open

        function apply_conf_config() {
            $db = $GLOBALS['xoopsDB'];
            // Insert config values
            $table = $db->prefix('config');
            $data = array (

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
        public function get_name() {
        }
    }

    Source

    The method apply_new_blocks is not named in camelCase.
    Open

        function apply_new_blocks() {
            $db = $GLOBALS['xoopsDB'];
            if (getDbValue($db,'newblocks','bid',' show_func="b_system_multilanguage_show"') != 0) {return true;}
            $this->query(" INSERT INTO " . $db->prefix("newblocks") . " VALUES ('', 1, 0, '', 'Language Selection', 'Language Selection', '', 1, 0, 0, 'S', 'H', 1, 'system', 'system_blocks.php', 'b_system_multilanguage_show', '', 'system_block_multilanguage.html', 0, " . time() . ")");
            $new_block_id = $db->getInsertId();

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
        public function get_name() {
        }
    }

    Source

    The method table_exists is not named in camelCase.
    Open

        function table_exists($tablename) {
            global $xoopsDB;
            $query = "SHOW TABLES LIKE '" . $xoopsDB->prefix($tablename) . "'";
            $result = $xoopsDB->queryF($query);
            return ($xoopsDB->getRowsNum($result) > 0);

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
        public function get_name() {
        }
    }

    Source

    The method blocks_engine_upgrade is not named in camelCase.
    Open

        function blocks_engine_upgrade() {
            echo '<h2>Updating blocks engine </h2>';
            if (!$this->table_exists('block_positions')) {
                $xoopsDB = $GLOBALS['xoopsDB'];
                $query = "CREATE TABLE `" . $xoopsDB->prefix('block_positions') . "` (

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
        public function get_name() {
        }
    }

    Source

    The method apply_templates is not named in camelCase.
    Open

        function apply_templates() {
            $db = $GLOBALS['xoopsDB'];
            $table = $db->prefix('tplfile');
            $table1 = $db->prefix('tplsource');
            $tpl_files = array(

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
        public function get_name() {
        }
    }

    Source

    The method check_file_patch is not named in camelCase.
    Open

        function check_file_patch() {
            /* $path = XOOPS_ROOT_PATH . '/class/auth';
             $lines = file( "$path/auth_provisionning.php");
             foreach ( $lines as $line) {
                if (strpos( $line, "ldap_provisionning_upd" ) !== false) {

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
        public function get_name() {
        }
    }

    Source

    The method apply_ml_config is not named in camelCase.
    Open

        function apply_ml_config() {
            $db = $GLOBALS['xoopsDB'];
            // Insert config values
            $table = $db->prefix('config');
            $data = array (

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
        public function get_name() {
        }
    }

    Source

    The method cleaning_write_folders is not named in camelCase.
    Open

        function cleaning_write_folders() {
            $dir = array();
            $dir['templates_c'] = ICMS_COMPILE_PATH . "/";
            $dir['cache'] = ICMS_CACHE_PATH . "/";
    
    

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
        public function get_name() {
        }
    }

    Source

    Unexpected spaces found.
    Open

                      block_type varchar(1) NOT NULL default 'L',

    Unexpected spaces found.
    Open

                      block_default int(1) NOT NULL default '0',

    Unexpected spaces found.
    Open

                      description text,

    Unexpected spaces found.
    Open

                      );";

    Unexpected spaces found.
    Open

                      id int(11) NOT NULL auto_increment,

    Unexpected spaces found.
    Open

                      pname varchar(30) default '',

    Unexpected spaces found.
    Open

                      title varchar(90) NOT NULL default '',

    Unexpected spaces found.
    Open

                      PRIMARY KEY  (`id`)

    There are no issues that match your filters.

    Category
    Status