Sign upLogin

ImpressCMS/impresscms

View on GitHub
Star
upgrade/upd-icms-1.0-to-1.1/index.php

Summary

Maintainability
F
6 days
Test Coverage

apply accesses the super-global variable $_SESSION.
Open

    private function apply() {
        $tasks = $_SESSION[__CLASS__];
        foreach ($tasks as $task) {
            $res = $this->{"apply_{$task}"}();
            if (!$res) return false;
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_customblocks accesses the super-global variable $GLOBALS.
Open

    private function apply_customblocks() {
        $db = $GLOBALS['xoopsDB'];
        $result = $db->queryF("UPDATE ". $db->prefix('newblocks') . " SET mid=0 WHERE mid=1 AND func_num=0");
        return $result;
    }
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

isApplied accesses the super-global variable $_SESSION.
Open

    public function isApplied() {
        if (!isset($_SESSION[__CLASS__]) || !is_array($_SESSION[__CLASS__])) {
            $_SESSION[__CLASS__] = array();
        }
        foreach ($this->tasks as $task) {
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

isApplied accesses the super-global variable $_SESSION.
Open

    public function isApplied() {
        if (!isset($_SESSION[__CLASS__]) || !is_array($_SESSION[__CLASS__])) {
            $_SESSION[__CLASS__] = array();
        }
        foreach ($this->tasks as $task) {
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

isApplied accesses the super-global variable $_SESSION.
Open

    public function isApplied() {
        if (!isset($_SESSION[__CLASS__]) || !is_array($_SESSION[__CLASS__])) {
            $_SESSION[__CLASS__] = array();
        }
        foreach ($this->tasks as $task) {
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

convert_db accesses the super-global variable $GLOBALS.
Open

    private function convert_db($charset, $collation) {
        $sql = "ALTER DATABASE `" . XOOPS_DB_NAME . "` DEFAULT CHARACTER SET " . $GLOBALS["xoopsDB"]->quote($charset) . " COLLATE " . $GLOBALS["xoopsDB"]->quote($collation);
        if (!$GLOBALS["xoopsDB"]->queryF($sql)) {
            return false;
        }
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

convert_table accesses the super-global variable $GLOBALS.
Open

    private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

convert_db accesses the super-global variable $GLOBALS.
Open

    private function convert_db($charset, $collation) {
        $sql = "ALTER DATABASE `" . XOOPS_DB_NAME . "` DEFAULT CHARACTER SET " . $GLOBALS["xoopsDB"]->quote($charset) . " COLLATE " . $GLOBALS["xoopsDB"]->quote($collation);
        if (!$GLOBALS["xoopsDB"]->queryF($sql)) {
            return false;
        }
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

convert_db accesses the super-global variable $GLOBALS.
Open

    private function convert_db($charset, $collation) {
        $sql = "ALTER DATABASE `" . XOOPS_DB_NAME . "` DEFAULT CHARACTER SET " . $GLOBALS["xoopsDB"]->quote($charset) . " COLLATE " . $GLOBALS["xoopsDB"]->quote($collation);
        if (!$GLOBALS["xoopsDB"]->queryF($sql)) {
            return false;
        }
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

set_configs accesses the super-global variable $_POST.
Open

    private function set_configs($task) {
        $ret = array();
        $configs = include dirname(__FILE__) . "/settings_{$task}.php";
        if (!$configs || !is_array($configs)) {
            return $ret;
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

convert_table accesses the super-global variable $GLOBALS.
Open

    private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

convert_db accesses the super-global variable $GLOBALS.
Open

    private function convert_db($charset, $collation) {
        $sql = "ALTER DATABASE `" . XOOPS_DB_NAME . "` DEFAULT CHARACTER SET " . $GLOBALS["xoopsDB"]->quote($charset) . " COLLATE " . $GLOBALS["xoopsDB"]->quote($collation);
        if (!$GLOBALS["xoopsDB"]->queryF($sql)) {
            return false;
        }
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

convert_table accesses the super-global variable $GLOBALS.
Open

    private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

set_configs accesses the super-global variable $_POST.
Open

    private function set_configs($task) {
        $ret = array();
        $configs = include dirname(__FILE__) . "/settings_{$task}.php";
        if (!$configs || !is_array($configs)) {
            return $ret;
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

check_customblocks accesses the super-global variable $GLOBALS.
Open

    private function check_customblocks() {
        $result = $GLOBALS['xoopsDB']->queryF('SELECT `bid` FROM ' . $GLOBALS['xoopsDB']->prefix('newblocks') . ' WHERE `mid` = 0 AND `func_num` = 0');
        return count($GLOBALS['xoopsDB']->fetchArray($result)) > 0;
    }
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

check_customblocks accesses the super-global variable $GLOBALS.
Open

    private function check_customblocks() {
        $result = $GLOBALS['xoopsDB']->queryF('SELECT `bid` FROM ' . $GLOBALS['xoopsDB']->prefix('newblocks') . ' WHERE `mid` = 0 AND `func_num` = 0');
        return count($GLOBALS['xoopsDB']->fetchArray($result)) > 0;
    }
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

isApplied accesses the super-global variable $_SESSION.
Open

    public function isApplied() {
        if (!isset($_SESSION[__CLASS__]) || !is_array($_SESSION[__CLASS__])) {
            $_SESSION[__CLASS__] = array();
        }
        foreach ($this->tasks as $task) {
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply accesses the super-global variable $_SESSION.
Open

    private function apply() {
        $tasks = $_SESSION[__CLASS__];
        foreach ($tasks as $task) {
            $res = $this->{"apply_{$task}"}();
            if (!$res) return false;
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

check_customblocks accesses the super-global variable $GLOBALS.
Open

    private function check_customblocks() {
        $result = $GLOBALS['xoopsDB']->queryF('SELECT `bid` FROM ' . $GLOBALS['xoopsDB']->prefix('newblocks') . ' WHERE `mid` = 0 AND `func_num` = 0');
        return count($GLOBALS['xoopsDB']->fetchArray($result)) > 0;
    }
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

isApplied accesses the super-global variable $_SESSION.
Open

    public function isApplied() {
        if (!isset($_SESSION[__CLASS__]) || !is_array($_SESSION[__CLASS__])) {
            $_SESSION[__CLASS__] = array();
        }
        foreach ($this->tasks as $task) {
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

convert_table accesses the super-global variable $GLOBALS.
Open

    private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

convert_table accesses the super-global variable $GLOBALS.
Open

    private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

isApplied accesses the super-global variable $_SESSION.
Open

    public function isApplied() {
        if (!isset($_SESSION[__CLASS__]) || !is_array($_SESSION[__CLASS__])) {
            $_SESSION[__CLASS__] = array();
        }
        foreach ($this->tasks as $task) {
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

apply_conf accesses the super-global variable $GLOBALS.
Open

    private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

convert_db accesses the super-global variable $GLOBALS.
Open

    private function convert_db($charset, $collation) {
        $sql = "ALTER DATABASE `" . XOOPS_DB_NAME . "` DEFAULT CHARACTER SET " . $GLOBALS["xoopsDB"]->quote($charset) . " COLLATE " . $GLOBALS["xoopsDB"]->quote($collation);
        if (!$GLOBALS["xoopsDB"]->queryF($sql)) {
            return false;
        }
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

File index.php has 485 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Upgrade script of ImpressCMS 1.0 to 1.1
 *
 * @copyright    http://www.impresscms.org/ The ImpressCMS Project
Severity: Minor
Found in upgrade/upd-icms-1.0-to-1.1/index.php - About 7 hrs to fix

    Function apply_conf has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
    Open

        private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
    Severity: Minor
    Found in upgrade/upd-icms-1.0-to-1.1/index.php - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method apply_conf has 159 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
    Severity: Major
    Found in upgrade/upd-icms-1.0-to-1.1/index.php - About 6 hrs to fix

      Function convert_table has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
      Open

          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
      Severity: Minor
      Found in upgrade/upd-icms-1.0-to-1.1/index.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      upgrade_impcms06 has 29 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class upgrade_impcms06 {

    public $usedFiles = array ();
    private $tasks = array(
        'table1', 'table2', 'table3', 'table4', 'conf',
      Severity: Minor
      Found in upgrade/upd-icms-1.0-to-1.1/index.php - About 3 hrs to fix

        The class upgrade_impcms06 has 27 non-getter- and setter-methods. Consider refactoring upgrade_impcms06 to keep number of methods under 25.
        Open

        class upgrade_impcms06 {

    public $usedFiles = array ();
    private $tasks = array(
        'table1', 'table2', 'table3', 'table4', 'conf',
        Severity: Minor
        Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

        TooManyMethods

        Since: 0.1

        A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

        By default it ignores methods starting with 'get' or 'set'.

        The default was changed from 10 to 25 in PHPMD 2.3.

        Example

        Source https://phpmd.org/rules/codesize.html#toomanymethods

        The class upgrade_impcms06 has an overall complexity of 125 which is very high. The configured complexity threshold is 50.
        Open

        class upgrade_impcms06 {

    public $usedFiles = array ();
    private $tasks = array(
        'table1', 'table2', 'table3', 'table4', 'conf',
        Severity: Minor
        Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

        Method convert_table has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
        Severity: Minor
        Found in upgrade/upd-icms-1.0-to-1.1/index.php - About 1 hr to fix

          Method write_mainfile has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function write_mainfile($vars) {
        if (empty($vars)) {
            return false;
        }
          Severity: Minor
          Found in upgrade/upd-icms-1.0-to-1.1/index.php - About 1 hr to fix

            Function isApplied has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function isApplied() {
        if (!isset($_SESSION[__CLASS__]) || !is_array($_SESSION[__CLASS__])) {
            $_SESSION[__CLASS__] = array();
        }
        foreach ($this->tasks as $task) {
            Severity: Minor
            Found in upgrade/upd-icms-1.0-to-1.1/index.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function write_mainfile has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private function write_mainfile($vars) {
        if (empty($vars)) {
            return false;
        }
            Severity: Minor
            Found in upgrade/upd-icms-1.0-to-1.1/index.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function cleaning_write_folders has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private function cleaning_write_folders() {
        $dir = array();
        $dir['templates_c'] = XOOPS_ROOT_PATH . "/templates_c/";
        $dir['cache'] = XOOPS_ROOT_PATH . "/cache/";
            Severity: Minor
            Found in upgrade/upd-icms-1.0-to-1.1/index.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                            return false;
            Severity: Major
            Found in upgrade/upd-icms-1.0-to-1.1/index.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return false;
              Severity: Major
              Found in upgrade/upd-icms-1.0-to-1.1/index.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return false;
                Severity: Major
                Found in upgrade/upd-icms-1.0-to-1.1/index.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return false;
                  Severity: Major
                  Found in upgrade/upd-icms-1.0-to-1.1/index.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return false;
                    Severity: Major
                    Found in upgrade/upd-icms-1.0-to-1.1/index.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                      return false;
                      Severity: Major
                      Found in upgrade/upd-icms-1.0-to-1.1/index.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return false;
                        Severity: Major
                        Found in upgrade/upd-icms-1.0-to-1.1/index.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                          return false;
                          Severity: Major
                          Found in upgrade/upd-icms-1.0-to-1.1/index.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                            return false;
                            Severity: Major
                            Found in upgrade/upd-icms-1.0-to-1.1/index.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                              return false;
                              Severity: Major
                              Found in upgrade/upd-icms-1.0-to-1.1/index.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                                return false;
                                Severity: Major
                                Found in upgrade/upd-icms-1.0-to-1.1/index.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                                  return false;
                                  Severity: Major
                                  Found in upgrade/upd-icms-1.0-to-1.1/index.php - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                            return $result;
                                    Severity: Major
                                    Found in upgrade/upd-icms-1.0-to-1.1/index.php - About 30 mins to fix

                                      The method apply_conf() has 181 lines of code. Current threshold is set to 100. Avoid really long methods.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      The method apply_conf() has an NPath complexity of 47239200. The configured NPath complexity threshold is 200.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      NPathComplexity

                                      Since: 0.1

                                      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                      Example

                                      class Foo {
    function bar() {
        // lots of complicated code
    }
}

                                      Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                      The method convert_table() has an NPath complexity of 364. The configured NPath complexity threshold is 200.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      NPathComplexity

                                      Since: 0.1

                                      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                      Example

                                      class Foo {
    function bar() {
        // lots of complicated code
    }
}

                                      Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                      The method convert_table() has a Cyclomatic Complexity of 17. The configured cyclomatic complexity threshold is 10.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CyclomaticComplexity

                                      Since: 0.1

                                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                      Example

                                      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

                                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                      The method write_mainfile() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
                                      Open

                                          private function write_mainfile($vars) {
        if (empty($vars)) {
            return false;
        }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CyclomaticComplexity

                                      Since: 0.1

                                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                      Example

                                      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

                                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                      The method apply_conf() has a Cyclomatic Complexity of 32. The configured cyclomatic complexity threshold is 10.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CyclomaticComplexity

                                      Since: 0.1

                                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                      Example

                                      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

                                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                      Missing class import via use statement (line '77', column '16').
                                      Open

                                              $table = new IcmsDatabasetable('icmspage');
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      MissingImport

                                      Since: 2.7.0

                                      Importing all external classes in a file through use statements makes them clearly visible.

                                      Example

                                      function make() {
    return new \stdClass();
}

                                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                                      Missing class import via use statement (line '121', column '16').
                                      Open

                                              $table = new IcmsDatabasetable('invites');
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      MissingImport

                                      Since: 2.7.0

                                      Importing all external classes in a file through use statements makes them clearly visible.

                                      Example

                                      function make() {
    return new \stdClass();
}

                                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                                      Missing class import via use statement (line '179', column '16').
                                      Open

                                              $table = new IcmsDatabasetable('modules');
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      MissingImport

                                      Since: 2.7.0

                                      Importing all external classes in a file through use statements makes them clearly visible.

                                      Example

                                      function make() {
    return new \stdClass();
}

                                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                                      Missing class import via use statement (line '248', column '16').
                                      Open

                                              $table = new IcmsDatabasetable('users');
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      MissingImport

                                      Since: 2.7.0

                                      Importing all external classes in a file through use statements makes them clearly visible.

                                      Example

                                      function make() {
    return new \stdClass();
}

                                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                                      Missing class import via use statement (line '372', column '16').
                                      Open

                                              $table = new IcmsDatabasetable('modules');
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      MissingImport

                                      Since: 2.7.0

                                      Importing all external classes in a file through use statements makes them clearly visible.

                                      Example

                                      function make() {
    return new \stdClass();
}

                                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                                      Missing class import via use statement (line '71', column '16').
                                      Open

                                              $table = new IcmsDatabasetable('icmspage');
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      MissingImport

                                      Since: 2.7.0

                                      Importing all external classes in a file through use statements makes them clearly visible.

                                      Example

                                      function make() {
    return new \stdClass();
}

                                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                                      Missing class import via use statement (line '91', column '16').
                                      Open

                                              $table = new IcmsDatabasetable('icmscontent');
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      MissingImport

                                      Since: 2.7.0

                                      Importing all external classes in a file through use statements makes them clearly visible.

                                      Example

                                      function make() {
    return new \stdClass();
}

                                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                                      Missing class import via use statement (line '147', column '16').
                                      Open

                                              $table = new IcmsDatabasetable('system_customtag');
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      MissingImport

                                      Since: 2.7.0

                                      Importing all external classes in a file through use statements makes them clearly visible.

                                      Example

                                      function make() {
    return new \stdClass();
}

                                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                                      Missing class import via use statement (line '127', column '16').
                                      Open

                                              $table = new IcmsDatabasetable('invites');
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      MissingImport

                                      Since: 2.7.0

                                      Importing all external classes in a file through use statements makes them clearly visible.

                                      Example

                                      function make() {
    return new \stdClass();
}

                                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                                      Missing class import via use statement (line '153', column '16').
                                      Open

                                              $table = new IcmsDatabasetable('system_customtag');
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      MissingImport

                                      Since: 2.7.0

                                      Importing all external classes in a file through use statements makes them clearly visible.

                                      Example

                                      function make() {
    return new \stdClass();
}

                                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                                      Missing class import via use statement (line '366', column '16').
                                      Open

                                              $table = new IcmsDatabasetable('modules');
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      MissingImport

                                      Since: 2.7.0

                                      Importing all external classes in a file through use statements makes them clearly visible.

                                      Example

                                      function make() {
    return new \stdClass();
}

                                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                                      Missing class import via use statement (line '97', column '16').
                                      Open

                                              $table = new IcmsDatabasetable('icmscontent');
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      MissingImport

                                      Since: 2.7.0

                                      Importing all external classes in a file through use statements makes them clearly visible.

                                      Example

                                      function make() {
    return new \stdClass();
}

                                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                                      Avoid assigning values to variables in if clauses and the like (line '277', column '9').
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      IfStatementAssignment

                                      Since: 2.7.0

                                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                      Example

                                      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                      Avoid assigning values to variables in if clauses and the like (line '194', column '7').
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      IfStatementAssignment

                                      Since: 2.7.0

                                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                      Example

                                      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                      Avoid assigning values to variables in if clauses and the like (line '299', column '9').
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      IfStatementAssignment

                                      Since: 2.7.0

                                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                      Example

                                      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                      Avoid using static access to class 'XoopsDatabaseFactory' in method '__construct'.
                                      Open

                                              $this->updater = XoopsDatabaseFactory::getDatabaseUpdater();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      StaticAccess

                                      Since: 1.4.0

                                      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                      Example

                                      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

                                      Source https://phpmd.org/rules/cleancode.html#staticaccess

                                      Avoid assigning values to variables in if clauses and the like (line '257', column '8').
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      IfStatementAssignment

                                      Since: 2.7.0

                                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                      Example

                                      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                      The method write_mainfile uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                      Open

                                              } else {
            $newline = defined(PHP_EOL) ? PHP_EOL : (strpos(php_uname(), 'Windows') ? "\r\n" : "\n");
            $content = str_replace(array("\r\n", "\n"), $newline, implode('', $lines));

            fwrite($fp, $content);
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      ElseExpression

                                      Since: 1.4.0

                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                      Example

                                      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                      Avoid assigning values to variables in if clauses and the like (line '356', column '9').
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      IfStatementAssignment

                                      Since: 2.7.0

                                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                      Example

                                      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                      Avoid assigning values to variables in if clauses and the like (line '32', column '10').
                                      Open

                                          public function isApplied() {
        if (!isset($_SESSION[__CLASS__]) || !is_array($_SESSION[__CLASS__])) {
            $_SESSION[__CLASS__] = array();
        }
        foreach ($this->tasks as $task) {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      IfStatementAssignment

                                      Since: 2.7.0

                                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                      Example

                                      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                      Avoid assigning values to variables in if clauses and the like (line '219', column '7').
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      IfStatementAssignment

                                      Since: 2.7.0

                                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                      Example

                                      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                      Avoid assigning values to variables in if clauses and the like (line '243', column '9').
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      IfStatementAssignment

                                      Since: 2.7.0

                                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                      Example

                                      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                      Avoid assigning values to variables in if clauses and the like (line '292', column '9').
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      IfStatementAssignment

                                      Since: 2.7.0

                                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                      Example

                                      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                      Avoid assigning values to variables in if clauses and the like (line '421', column '8').
                                      Open

                                          private function update_configs($task) {
        if (!$vars = $this->set_configs($task)) {
            return false;
        }
        if ($task == "db" && !empty($vars["XOOPS_DB_COLLATION"])) {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      IfStatementAssignment

                                      Since: 2.7.0

                                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                      Example

                                      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                      Avoid assigning values to variables in if clauses and the like (line '439', column '8').
                                      Open

                                          private function convert_db($charset, $collation) {
        $sql = "ALTER DATABASE `" . XOOPS_DB_NAME . "` DEFAULT CHARACTER SET " . $GLOBALS["xoopsDB"]->quote($charset) . " COLLATE " . $GLOBALS["xoopsDB"]->quote($collation);
        if (!$GLOBALS["xoopsDB"]->queryF($sql)) {
            return false;
        }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      IfStatementAssignment

                                      Since: 2.7.0

                                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                      Example

                                      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                      Avoid assigning values to variables in if clauses and the like (line '251', column '8').
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      IfStatementAssignment

                                      Since: 2.7.0

                                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                      Example

                                      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                      Avoid assigning values to variables in if clauses and the like (line '284', column '9').
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      IfStatementAssignment

                                      Since: 2.7.0

                                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                      Example

                                      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                      Avoid assigning values to variables in if clauses and the like (line '310', column '9').
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      IfStatementAssignment

                                      Since: 2.7.0

                                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                      Example

                                      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                      Avoid assigning values to variables in if clauses and the like (line '318', column '7').
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      IfStatementAssignment

                                      Since: 2.7.0

                                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                      Example

                                      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                      Avoid assigning values to variables in if clauses and the like (line '270', column '9').
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      IfStatementAssignment

                                      Since: 2.7.0

                                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                      Example

                                      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                      Avoid assigning values to variables in if clauses and the like (line '263', column '8').
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      IfStatementAssignment

                                      Since: 2.7.0

                                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                      Example

                                      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                      Avoid assigning values to variables in if clauses and the like (line '425', column '8').
                                      Open

                                          private function update_configs($task) {
        if (!$vars = $this->set_configs($task)) {
            return false;
        }
        if ($task == "db" && !empty($vars["XOOPS_DB_COLLATION"])) {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      IfStatementAssignment

                                      Since: 2.7.0

                                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                      Example

                                      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

                                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                      Avoid unused private methods such as 'apply_conf'.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      UnusedPrivateMethod

                                      Since: 0.2

                                      Unused Private Method detects when a private method is declared but is unused.

                                      Example

                                      class Something
{
    private function foo() {} // unused
}

                                      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

                                      Avoid unused private methods such as 'apply'.
                                      Open

                                          private function apply() {
        $tasks = $_SESSION[__CLASS__];
        foreach ($tasks as $task) {
            $res = $this->{"apply_{$task}"}();
            if (!$res) return false;
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      UnusedPrivateMethod

                                      Since: 0.2

                                      Unused Private Method detects when a private method is declared but is unused.

                                      Example

                                      class Something
{
    private function foo() {} // unused
}

                                      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

                                      Avoid unused private methods such as 'check_table1'.
                                      Open

                                          private function check_table1() {
        $table = new IcmsDatabasetable('icmspage');
        return $table->exists();
    }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      UnusedPrivateMethod

                                      Since: 0.2

                                      Unused Private Method detects when a private method is declared but is unused.

                                      Example

                                      class Something
{
    private function foo() {} // unused
}

                                      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

                                      Avoid unused local variables such as '$res'.
                                      Open

                                                      if (!$res = $this->{"check_{$task}"}()) {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      UnusedLocalVariable

                                      Since: 0.2

                                      Detects when a local variable is declared and/or assigned, but not used.

                                      Example

                                      class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

                                      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                      Avoid unused private methods such as 'check_table3'.
                                      Open

                                          private function check_table3() {
        $table = new IcmsDatabasetable('invites');
        return $table->exists();
    }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      UnusedPrivateMethod

                                      Since: 0.2

                                      Unused Private Method detects when a private method is declared but is unused.

                                      Example

                                      class Something
{
    private function foo() {} // unused
}

                                      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

                                      Avoid unused private methods such as 'check_dbversion'.
                                      Open

                                          private function check_dbversion() {
        $table = new IcmsDatabasetable('modules');
        return $table->fieldExists('dbversion');
    }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      UnusedPrivateMethod

                                      Since: 0.2

                                      Unused Private Method detects when a private method is declared but is unused.

                                      Example

                                      class Something
{
    private function foo() {} // unused
}

                                      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

                                      Avoid unused private methods such as 'apply_trust_path'.
                                      Open

                                          private function apply_trust_path() {
        return $this->update_configs('trust_path');
    }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      UnusedPrivateMethod

                                      Since: 0.2

                                      Unused Private Method detects when a private method is declared but is unused.

                                      Example

                                      class Something
{
    private function foo() {} // unused
}

                                      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

                                      Avoid unused private methods such as 'check_salt'.
                                      Open

                                          private function check_salt() {
        $lines = file(XOOPS_ROOT_PATH . '/mainfile.php');
        foreach ($lines as $line) {
            if (preg_match("/(define\(\s*)([\"'])(XOOPS_DB_SALT)\\2,\s*([\"'])([^\"']*?)\\4\s*\);/", $line)) {
                return true;
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      UnusedPrivateMethod

                                      Since: 0.2

                                      Unused Private Method detects when a private method is declared but is unused.

                                      Example

                                      class Something
{
    private function foo() {} // unused
}

                                      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

                                      Avoid unused private methods such as 'apply_table4'.
                                      Open

                                          private function apply_table4() {
        // Create table system_customtag
        $table = new IcmsDatabasetable('system_customtag');
        if (!$table->exists()) {
            $table->setStructure("`customtagid` int(11) unsigned NOT NULL auto_increment,
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      UnusedPrivateMethod

                                      Since: 0.2

                                      Unused Private Method detects when a private method is declared but is unused.

                                      Example

                                      class Something
{
    private function foo() {} // unused
}

                                      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

                                      Avoid unused private methods such as 'check_table4'.
                                      Open

                                          private function check_table4() {
        $table = new IcmsDatabasetable('system_customtag');
        return $table->exists();
    }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      UnusedPrivateMethod

                                      Since: 0.2

                                      Unused Private Method detects when a private method is declared but is unused.

                                      Example

                                      class Something
{
    private function foo() {} // unused
}

                                      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

                                      Avoid unused private methods such as 'check_table2'.
                                      Open

                                          private function check_table2() {
        $table = new IcmsDatabasetable('icmscontent');
        return $table->exists();
    }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      UnusedPrivateMethod

                                      Since: 0.2

                                      Unused Private Method detects when a private method is declared but is unused.

                                      Example

                                      class Something
{
    private function foo() {} // unused
}

                                      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

                                      Avoid unused private methods such as 'apply_table3'.
                                      Open

                                          private function apply_table3() {
        // Create table invites
        $table = new IcmsDatabasetable('invites');
        if (!$table->exists()) {
            $table->setStructure("`invite_id` mediumint(8) unsigned NOT NULL auto_increment,
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      UnusedPrivateMethod

                                      Since: 0.2

                                      Unused Private Method detects when a private method is declared but is unused.

                                      Example

                                      class Something
{
    private function foo() {} // unused
}

                                      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

                                      Avoid unused private methods such as 'check_conf'.
                                      Open

                                          private function check_conf() {
        $table = new IcmsDatabasetable('modules');
        return $table->fieldExists('dbversion');
    }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      UnusedPrivateMethod

                                      Since: 0.2

                                      Unused Private Method detects when a private method is declared but is unused.

                                      Example

                                      class Something
{
    private function foo() {} // unused
}

                                      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

                                      Avoid unused private methods such as 'apply_salt'.
                                      Open

                                          private function apply_salt() {
        return $this->update_configs('salt');
    }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      UnusedPrivateMethod

                                      Since: 0.2

                                      Unused Private Method detects when a private method is declared but is unused.

                                      Example

                                      class Something
{
    private function foo() {} // unused
}

                                      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

                                      Avoid unused private methods such as 'apply_db'.
                                      Open

                                          private function apply_db() {
        return $this->update_configs('db');
    }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      UnusedPrivateMethod

                                      Since: 0.2

                                      Unused Private Method detects when a private method is declared but is unused.

                                      Example

                                      class Something
{
    private function foo() {} // unused
}

                                      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

                                      Avoid unused private methods such as 'check_customblocks'.
                                      Open

                                          private function check_customblocks() {
        $result = $GLOBALS['xoopsDB']->queryF('SELECT `bid` FROM ' . $GLOBALS['xoopsDB']->prefix('newblocks') . ' WHERE `mid` = 0 AND `func_num` = 0');
        return count($GLOBALS['xoopsDB']->fetchArray($result)) > 0;
    }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      UnusedPrivateMethod

                                      Since: 0.2

                                      Unused Private Method detects when a private method is declared but is unused.

                                      Example

                                      class Something
{
    private function foo() {} // unused
}

                                      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

                                      Avoid unused private methods such as 'apply_table2'.
                                      Open

                                          private function apply_table2() {
        // Create table icmscontent
        $table = new IcmsDatabasetable('icmscontent');
        if (!$table->exists()) {
            $table->setStructure("`content_id` mediumint(8) unsigned NOT NULL auto_increment,
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      UnusedPrivateMethod

                                      Since: 0.2

                                      Unused Private Method detects when a private method is declared but is unused.

                                      Example

                                      class Something
{
    private function foo() {} // unused
}

                                      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

                                      Avoid unused private methods such as 'apply_dbversion'.
                                      Open

                                          private function apply_dbversion() {
        // First let's create the dbversion field in the modules table
        $table = new IcmsDatabasetable('modules');
        $table->addNewField('dbversion', 'INT(11) unsigned NOT NULL DEFAULT 1');
        return $this->updater->updateTable($table, true);
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      UnusedPrivateMethod

                                      Since: 0.2

                                      Unused Private Method detects when a private method is declared but is unused.

                                      Example

                                      class Something
{
    private function foo() {} // unused
}

                                      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

                                      Avoid unused private methods such as 'check_trust_path'.
                                      Open

                                          private function check_trust_path() {
        $lines = file(XOOPS_ROOT_PATH . '/mainfile.php');
        foreach ($lines as $line) {
            $trustcheck = defined("XOOPS_TRUST_PATH") && XOOPS_TRUST_PATH != '';
            if (preg_match("/(define\(\s*)([\"'])(XOOPS_TRUST_PATH)\\2,\s*([\"'])([^\"']*?)\\4\s*\);/", $line) && $trustcheck) {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      UnusedPrivateMethod

                                      Since: 0.2

                                      Unused Private Method detects when a private method is declared but is unused.

                                      Example

                                      class Something
{
    private function foo() {} // unused
}

                                      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

                                      Avoid unused private methods such as 'apply_table1'.
                                      Open

                                          private function apply_table1() {
        // Create table icmspage
        $table = new IcmsDatabasetable('icmspage');
        if (!$table->exists()) {
            $table->setStructure("page_id mediumint(8) unsigned NOT NULL auto_increment,
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      UnusedPrivateMethod

                                      Since: 0.2

                                      Unused Private Method detects when a private method is declared but is unused.

                                      Example

                                      class Something
{
    private function foo() {} // unused
}

                                      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

                                      Avoid unused private methods such as 'apply_customblocks'.
                                      Open

                                          private function apply_customblocks() {
        $db = $GLOBALS['xoopsDB'];
        $result = $db->queryF("UPDATE ". $db->prefix('newblocks') . " SET mid=0 WHERE mid=1 AND func_num=0");
        return $result;
    }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      UnusedPrivateMethod

                                      Since: 0.2

                                      Unused Private Method detects when a private method is declared but is unused.

                                      Example

                                      class Something
{
    private function foo() {} // unused
}

                                      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

                                      Avoid unused private methods such as 'check_db'.
                                      Open

                                          private function check_db() {
        $lines = file(XOOPS_ROOT_PATH . '/mainfile.php');
        foreach ($lines as $line) {
            if (preg_match("/(define\(\s*)([\"'])(XOOPS_DB_CHARSET)\\2,\s*([\"'])([^\"']*?)\\4\s*\);/", $line)) {
                return true;
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      UnusedPrivateMethod

                                      Since: 0.2

                                      Unused Private Method detects when a private method is declared but is unused.

                                      Example

                                      class Something
{
    private function foo() {} // unused
}

                                      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

                                      Avoid using count() function in for loops.
                                      Open

                                                              for ($i = 1; $i <= count($column); $i++)
                        $tmp_gen_index_query .= $fields_names[$i - 1] . (($i == count($column)) ? '' : ', ');
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CountInLoopExpression

                                      Since: 2.7.0

                                      Using count/sizeof in loops expressions is considered bad practice and is a potential source of many bugs, especially when the loop manipulates an array, as count happens on each iteration.

                                      Example

                                      class Foo {

  public function bar()
  {
    $array = array();

    for ($i = 0; count($array); $i++) {
      // ...
    }
  }
}

                                      Source https://phpmd.org/rules/design.html#countinloopexpression

                                      Call to method setStructure from undeclared class \IcmsDatabasetable
                                      Open

                                                  $table->setStructure("page_id mediumint(8) unsigned NOT NULL auto_increment,
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method __construct from undeclared class \IcmsDatabasetable
                                      Open

                                              $table = new IcmsDatabasetable('invites');
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method setStructure from undeclared class \IcmsDatabasetable
                                      Open

                                                  $table->setStructure("`invite_id` mediumint(8) unsigned NOT NULL auto_increment,
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method __construct from undeclared class \IcmsDatabasetable
                                      Open

                                              $table = new IcmsDatabasetable('users');
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method fieldExists from undeclared class \IcmsDatabasetable
                                      Open

                                              if (!$table->fieldExists('openid')) {
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method exists from undeclared class \IcmsDatabasetable
                                      Open

                                              if (!$table->exists()) {
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to deprecated function \icms_debug() defined at /code/htdocs/include/debug_functions.php:22
                                      Open

                                                  icms_debug('An error occurred while executing "' . $sql . '" - ' . $GLOBALS['xoopsDB']->error());
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method fieldExists from undeclared class \IcmsDatabasetable
                                      Open

                                              if (!$table->fieldExists('user_viewoid')) {
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method exists from undeclared class \IcmsDatabasetable
                                      Open

                                              return $table->exists();
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method __construct from undeclared class \IcmsDatabasetable
                                      Open

                                              $table = new IcmsDatabasetable('system_customtag');
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method __construct from undeclared class \IcmsDatabasetable
                                      Open

                                              $table = new IcmsDatabasetable('modules');
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method setStructure from undeclared class \IcmsDatabasetable
                                      Open

                                                  $table->setStructure("`content_id` mediumint(8) unsigned NOT NULL auto_increment,
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to deprecated function \icms_debug() defined at /code/htdocs/include/debug_functions.php:22
                                      Open

                                                      icms_debug('An error occurred while executing "' . $sql . '" - ' . $GLOBALS['xoopsDB']->error());
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method getDatabaseUpdater from undeclared class \XoopsDatabaseFactory
                                      Open

                                              $this->updater = XoopsDatabaseFactory::getDatabaseUpdater();
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method exists from undeclared class \IcmsDatabasetable
                                      Open

                                              return $table->exists();
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to deprecated function \icms_debug() defined at /code/htdocs/include/debug_functions.php:22
                                      Open

                                                      icms_debug('An error occurred while executing "' . $sql . '" - ' . $GLOBALS['xoopsDB']->error());
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to deprecated function \icms_debug() defined at /code/htdocs/include/debug_functions.php:22
                                      Open

                                                      icms_debug('An error occurred while executing "' . $sql . '" - ' . $GLOBALS['xoopsDB']->error());
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method fieldExists from undeclared class \IcmsDatabasetable
                                      Open

                                              if (!$table->fieldExists('enc_type')) {
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method __construct from undeclared class \IcmsDatabasetable
                                      Open

                                              $table = new IcmsDatabasetable('icmspage');
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method exists from undeclared class \IcmsDatabasetable
                                      Open

                                              return $table->exists();
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method exists from undeclared class \IcmsDatabasetable
                                      Open

                                              if (!$table->exists()) {
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method __construct from undeclared class \IcmsDatabasetable
                                      Open

                                              $table = new IcmsDatabasetable('icmscontent');
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method exists from undeclared class \IcmsDatabasetable
                                      Open

                                              return $table->exists();
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method __construct from undeclared class \IcmsDatabasetable
                                      Open

                                              $table = new IcmsDatabasetable('icmscontent');
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method __construct from undeclared class \IcmsDatabasetable
                                      Open

                                              $table = new IcmsDatabasetable('invites');
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method exists from undeclared class \IcmsDatabasetable
                                      Open

                                              if (!$table->exists()) {
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method exists from undeclared class \IcmsDatabasetable
                                      Open

                                              if (!$table->exists()) {
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to deprecated function \icms_debug() defined at /code/htdocs/include/debug_functions.php:22
                                      Open

                                                  icms_debug('An error occurred while executing "' . $sql . '" - ' . $GLOBALS['xoopsDB']->error());
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method fieldExists from undeclared class \IcmsDatabasetable
                                      Open

                                              if (!$table->fieldExists('salt')) {
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method fieldExists from undeclared class \IcmsDatabasetable
                                      Open

                                              return $table->fieldExists('dbversion');
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to deprecated function \icms_debug() defined at /code/htdocs/include/debug_functions.php:22
                                      Open

                                                      icms_debug('An error occurred while executing "' . $sql . '" - ' . $GLOBALS['xoopsDB']->error());
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to deprecated function \icms_debug() defined at /code/htdocs/include/debug_functions.php:22
                                      Open

                                                  icms_debug('An error occurred while executing "' . $sql . '" - ' . $GLOBALS['xoopsDB']->error());
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method setStructure from undeclared class \IcmsDatabasetable
                                      Open

                                                  $table->setStructure("`customtagid` int(11) unsigned NOT NULL auto_increment,
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method __construct from undeclared class \IcmsDatabasetable
                                      Open

                                              $table = new IcmsDatabasetable('icmspage');
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method __construct from undeclared class \IcmsDatabasetable
                                      Open

                                              $table = new IcmsDatabasetable('system_customtag');
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method fieldExists from undeclared class \IcmsDatabasetable
                                      Open

                                              if (!$table->fieldExists('pass_expired')) {
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method __construct from undeclared class \IcmsDatabasetable
                                      Open

                                              $table = new IcmsDatabasetable('modules');
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method fieldExists from undeclared class \IcmsDatabasetable
                                      Open

                                              return $table->fieldExists('dbversion');
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to deprecated function \icms_debug() defined at /code/htdocs/include/debug_functions.php:22
                                      Open

                                                      icms_debug('An error occurred while executing "' . $sql . '" - ' . $GLOBALS['xoopsDB']->error());
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to deprecated function \icms_debug() defined at /code/htdocs/include/debug_functions.php:22
                                      Open

                                                      icms_debug('An error occurred while executing "' . $sql . '" - ' . $GLOBALS['xoopsDB']->error());
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method __construct from undeclared class \IcmsDatabasetable
                                      Open

                                              $table = new IcmsDatabasetable('modules');
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Call to method addNewField from undeclared class \IcmsDatabasetable
                                      Open

                                              $table->addNewField('dbversion', 'INT(11) unsigned NOT NULL DEFAULT 1');
                                      Severity: Critical
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phan

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                          private function cleaning_write_folders() {
        $dir = array();
        $dir['templates_c'] = XOOPS_ROOT_PATH . "/templates_c/";
        $dir['cache'] = XOOPS_ROOT_PATH . "/cache/";
                                      Severity: Major
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php and 1 other location - About 3 hrs to fix
                                      upgrade/upd-2.0.18-to-impresscms-1.0/index.php on lines 17..35

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 153.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 3 locations. Consider refactoring.
                                      Open

                                          public function isApplied() {
        if (!isset($_SESSION[__CLASS__]) || !is_array($_SESSION[__CLASS__])) {
            $_SESSION[__CLASS__] = array();
        }
        foreach ($this->tasks as $task) {
                                      Severity: Major
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php and 2 other locations - About 2 hrs to fix
                                      upgrade/cnt-2.2.x-to-2.0.x/index.php on lines 25..38
                                      upgrade/cnt-2.3.x-to-2.0.x/index.php on lines 19..32

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 128.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 5 locations. Consider refactoring.
                                      Open

                                              if (!$table->fieldExists('enc_type')) {
            $sql = "ALTER TABLE `" . $GLOBALS['xoopsDB']->prefix('users') . "` ADD enc_type tinyint(2) unsigned NOT NULL default '0'";
            if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
                icms_debug('An error occurred while executing "' . $sql . '" - ' . $GLOBALS['xoopsDB']->error());
                return false;
                                      Severity: Major
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php and 4 other locations - About 40 mins to fix
                                      upgrade/upd-icms-1.0-to-1.1/index.php on lines 268..274
                                      upgrade/upd-icms-1.0-to-1.1/index.php on lines 275..281
                                      upgrade/upd-icms-1.0-to-1.1/index.php on lines 282..288
                                      upgrade/upd-icms-1.0-to-1.1/index.php on lines 290..296

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 94.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 5 locations. Consider refactoring.
                                      Open

                                              if (!$table->fieldExists('pass_expired')) {
            $sql = "ALTER TABLE `" . $GLOBALS['xoopsDB']->prefix('users') . "` ADD pass_expired tinyint(1) NOT NULL default '0'";
            if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
                icms_debug('An error occurred while executing "' . $sql . '" - ' . $GLOBALS['xoopsDB']->error());
                return false;
                                      Severity: Major
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php and 4 other locations - About 40 mins to fix
                                      upgrade/upd-icms-1.0-to-1.1/index.php on lines 268..274
                                      upgrade/upd-icms-1.0-to-1.1/index.php on lines 275..281
                                      upgrade/upd-icms-1.0-to-1.1/index.php on lines 282..288
                                      upgrade/upd-icms-1.0-to-1.1/index.php on lines 297..303

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 94.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 5 locations. Consider refactoring.
                                      Open

                                              if (!$table->fieldExists('openid')) {
            $sql = "ALTER TABLE `" . $GLOBALS['xoopsDB']->prefix('users') . "` ADD openid varchar(255) NOT NULL default ''";
            if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
                icms_debug('An error occurred while executing "' . $sql . '" - ' . $GLOBALS['xoopsDB']->error());
                return false;
                                      Severity: Major
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php and 4 other locations - About 40 mins to fix
                                      upgrade/upd-icms-1.0-to-1.1/index.php on lines 275..281
                                      upgrade/upd-icms-1.0-to-1.1/index.php on lines 282..288
                                      upgrade/upd-icms-1.0-to-1.1/index.php on lines 290..296
                                      upgrade/upd-icms-1.0-to-1.1/index.php on lines 297..303

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 94.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 5 locations. Consider refactoring.
                                      Open

                                              if (!$table->fieldExists('salt')) {
            $sql = "ALTER TABLE `" . $GLOBALS['xoopsDB']->prefix('users') . "` ADD salt varchar(255) NOT NULL default ''";
            if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
                icms_debug('An error occurred while executing "' . $sql . '" - ' . $GLOBALS['xoopsDB']->error());
                return false;
                                      Severity: Major
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php and 4 other locations - About 40 mins to fix
                                      upgrade/upd-icms-1.0-to-1.1/index.php on lines 268..274
                                      upgrade/upd-icms-1.0-to-1.1/index.php on lines 282..288
                                      upgrade/upd-icms-1.0-to-1.1/index.php on lines 290..296
                                      upgrade/upd-icms-1.0-to-1.1/index.php on lines 297..303

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 94.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 5 locations. Consider refactoring.
                                      Open

                                              if (!$table->fieldExists('user_viewoid')) {
            $sql = "ALTER TABLE `" . $GLOBALS['xoopsDB']->prefix('users') . "` ADD user_viewoid tinyint(1) unsigned NOT NULL default '0'";
            if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
                icms_debug('An error occurred while executing "' . $sql . '" - ' . $GLOBALS['xoopsDB']->error());
                return false;
                                      Severity: Major
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php and 4 other locations - About 40 mins to fix
                                      upgrade/upd-icms-1.0-to-1.1/index.php on lines 268..274
                                      upgrade/upd-icms-1.0-to-1.1/index.php on lines 275..281
                                      upgrade/upd-icms-1.0-to-1.1/index.php on lines 290..296
                                      upgrade/upd-icms-1.0-to-1.1/index.php on lines 297..303

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 94.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Avoid excessively long variable names like $passwordmeter_installed. Keep variable name length under 20.
                                      Open

                                              $passwordmeter_installed = false;
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      LongVariable

                                      Since: 0.2

                                      Detects when a field, formal or local variable is declared with a long name.

                                      Example

                                      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

                                      Source https://phpmd.org/rules/naming.html#longvariable

                                      Each class must be in a namespace of at least one level (a top-level vendor name)
                                      Open

                                      class upgrade_impcms06 {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      The class upgrade_impcms06 is not named in CamelCase.
                                      Open

                                      class upgrade_impcms06 {

    public $usedFiles = array ();
    private $tasks = array(
        'table1', 'table2', 'table3', 'table4', 'conf',
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseClassName

                                      Since: 0.2

                                      It is considered best practice to use the CamelCase notation to name classes.

                                      Example

                                      class class_name {
}

                                      Source

                                      Avoid variables with short names like $fp. Configured minimum length is 3.
                                      Open

                                              $fp = fopen(XOOPS_ROOT_PATH . '/mainfile.php', 'wt');
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      ShortVariable

                                      Since: 0.2

                                      Detects when a field, local, or parameter has a very short name.

                                      Example

                                      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                                      Source https://phpmd.org/rules/naming.html#shortvariable

                                      Avoid variables with short names like $db. Configured minimum length is 3.
                                      Open

                                              $db = $GLOBALS['xoopsDB'];
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      ShortVariable

                                      Since: 0.2

                                      Detects when a field, local, or parameter has a very short name.

                                      Example

                                      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                                      Source https://phpmd.org/rules/naming.html#shortvariable

                                      Avoid variables with short names like $dd. Configured minimum length is 3.
                                      Open

                                                  $dd = opendir($d);
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      ShortVariable

                                      Since: 0.2

                                      Detects when a field, local, or parameter has a very short name.

                                      Example

                                      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                                      Source https://phpmd.org/rules/naming.html#shortvariable

                                      Avoid variables with short names like $db. Configured minimum length is 3.
                                      Open

                                              $db = $GLOBALS['xoopsDB'];
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      ShortVariable

                                      Since: 0.2

                                      Detects when a field, local, or parameter has a very short name.

                                      Example

                                      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                                      Source https://phpmd.org/rules/naming.html#shortvariable

                                      Method name "upgrade_impcms06::cleaning_write_folders" is not in camel caps format
                                      Open

                                          private function cleaning_write_folders() {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::apply_conf" is not in camel caps format
                                      Open

                                          private function apply_conf() {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::check_dbversion" is not in camel caps format
                                      Open

                                          private function check_dbversion() {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::apply_trust_path" is not in camel caps format
                                      Open

                                          private function apply_trust_path() {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::check_table2" is not in camel caps format
                                      Open

                                          private function check_table2() {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::apply_customblocks" is not in camel caps format
                                      Open

                                          private function apply_customblocks() {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Blank line found at end of control structure
                                      Open
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::check_db" is not in camel caps format
                                      Open

                                          private function check_db() {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::write_mainfile" is not in camel caps format
                                      Open

                                          private function write_mainfile($vars) {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::apply_salt" is not in camel caps format
                                      Open

                                          private function apply_salt() {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::apply_db" is not in camel caps format
                                      Open

                                          private function apply_db() {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Function closing brace must go on the next line following the body; found 1 blank lines before brace
                                      Open

                                          }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::apply_dbversion" is not in camel caps format
                                      Open

                                          private function apply_dbversion() {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::check_trust_path" is not in camel caps format
                                      Open

                                          private function check_trust_path() {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::check_table3" is not in camel caps format
                                      Open

                                          private function check_table3() {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::apply_table4" is not in camel caps format
                                      Open

                                          private function apply_table4() {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::check_conf" is not in camel caps format
                                      Open

                                          private function check_conf() {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::convert_db" is not in camel caps format
                                      Open

                                          private function convert_db($charset, $collation) {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::check_table1" is not in camel caps format
                                      Open

                                          private function check_table1() {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::check_customblocks" is not in camel caps format
                                      Open

                                          private function check_customblocks() {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::convert_table" is not in camel caps format
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::check_table4" is not in camel caps format
                                      Open

                                          private function check_table4() {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::set_configs" is not in camel caps format
                                      Open

                                          private function set_configs($task) {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::update_configs" is not in camel caps format
                                      Open

                                          private function update_configs($task) {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::apply_table1" is not in camel caps format
                                      Open

                                          private function apply_table1() {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::apply_table2" is not in camel caps format
                                      Open

                                          private function apply_table2() {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Function closing brace must go on the next line following the body; found 1 blank lines before brace
                                      Open

                                          }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::apply_table3" is not in camel caps format
                                      Open

                                          private function apply_table3() {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Method name "upgrade_impcms06::check_salt" is not in camel caps format
                                      Open

                                          private function check_salt() {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Inline control structures are not allowed
                                      Open

                                                              for ($i = 1; $i <= count($column); $i++)
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Inline control structures are not allowed
                                      Open

                                                          if (preg_match('/FULLTEXT/', $result['Index_type']))
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Inline control structures are not allowed
                                      Open

                                                  if (!$res) return false;
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Space before opening parenthesis of function call prohibited
                                      Open

                                              unset ($table);
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Expected 1 space after closing parenthesis; found 0
                                      Open

                                              if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Space before opening parenthesis of function call prohibited
                                      Open

                                              unset ($table);
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Opening parenthesis of a multi-line function call must be the last content on the line
                                      Open

                                                      $lines[$ln] = preg_replace("/(define\()([\"'])(XOOPS_[^\"']+)\\2,\s*([0-9]+)\s*\)/",
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Opening parenthesis of a multi-line function call must be the last content on the line
                                      Open

                                                      $lines[$ln] = preg_replace("/(define\()([\"'])(XOOPS_[^\"']+)\\2,\s*([\"'])(.*?)\\4\s*\)/",
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Closing parenthesis of a multi-line function call must be on a line by itself
                                      Open

                                                      $lines[$ln]);
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Newline required after opening brace
                                      Open

                                              if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Expected 1 space after WHILE keyword; 0 found
                                      Open

                                                  while($file = readdir($dd))
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Expected 1 space after closing parenthesis; found 9
                                      Open

                                              foreach ($dir as $d)
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Newline required after opening brace
                                      Open

                                              if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Expected 1 space after IF keyword; 0 found
                                      Open

                                                      if(is_file($d.$file) && ($file != 'index.html' && $file != 'php.ini' && $file != '.htaccess'))
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Space before opening parenthesis of function call prohibited
                                      Open

                                              unset ($table);
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Expected 1 space after closing parenthesis; found 17
                                      Open

                                                      if(is_file($d.$file) && ($file != 'index.html' && $file != 'php.ini' && $file != '.htaccess'))
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Closing parenthesis of a multi-line function call must be on a line by itself
                                      Open

                                                      $lines[$ln]);
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Class name "upgrade_impcms06" is not in camel caps format
                                      Open

                                      class upgrade_impcms06 {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Expected 1 space after closing parenthesis; found 13
                                      Open

                                                  while($file = readdir($dd))
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Space before opening parenthesis of function call prohibited
                                      Open

                                              unset ($table);
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Closing brace must be on a line by itself
                                      Open

                                              if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Closing brace must be on a line by itself
                                      Open

                                              if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      Expected 1 space after closing parenthesis; found 0
                                      Open

                                              if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpcodesniffer

                                      The variable $passwordmeter_installed is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $config_id is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $config_id is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $config_id is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $tmp_gen_index_query is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $final_querys is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $passwordmeter_installed is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $config_id is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $pw_salt_installed is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $config_id is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $config_id is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $drop_index_querys is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $config_id is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $fields_names is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $config_id is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $config_id is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $config_id is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $final_querys is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $fields_names is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $config_id is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $drop_index_querys is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $drop_index_querys is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $final_querys is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $key_name is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $config_id is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $tables_querys is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $optimize_querys is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $tmp_gen_index_query is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $passwordmeter_installed is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $optimize_querys is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $registration_type is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $pw_salt_installed is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $config_id is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $config_id is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $col_query is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $config_id is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $final_querys is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $pw_salt_installed is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $config_id is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $col_query is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $tables_querys is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $binary_querys is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $registration_type is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $config_id is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $config_id is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $config_id is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $fulltext_indexes is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $config_id is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $config_id is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $fulltext_indexes is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $config_id is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $config_id is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $fulltext_indexes is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $gen_index_querys is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $col_query is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $tables_querys is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $gen_index_querys is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $string_querys is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $registration_type is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $fulltext_indexes is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $key_name is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $tmp_gen_index_query is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $string_querys is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $binary_querys is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $gen_index_querys is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $string_querys is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $key_name is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The variable $optimize_querys is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseVariableName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name variables.

                                      Example

                                      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

                                      Source

                                      The method apply_table2 is not named in camelCase.
                                      Open

                                          private function apply_table2() {
        // Create table icmscontent
        $table = new IcmsDatabasetable('icmscontent');
        if (!$table->exists()) {
            $table->setStructure("`content_id` mediumint(8) unsigned NOT NULL auto_increment,
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method apply_table1 is not named in camelCase.
                                      Open

                                          private function apply_table1() {
        // Create table icmspage
        $table = new IcmsDatabasetable('icmspage');
        if (!$table->exists()) {
            $table->setStructure("page_id mediumint(8) unsigned NOT NULL auto_increment,
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method apply_salt is not named in camelCase.
                                      Open

                                          private function apply_salt() {
        return $this->update_configs('salt');
    }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method check_salt is not named in camelCase.
                                      Open

                                          private function check_salt() {
        $lines = file(XOOPS_ROOT_PATH . '/mainfile.php');
        foreach ($lines as $line) {
            if (preg_match("/(define\(\s*)([\"'])(XOOPS_DB_SALT)\\2,\s*([\"'])([^\"']*?)\\4\s*\);/", $line)) {
                return true;
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method check_conf is not named in camelCase.
                                      Open

                                          private function check_conf() {
        $table = new IcmsDatabasetable('modules');
        return $table->fieldExists('dbversion');
    }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method apply_dbversion is not named in camelCase.
                                      Open

                                          private function apply_dbversion() {
        // First let's create the dbversion field in the modules table
        $table = new IcmsDatabasetable('modules');
        $table->addNewField('dbversion', 'INT(11) unsigned NOT NULL DEFAULT 1');
        return $this->updater->updateTable($table, true);
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method check_db is not named in camelCase.
                                      Open

                                          private function check_db() {
        $lines = file(XOOPS_ROOT_PATH . '/mainfile.php');
        foreach ($lines as $line) {
            if (preg_match("/(define\(\s*)([\"'])(XOOPS_DB_CHARSET)\\2,\s*([\"'])([^\"']*?)\\4\s*\);/", $line)) {
                return true;
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method apply_db is not named in camelCase.
                                      Open

                                          private function apply_db() {
        return $this->update_configs('db');
    }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method apply_table3 is not named in camelCase.
                                      Open

                                          private function apply_table3() {
        // Create table invites
        $table = new IcmsDatabasetable('invites');
        if (!$table->exists()) {
            $table->setStructure("`invite_id` mediumint(8) unsigned NOT NULL auto_increment,
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method apply_table4 is not named in camelCase.
                                      Open

                                          private function apply_table4() {
        // Create table system_customtag
        $table = new IcmsDatabasetable('system_customtag');
        if (!$table->exists()) {
            $table->setStructure("`customtagid` int(11) unsigned NOT NULL auto_increment,
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method check_customblocks is not named in camelCase.
                                      Open

                                          private function check_customblocks() {
        $result = $GLOBALS['xoopsDB']->queryF('SELECT `bid` FROM ' . $GLOBALS['xoopsDB']->prefix('newblocks') . ' WHERE `mid` = 0 AND `func_num` = 0');
        return count($GLOBALS['xoopsDB']->fetchArray($result)) > 0;
    }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method check_table2 is not named in camelCase.
                                      Open

                                          private function check_table2() {
        $table = new IcmsDatabasetable('icmscontent');
        return $table->exists();
    }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method check_table3 is not named in camelCase.
                                      Open

                                          private function check_table3() {
        $table = new IcmsDatabasetable('invites');
        return $table->exists();
    }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method check_table4 is not named in camelCase.
                                      Open

                                          private function check_table4() {
        $table = new IcmsDatabasetable('system_customtag');
        return $table->exists();
    }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method apply_conf is not named in camelCase.
                                      Open

                                          private function apply_conf() {
        $db = $GLOBALS['xoopsDB'];
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_CONTMANAGER"') != 0){return true;}
        $db->queryF(" INSERT INTO " . $db->prefix("configcategory") . " (confcat_id, confcat_name) VALUES ('9', '_MD_AM_CONTMANAGER')");
        if (getDbValue($db, 'configcategory', 'confcat_id', ' confcat_name="_MD_AM_PERSON"') != 0){return true;}
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method convert_db is not named in camelCase.
                                      Open

                                          private function convert_db($charset, $collation) {
        $sql = "ALTER DATABASE `" . XOOPS_DB_NAME . "` DEFAULT CHARACTER SET " . $GLOBALS["xoopsDB"]->quote($charset) . " COLLATE " . $GLOBALS["xoopsDB"]->quote($collation);
        if (!$GLOBALS["xoopsDB"]->queryF($sql)) {
            return false;
        }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method check_table1 is not named in camelCase.
                                      Open

                                          private function check_table1() {
        $table = new IcmsDatabasetable('icmspage');
        return $table->exists();
    }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method cleaning_write_folders is not named in camelCase.
                                      Open

                                          private function cleaning_write_folders() {
        $dir = array();
        $dir['templates_c'] = XOOPS_ROOT_PATH . "/templates_c/";
        $dir['cache'] = XOOPS_ROOT_PATH . "/cache/";
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method update_configs is not named in camelCase.
                                      Open

                                          private function update_configs($task) {
        if (!$vars = $this->set_configs($task)) {
            return false;
        }
        if ($task == "db" && !empty($vars["XOOPS_DB_COLLATION"])) {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method check_dbversion is not named in camelCase.
                                      Open

                                          private function check_dbversion() {
        $table = new IcmsDatabasetable('modules');
        return $table->fieldExists('dbversion');
    }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method set_configs is not named in camelCase.
                                      Open

                                          private function set_configs($task) {
        $ret = array();
        $configs = include dirname(__FILE__) . "/settings_{$task}.php";
        if (!$configs || !is_array($configs)) {
            return $ret;
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method apply_customblocks is not named in camelCase.
                                      Open

                                          private function apply_customblocks() {
        $db = $GLOBALS['xoopsDB'];
        $result = $db->queryF("UPDATE ". $db->prefix('newblocks') . " SET mid=0 WHERE mid=1 AND func_num=0");
        return $result;
    }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method check_trust_path is not named in camelCase.
                                      Open

                                          private function check_trust_path() {
        $lines = file(XOOPS_ROOT_PATH . '/mainfile.php');
        foreach ($lines as $line) {
            $trustcheck = defined("XOOPS_TRUST_PATH") && XOOPS_TRUST_PATH != '';
            if (preg_match("/(define\(\s*)([\"'])(XOOPS_TRUST_PATH)\\2,\s*([\"'])([^\"']*?)\\4\s*\);/", $line) && $trustcheck) {
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method write_mainfile is not named in camelCase.
                                      Open

                                          private function write_mainfile($vars) {
        if (empty($vars)) {
            return false;
        }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method apply_trust_path is not named in camelCase.
                                      Open

                                          private function apply_trust_path() {
        return $this->update_configs('trust_path');
    }
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      The method convert_table is not named in camelCase.
                                      Open

                                          private function convert_table($tables, $charset, $collation) {
        // Initialize vars.
        $string_querys = array();
        $binary_querys = array();
        $gen_index_querys = array();
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by phpmd

                                      CamelCaseMethodName

                                      Since: 0.2

                                      It is considered best practice to use the camelCase notation to name methods.

                                      Example

                                      class ClassName {
    public function get_name() {
    }
}

                                      Source

                                      Unexpected trailing spaces found.
                                      Open
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by editorconfig

                                      Unexpected trailing spaces found.
                                      Open
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by editorconfig

                                      Unexpected trailing spaces found.
                                      Open
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by editorconfig

                                      Unexpected trailing spaces found.
                                      Open
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by editorconfig

                                      Unexpected trailing spaces found.
                                      Open
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by editorconfig

                                      Unexpected trailing spaces found.
                                      Open
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by editorconfig

                                      Unexpected trailing spaces found.
                                      Open
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by editorconfig

                                      Unexpected trailing spaces found.
                                      Open
                                      Severity: Minor
                                      Found in upgrade/upd-icms-1.0-to-1.1/index.php by editorconfig

                                      There are no issues that match your filters.

                                      Category
                                      Status