Sign upLogin

InVisionApp/go-health

View on GitHub
Star
checkers/redis/redis.go

Summary

Maintainability
A
35 mins
Test Coverage

Function validateRedisConfig has 7 return statements (exceeds 4 allowed).
Wontfix

func validateRedisConfig(cfg *RedisConfig) error {
    if cfg == nil {
        return fmt.Errorf("Main config cannot be nil")
    }
Severity: Major
Found in checkers/redis/redis.go - About 45 mins to fix

    Method Redis.Status has 6 return statements (exceeds 4 allowed).
    Wontfix

    func (r *Redis) Status() (interface{}, error) {
    if r.Config.Ping {
        if _, err := r.client.Ping().Result(); err != nil {
            return nil, fmt.Errorf("Ping failed: %v", err)
        }
    Severity: Major
    Found in checkers/redis/redis.go - About 40 mins to fix

      Method Redis.Status has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
      Open

      func (r *Redis) Status() (interface{}, error) {
    if r.Config.Ping {
        if _, err := r.client.Ping().Result(); err != nil {
            return nil, fmt.Errorf("Ping failed: %v", err)
        }
      Severity: Minor
      Found in checkers/redis/redis.go - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status