Sign upLogin

InWork/queue_dispatcher

View on GitHub
Star
lib/queue_dispatcher/psych_ext.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method visit_Psych_Nodes_Scalar has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def visit_Psych_Nodes_Scalar(o)
        @st[o.anchor] = o.value if o.anchor

        if klass = Psych.load_tags[o.tag]
          instance = klass.allocate
Severity: Major
Found in lib/queue_dispatcher/psych_ext.rb - About 2 hrs to fix

    Method visit_Psych_Nodes_Scalar has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

          def visit_Psych_Nodes_Scalar(o)
        @st[o.anchor] = o.value if o.anchor

        if klass = Psych.load_tags[o.tag]
          instance = klass.allocate
    Severity: Minor
    Found in lib/queue_dispatcher/psych_ext.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method visit_Psych_Nodes_Mapping_with_class has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def visit_Psych_Nodes_Mapping_with_class(object)
        return revive(Psych.load_tags[object.tag], object) if Psych.load_tags[object.tag]

        case object.tag
        when /^!ruby\/ActiveRecord:(.+)$/
    Severity: Minor
    Found in lib/queue_dispatcher/psych_ext.rb - About 1 hr to fix

      Method visit_Psych_Nodes_Mapping_with_class has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

            def visit_Psych_Nodes_Mapping_with_class(object)
        return revive(Psych.load_tags[object.tag], object) if Psych.load_tags[object.tag]

        case object.tag
        when /^!ruby\/ActiveRecord:(.+)$/
      Severity: Minor
      Found in lib/queue_dispatcher/psych_ext.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status