Infanatica/InfanaticaCepModule

View on GitHub
src/InfanaticaCepModule/Adapter/CorreioControlAdapter.php

Summary

Maintainability
A
35 mins
Test Coverage

Function parseResponse has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected function parseResponse($response)
    {
        if(!$this->isJson($response))
        {
            throw new CepNotFoundException();
Severity: Minor
Found in src/InfanaticaCepModule/Adapter/CorreioControlAdapter.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The method parseResponse() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
Open

    protected function parseResponse($response)
    {
        if(!$this->isJson($response))
        {
            throw new CepNotFoundException();

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Expected 1 space between comma and type hint "EnderecoResponse"; 0 found
Open

    public function __construct(Client $httpClient,EnderecoResponse $enderecoResponse)

Opening brace of a class must be on the line after the definition
Open

class CorreioControlAdapter implements CepAdapterInterface {

There must be one blank line after the namespace declaration
Open

namespace InfanaticaCepModule\Adapter;

Expected 0 spaces before opening parenthesis; 1 found
Open

    protected function isJson ($string)

Expected "function abc(...)"; found "function abc (...)"
Open

    protected function isJson ($string)

End of line character is invalid; expected "\n" but found "\r\n"
Open

<?php

No space found after comma in function call
Open

        $response = json_decode($response,true);

Expected 1 space after IF keyword; 0 found
Open

        if(isset($response['bairro']) && !empty($response['bairro']))

Expected 1 space after closing parenthesis; found 10
Open

        if(isset($response['bairro']) && !empty($response['bairro']))

Expected 1 space after IF keyword; 0 found
Open

        if(isset($response['localidade']) && !empty($response['localidade']))

Expected 1 newline at end of file; 0 found
Open

}

Expected 1 space after closing parenthesis; found 10
Open

        if(isset($response['localidade']) && !empty($response['localidade']))

Expected 1 space after closing parenthesis; found 10
Open

        if(isset($response['uf']) && !empty($response['uf']))

Expected 1 space after closing parenthesis; found 10
Open

        if(isset($response['logradouro']) && !empty($response['logradouro']))

Expected 1 space after IF keyword; 0 found
Open

        if(isset($response['uf']) && !empty($response['uf']))

Expected 1 space after IF keyword; 0 found
Open

        if(isset($response['logradouro']) && !empty($response['logradouro']))

Expected 1 space after closing parenthesis; found 10
Open

        if(!$this->isJson($response))

Expected 1 space after IF keyword; 0 found
Open

        if(!$this->isJson($response))

There are no issues that match your filters.

Category
Status