Sign upLogin

Infanatica/InfanaticaCepModule

View on GitHub
Star
src/InfanaticaCepModule/Adapter/PostmonAdapter.php

Summary

Maintainability
A
1 hr
Test Coverage

Method parseResponse has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function parseResponse($response)
    {
        if(!$this->isJson($response))
        {
            throw new CepNotFoundException();
Severity: Minor
Found in src/InfanaticaCepModule/Adapter/PostmonAdapter.php - About 1 hr to fix

    Function parseResponse has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function parseResponse($response)
    {
        if(!$this->isJson($response))
        {
            throw new CepNotFoundException();
    Severity: Minor
    Found in src/InfanaticaCepModule/Adapter/PostmonAdapter.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method parseResponse() has an NPath complexity of 324. The configured NPath complexity threshold is 200.
    Open

        protected function parseResponse($response)
    {
        if(!$this->isJson($response))
        {
            throw new CepNotFoundException();
    Severity: Minor
    Found in src/InfanaticaCepModule/Adapter/PostmonAdapter.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
    function bar() {
        // lots of complicated code
    }
}

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method parseResponse() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
    Open

        protected function parseResponse($response)
    {
        if(!$this->isJson($response))
        {
            throw new CepNotFoundException();
    Severity: Minor
    Found in src/InfanaticaCepModule/Adapter/PostmonAdapter.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Expected 0 spaces before opening parenthesis; 1 found
    Open

        protected function isJson ($string)
    Severity: Minor
    Found in src/InfanaticaCepModule/Adapter/PostmonAdapter.php by phpcodesniffer

    Expected 1 space between comma and type hint "EnderecoResponse"; 0 found
    Open

        public function __construct(Client $httpClient,EnderecoResponse $enderecoResponse)
    Severity: Minor
    Found in src/InfanaticaCepModule/Adapter/PostmonAdapter.php by phpcodesniffer

    There must be one blank line after the namespace declaration
    Open

    namespace InfanaticaCepModule\Adapter;
    Severity: Minor
    Found in src/InfanaticaCepModule/Adapter/PostmonAdapter.php by phpcodesniffer

    Opening brace of a class must be on the line after the definition
    Open

    class PostmonAdapter implements CepAdapterInterface {
    Severity: Minor
    Found in src/InfanaticaCepModule/Adapter/PostmonAdapter.php by phpcodesniffer

    Expected "function abc(...)"; found "function abc (...)"
    Open

        protected function isJson ($string)
    Severity: Minor
    Found in src/InfanaticaCepModule/Adapter/PostmonAdapter.php by phpcodesniffer

    End of line character is invalid; expected "\n" but found "\r\n"
    Open

    <?php
    Severity: Minor
    Found in src/InfanaticaCepModule/Adapter/PostmonAdapter.php by phpcodesniffer

    Expected 1 space after IF keyword; 0 found
    Open

            if(isset($response['cidade']) && !empty($response['cidade']))
    Severity: Minor
    Found in src/InfanaticaCepModule/Adapter/PostmonAdapter.php by phpcodesniffer

    Expected 1 space after closing parenthesis; found 10
    Open

            if(!$this->isJson($response))
    Severity: Minor
    Found in src/InfanaticaCepModule/Adapter/PostmonAdapter.php by phpcodesniffer

    Expected 1 space after IF keyword; 0 found
    Open

            if(!$this->isJson($response))
    Severity: Minor
    Found in src/InfanaticaCepModule/Adapter/PostmonAdapter.php by phpcodesniffer

    Expected 1 space after closing parenthesis; found 10
    Open

            if(isset($response['bairro']) && !empty($response['bairro']))
    Severity: Minor
    Found in src/InfanaticaCepModule/Adapter/PostmonAdapter.php by phpcodesniffer

    Expected 1 space after IF keyword; 0 found
    Open

            if(isset($response['logradouro']) && !empty($response['logradouro']))
    Severity: Minor
    Found in src/InfanaticaCepModule/Adapter/PostmonAdapter.php by phpcodesniffer

    Expected 1 space after closing parenthesis; found 10
    Open

            if(isset($response['logradouro']) && !empty($response['logradouro']))
    Severity: Minor
    Found in src/InfanaticaCepModule/Adapter/PostmonAdapter.php by phpcodesniffer

    No space found after comma in function call
    Open

            $response = json_decode($response,true);
    Severity: Minor
    Found in src/InfanaticaCepModule/Adapter/PostmonAdapter.php by phpcodesniffer

    Expected 1 space after IF keyword; 0 found
    Open

            if(isset($response['estado']) && !empty($response['estado']))
    Severity: Minor
    Found in src/InfanaticaCepModule/Adapter/PostmonAdapter.php by phpcodesniffer

    Expected 1 newline at end of file; 0 found
    Open

    }
    Severity: Minor
    Found in src/InfanaticaCepModule/Adapter/PostmonAdapter.php by phpcodesniffer

    Expected 1 space after IF keyword; 0 found
    Open

            if(isset($response['bairro']) && !empty($response['bairro']))
    Severity: Minor
    Found in src/InfanaticaCepModule/Adapter/PostmonAdapter.php by phpcodesniffer

    Expected 1 space after closing parenthesis; found 10
    Open

            if(isset($response['estado']) && !empty($response['estado']))
    Severity: Minor
    Found in src/InfanaticaCepModule/Adapter/PostmonAdapter.php by phpcodesniffer

    Expected 1 space after closing parenthesis; found 10
    Open

            if(isset($response['cidade']) && !empty($response['cidade']))
    Severity: Minor
    Found in src/InfanaticaCepModule/Adapter/PostmonAdapter.php by phpcodesniffer

    Expected 1 space after closing parenthesis; found 0
    Open

            if (empty($response)){
    Severity: Minor
    Found in src/InfanaticaCepModule/Adapter/PostmonAdapter.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status