Function parseResponse
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
protected function parseResponse($response)
{
if(!$this->isJson($response))
{
throw new CepNotFoundException();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method parseResponse() has an NPath complexity of 810. The configured NPath complexity threshold is 200. Open
protected function parseResponse($response)
{
if(!$this->isJson($response))
{
throw new CepNotFoundException();
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method parseResponse() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10. Open
protected function parseResponse($response)
{
if(!$this->isJson($response))
{
throw new CepNotFoundException();
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Expected 0 spaces before opening parenthesis; 1 found Open
protected function isJson ($string)
- Exclude checks
There must be one blank line after the namespace declaration Open
namespace InfanaticaCepModule\Adapter;
- Exclude checks
Expected "function abc(...)"; found "function abc (...)" Open
protected function isJson ($string)
- Exclude checks
Expected 1 space between comma and type hint "EnderecoResponse"; 0 found Open
public function __construct(Client $httpClient,EnderecoResponse $enderecoResponse)
- Exclude checks
Opening brace of a class must be on the line after the definition Open
class RepublicaVirtualAdapter implements CepAdapterInterface {
- Exclude checks
End of line character is invalid; expected "\n" but found "\r\n" Open
<?php
- Exclude checks
Line exceeds 120 characters; contains 158 characters Open
if(isset($response['logradouro']) && !empty($response['logradouro']) && isset($response['tipo_logradouro']) && !empty($response['tipo_logradouro'])) {
- Exclude checks
Expected 1 space after IF keyword; 0 found Open
if(!$this->isJson($response))
- Exclude checks
Expected 1 space after closing parenthesis; found 0 Open
if (isset($response['resultado']) && $response['resultado'] != 1){
- Exclude checks
Expected 1 newline at end of file; 0 found Open
}
- Exclude checks
Expected 1 space after IF keyword; 0 found Open
if(isset($response['cidade']) && !empty($response['cidade'])) {
- Exclude checks
Expected 1 space after closing parenthesis; found 10 Open
if(!$this->isJson($response))
- Exclude checks
No space found after comma in function call Open
$response = json_decode($response,true);
- Exclude checks
Expected 1 space after IF keyword; 0 found Open
if(isset($response['logradouro']) && !empty($response['logradouro']) && isset($response['tipo_logradouro']) && !empty($response['tipo_logradouro'])) {
- Exclude checks
Expected 1 space after IF keyword; 0 found Open
if(isset($response['uf']) && !empty($response['uf'])) {
- Exclude checks
Expected 1 space after IF keyword; 0 found Open
if(isset($response['bairro']) && !empty($response['bairro'])) {
- Exclude checks