Innovimax-SARL/QuiXDM

View on GitHub
src/main/java/innovimax/quixproc/datamodel/in/xml/XMLQuiXEventStreamReader.java

Summary

Maintainability
C
1 day
Test Coverage

Method process has 81 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public AQuiXEvent process(final CallBack callback) {
        try {
            if (!this.buffer.isEmpty()) {
                return this.buffer.poll();

    Method process has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
        public AQuiXEvent process(final CallBack callback) {
            try {
                if (!this.buffer.isEmpty()) {
                    return this.buffer.poll();

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                        return event;

      Avoid too many return statements within this method.
      Open

                          return event;

        Avoid too many return statements within this method.
        Open

                            return event;

          Avoid too many return statements within this method.
          Open

                              return this.buffer.poll();

            Avoid too many return statements within this method.
            Open

                                return event;

              Identical blocks of code found in 3 locations. Consider refactoring.
              Open

                                  for (int i = 0; i < this.sreader.getAttributeCount(); i++) {
                                      this.buffer.add(AQuiXEvent.getAttribute(
                                              QuiXCharStream.fromSequence(this.sreader.getAttributeLocalName(i)),
                                              QuiXCharStream.fromSequence(this.sreader.getAttributeNamespace(i)),
                                              QuiXCharStream.fromSequence(this.sreader.getAttributePrefix(i)),
              src/main/java/innovimax/quixproc/datamodel/in/xml/QuiXStreamReader.java on lines 132..138
              src/main/java/innovimax/quixproc/datamodel/in/xml/XMLQuiXEventStreamReader.java on lines 83..89

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 84.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 3 locations. Consider refactoring.
              Open

                                  for (int i = 0; i < this.sreader.getAttributeCount(); i++) {
                                      this.buffer.add(AQuiXEvent.getAttribute(
                                              QuiXCharStream.fromSequence(this.sreader.getAttributeLocalName(i)),
                                              QuiXCharStream.fromSequence(this.sreader.getAttributeNamespace(i)),
                                              QuiXCharStream.fromSequence(this.sreader.getAttributePrefix(i)),
              src/main/java/innovimax/quixproc/datamodel/in/xml/QuiXStreamReader.java on lines 132..138
              src/main/java/innovimax/quixproc/datamodel/in/xml/XMLQuiXEventStreamReader.java on lines 106..112

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 84.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                                  for (int i = 0; i < this.sreader.getNamespaceCount(); i++) {
                                      this.buffer.add(
                                              AQuiXEvent.getNamespace(QuiXCharStream.fromSequence(this.sreader.getNamespacePrefix(i)),
                                                      QuiXCharStream.fromSequence(this.sreader.getNamespaceURI(i))));
                                  }
              src/main/java/innovimax/quixproc/datamodel/in/xml/QuiXStreamReader.java on lines 127..131

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 60.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  event = AQuiXEvent.getStartElement(QuiXCharStream.fromSequence(this.sreader.getLocalName()),
                                          QuiXCharStream.fromSequence(this.sreader.getNamespaceURI()),
                                          QuiXCharStream.fromSequence(this.sreader.getPrefix()));
              src/main/java/innovimax/quixproc/datamodel/in/xml/XMLQuiXEventStreamReader.java on lines 99..101

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 40.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  event = AQuiXEvent.getEndElement(QuiXCharStream.fromSequence(this.sreader.getLocalName()),
                                          QuiXCharStream.fromSequence(this.sreader.getNamespaceURI()),
                                          QuiXCharStream.fromSequence(this.sreader.getPrefix()));
              src/main/java/innovimax/quixproc/datamodel/in/xml/XMLQuiXEventStreamReader.java on lines 74..76

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 40.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status