Sign upLogin

IntegerMan/angularIF

View on GitHub
Star
src/app/engine/entities/room.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function allowCommand has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

  allowCommand(command: Command, context: CommandContext): boolean {

    if (context.ifService.isGameOver && (!command.verbHandler || command.verbHandler.verbType !== VerbType.system)) {

      context.outputService.displayParserError(`It's too late for that - the game is already over!`);
Severity: Minor
Found in src/app/engine/entities/room.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function allowCommand has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  allowCommand(command: Command, context: CommandContext): boolean {

    if (context.ifService.isGameOver && (!command.verbHandler || command.verbHandler.verbType !== VerbType.system)) {

      context.outputService.displayParserError(`It's too late for that - the game is already over!`);
Severity: Minor
Found in src/app/engine/entities/room.ts - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                  if (link.target.hasLight(context)) {
                return true;
              }
    Severity: Major
    Found in src/app/engine/entities/room.ts - About 45 mins to fix

      Avoid too many return statements within this function.
      Open

                return false;
      Severity: Major
      Found in src/app/engine/entities/room.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                  return false;
        Severity: Major
        Found in src/app/engine/entities/room.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return true;
          Severity: Major
          Found in src/app/engine/entities/room.ts - About 30 mins to fix

            Function addItemsFromContainer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              private addItemsFromContainer(container: WorldEntity, token: CommandToken, context: CommandContext): WorldEntity[] {

    const results: WorldEntity[] = [];

    for (const entity of container.getContainedEntities(context, false)) {
            Severity: Minor
            Found in src/app/engine/entities/room.ts - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status