Sign upLogin

Invis1ble/assistant

View on GitHub
Star

Showing 56 of 56 total issues

ApiTestCase has 30 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class ApiTestCase extends WebTestCase
{
    /**
     * @var Client
     */
Severity: Minor
Found in tests/AppBundle/Controller/ApiTestCase.php - About 3 hrs to fix

The class ApiTestCase has 19 public methods. Consider refactoring ApiTestCase to keep number of public methods under 10.
Open

abstract class ApiTestCase extends WebTestCase
{
    /**
     * @var Client
     */
Severity: Minor
Found in tests/AppBundle/Controller/ApiTestCase.php by phpmd

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function postPeriodAction(Request $request, Task $task)
    {
        $periodManager = $this->get('app.manager.period_manager');
        $period = $periodManager->createPeriod();
        $period->setTask($task);
Severity: Major
Found in src/AppBundle/Controller/TaskPeriodController.php and 2 other locations - About 2 hrs to fix
src/AppBundle/Controller/CategoryTaskController.php on lines 133..151
src/AppBundle/Controller/UserCategoryController.php on lines 114..132

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function postCategoryAction(Request $request, User $fetchedUser)
    {
        $categoryManager = $this->get('app.manager.category_manager');
        $category = $categoryManager->createCategory();
        $category->setUser($fetchedUser);
Severity: Major
Found in src/AppBundle/Controller/UserCategoryController.php and 2 other locations - About 2 hrs to fix
src/AppBundle/Controller/CategoryTaskController.php on lines 133..151
src/AppBundle/Controller/TaskPeriodController.php on lines 113..131

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function postTaskAction(Request $request, Category $category)
    {
        $taskManager = $this->get('app.manager.task_manager');
        $task = $taskManager->createTask();
        $task->setCategory($category);
Severity: Major
Found in src/AppBundle/Controller/CategoryTaskController.php and 2 other locations - About 2 hrs to fix
src/AppBundle/Controller/TaskPeriodController.php on lines 113..131
src/AppBundle/Controller/UserCategoryController.php on lines 114..132

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
 
namespace AppBundle\Manager;
 
use AppBundle\Entity\Category;
Severity: Major
Found in src/AppBundle/Manager/CategoryManager.php and 1 other location - About 2 hrs to fix
src/AppBundle/Manager/TaskManager.php on lines 1..57

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
 
namespace AppBundle\Manager;
 
use AppBundle\Entity\Task;
Severity: Major
Found in src/AppBundle/Manager/TaskManager.php and 1 other location - About 2 hrs to fix
src/AppBundle/Manager/CategoryManager.php on lines 1..57

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function patchCategoryAction(Request $request, Category $category)
    {
        $form = $this->createForm(UserCategoryFormType::class, $category);
        $form->submit(json_decode($request->getContent(), true), false);
 
 
Severity: Major
Found in src/AppBundle/Controller/CategoryController.php and 1 other location - About 2 hrs to fix
src/AppBundle/Controller/PeriodController.php on lines 109..123

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function patchPeriodAction(Request $request, Period $period)
    {
        $form = $this->createForm(TaskPeriodFormType::class, $period);
        $form->submit(json_decode($request->getContent(), true), false);
 
 
Severity: Major
Found in src/AppBundle/Controller/PeriodController.php and 1 other location - About 2 hrs to fix
src/AppBundle/Controller/CategoryController.php on lines 109..123

Avoid excessively long variable names like $task2Period1FinishedAt. Keep variable name length under 20.
Open

        $task2Period1FinishedAt = new DateTime('@' . ($nowTimestamp - 1));
Severity: Minor
Found in tests/AppBundle/DataFixtures/Faker/Provider/PeriodProviderTest.php by phpmd

Method testGetTasks has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testGetTasks()
    {
        $uuid4 = $this->getUUID4stub();
 
        $alice = $this->getUser('alice');
Severity: Minor
Found in tests/AppBundle/Controller/CategoryTaskControllerTest.php - About 1 hr to fix

Method testPatchTask has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testPatchTask()
    {
        $uuid4 = $this->getUUID4stub();
 
        $alice = $this->getUser('alice');
Severity: Minor
Found in tests/AppBundle/Controller/TaskControllerTest.php - About 1 hr to fix

Method testPatchPeriod has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testPatchPeriod()
    {
        $uuid4 = $this->getUUID4stub();
 
        $alice = $this->getUser('alice');
Severity: Minor
Found in tests/AppBundle/Controller/PeriodControllerTest.php - About 1 hr to fix

Method buildForm has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        if (!$options['user'] instanceof User) {
            throw new RuntimeException('User is not defined');
        }
Severity: Minor
Found in src/AppBundle/Form/Type/TaskFormType.php - About 1 hr to fix

Method testPatchCategory has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testPatchCategory()
    {
        $uuid4 = $this->getUUID4stub();
 
        $alice = $this->getUser('alice');
Severity: Minor
Found in tests/AppBundle/Controller/CategoryControllerTest.php - About 1 hr to fix

Method validate has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function validate($period, Constraint $constraint)
    {
        if (!$constraint instanceof PeriodIsCoherent) {
            throw new UnexpectedTypeException($constraint, PeriodIsCoherent::class);
        }
Severity: Minor
Found in src/AppBundle/Validator/Constraints/PeriodIsCoherentValidator.php - About 1 hr to fix

Method request has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

        string $method,
        string $uri,
        array $parameters = [],
        array $files = [],
        array $server = [],
Severity: Major
Found in tests/AppBundle/Controller/ApiTestCase.php - About 1 hr to fix

Method testPostTask has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testPostTask()
    {
        $uuid4 = $this->getUUID4stub();
 
        $alice = $this->getUser('alice');
Severity: Minor
Found in tests/AppBundle/Controller/CategoryTaskControllerTest.php - About 1 hr to fix

Method voteOnAttribute has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function voteOnAttribute($attribute, $task, TokenInterface $token)
    {
        $user = $token->getUser();
 
        if (!$user instanceof UserInterface) {
Severity: Minor
Found in src/AppBundle/Security/Authorization/Voter/TaskVoter.php - About 1 hr to fix

Method testPostPeriod has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testPostPeriod()
    {
        $uuid4 = $this->getUUID4stub();
 
        $alice = $this->getUser('alice');
Severity: Minor
Found in tests/AppBundle/Controller/TaskPeriodControllerTest.php - About 1 hr to fix
Severity
Category
Status
Source
Language