Sign upLogin

IotaSpencer/cloud_party

View on GitHub
Star
lib/cloud_party/config.rb

Summary

Maintainability
A
1 hr
Test Coverage

Assignment Branch Condition size for initialize is too high. [26.38/23]
Open

    def initialize
      cp_config = AppConfiguration.new('config') do
        base_local_path Pathname.new(Dir.home).join('.cloud_party/')
        base_global_path Pathname.new(Etc.sysconfdir).join('cloud_party')
        use_env_variables true
Severity: Minor
Found in lib/cloud_party/config.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Similar blocks of code found in 2 locations. Consider refactoring.
Open

module CloudParty
  class Config
    def initialize
      cp_config = AppConfiguration.new('config') do
        base_local_path Pathname.new(Dir.home).join('.cloud_party/')
Severity: Major
Found in lib/cloud_party/config.rb and 1 other location - About 1 hr to fix
lib/cloud_party/simple.rb on lines 4..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Use attr_reader to define trivial reader methods.
Open

    def api_key
Severity: Minor
Found in lib/cloud_party/config.rb by rubocop

This cop looks for trivial reader/writer methods, that could have been created with the attr_* family of functions automatically.

Example:

# bad
def foo
  @foo
end

def bar=(val)
  @bar = val
end

def self.baz
  @baz
end

# good
attr_reader :foo
attr_writer :bar

class << self
  attr_reader :baz
end

Use attr_reader to define trivial reader methods.
Open

    def email
Severity: Minor
Found in lib/cloud_party/config.rb by rubocop

This cop looks for trivial reader/writer methods, that could have been created with the attr_* family of functions automatically.

Example:

# bad
def foo
  @foo
end

def bar=(val)
  @bar = val
end

def self.baz
  @baz
end

# good
attr_reader :foo
attr_writer :bar

class << self
  attr_reader :baz
end

There are no issues that match your filters.

Category
Status