Sign upLogin

JABirchall/NimdaTS3

View on GitHub
Star
app/TeamSpeak3Bot.php

Summary

Maintainability
F
3 days
Test Coverage

Function onMessage has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

    public function onMessage(Event $event)
    {
        $data = $event->getData();
        $mode = $this->parseMessageMode(@$data['targetmode']);
        if (@$data['invokername'] == $this->name || @$data['invokeruid'] == 'serveradmin') {
Severity: Minor
Found in app/TeamSpeak3Bot.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File TeamSpeak3Bot.php has 384 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Created by PhpStorm.
 * User: Admin
 * Date: 25/07/2016
Severity: Minor
Found in app/TeamSpeak3Bot.php - About 5 hrs to fix

    TeamSpeak3Bot has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class TeamSpeak3Bot
{
    /**
     * @var string
     */
    Severity: Minor
    Found in app/TeamSpeak3Bot.php - About 2 hrs to fix

      Function loadPlugin has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          private function loadPlugin($configFile)
    {
        $config = $this->parseConfigFile($configFile);
        $config['configFile'] = $configFile;
      Severity: Minor
      Found in app/TeamSpeak3Bot.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function onEvent has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          public function onEvent(Event $event)
    {
        $data = $event->getData();
        if (@$data['client_type'] == 1) {
            return;
      Severity: Minor
      Found in app/TeamSpeak3Bot.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method loadPlugin has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function loadPlugin($configFile)
    {
        $config = $this->parseConfigFile($configFile);
        $config['configFile'] = $configFile;
      Severity: Minor
      Found in app/TeamSpeak3Bot.php - About 1 hr to fix

        Method onMessage has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function onMessage(Event $event)
    {
        $data = $event->getData();
        $mode = $this->parseMessageMode(@$data['targetmode']);
        if (@$data['invokername'] == $this->name || @$data['invokeruid'] == 'serveradmin') {
        Severity: Minor
        Found in app/TeamSpeak3Bot.php - About 1 hr to fix

          Method __construct has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function __construct($username, $password, $host = '127.0.0.1', $port = 10011, $name = 'Nimda', $serverPort = 9987, $timeout = 10)
    {
        $this->carbon = new Carbon;

       if (strtoupper(substr(PHP_OS, 0, 3)) !== 'WIN' && posix_getuid() === 0 && !Self::$config['ignoreWarnings']) {
          Severity: Minor
          Found in app/TeamSpeak3Bot.php - About 1 hr to fix

            Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function __construct($username, $password, $host = '127.0.0.1', $port = 10011, $name = 'Nimda', $serverPort = 9987, $timeout = 10)
            Severity: Major
            Found in app/TeamSpeak3Bot.php - About 50 mins to fix

              Function __construct has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function __construct($username, $password, $host = '127.0.0.1', $port = 10011, $name = 'Nimda', $serverPort = 9987, $timeout = 10)
    {
        $this->carbon = new Carbon;

       if (strtoupper(substr(PHP_OS, 0, 3)) !== 'WIN' && posix_getuid() === 0 && !Self::$config['ignoreWarnings']) {
              Severity: Minor
              Found in app/TeamSpeak3Bot.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                      return true;
              Severity: Major
              Found in app/TeamSpeak3Bot.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return true;
                Severity: Major
                Found in app/TeamSpeak3Bot.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return false;
                  Severity: Major
                  Found in app/TeamSpeak3Bot.php - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if (!class_exists($config['class'])) {
            $this->printOutput("Loading failed because class {$config['class']} doesn't exist.");

            return false;
        } elseif (!is_a($config['class'], \Plugin\PluginContract::class, true)) {
                    Severity: Minor
                    Found in app/TeamSpeak3Bot.php and 1 other location - About 40 mins to fix
                    app/TeamSpeak3Bot.php on lines 419..427

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 93.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if (!class_exists($config['class'])) {
            $this->printOutput("Loading failed because class {$config['class']} doesn't exist.");

            return false;
        } elseif (!is_a($config['class'], \Timer\TimerContract::class, true)) {
                    Severity: Minor
                    Found in app/TeamSpeak3Bot.php and 1 other location - About 40 mins to fix
                    app/TeamSpeak3Bot.php on lines 365..373

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 93.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status