Sign upLogin

JASMINE-Mission/jasmine-imagesim

View on GitHub
Star
src/jis/photonsim/ace.py

Summary

Maintainability
A
2 hrs
Test Coverage
F
0%

Cyclomatic complexity is too high in function calc_ace. (7)
Open

def calc_ace(rg, N, T, ace):
    """    
    The ACE is assumed to have a power spectral distribution (PSD) 
    which consists of a white noise spectrum in low frequencies,
    a power-law function in high frequencies (index=-2),
Severity: Minor
Found in src/jis/photonsim/ace.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function calc_ace has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

def calc_ace(rg, N, T, ace):
    """    
    The ACE is assumed to have a power spectral distribution (PSD) 
    which consists of a white noise spectrum in low frequencies,
    a power-law function in high frequencies (index=-2),
Severity: Minor
Found in src/jis/photonsim/ace.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ace2d has 7 arguments (exceeds 5 allowed). Consider refactoring.
Open

def ace2d(x_scale, y_scale, pix_scale, N, xdata, ydata, xN):
Severity: Major
Found in src/jis/photonsim/ace.py - About 45 mins to fix

    Trailing whitespace
    Open

        a power-law function in high frequencies (index=-2),
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Trailing whitespace is superfluous.

    The warning returned varies on whether the line itself is blank,
for easier filtering for those who want to indent their blank lines.

Okay: spam(1)\n#
W291: spam(1) \n#
W293: class Foo(object):\n    \n    bang = 12

    At least two spaces before inline comment
    Open

                P = np.empty(nmax) # Power
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Separate inline comments by at least two spaces.

    An inline comment is a comment on the same line as a statement.
Inline comments should be separated by at least two spaces from the
statement. They should start with a # and a single space.

Each line of a block comment starts with a # and a single space
(unless it is indented text inside the comment).

Okay: x = x + 1  # Increment x
Okay: x = x + 1    # Increment x
Okay: # Block comment
E261: x = x + 1 # Increment x
E262: x = x + 1  #Increment x
E262: x = x + 1  #  Increment x
E265: #Block comment
E266: ### Block comment

    Missing whitespace around modulo operator
    Open

            if N%2 == 0:
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Surround operators with a single space on either side.

    - Always surround these binary operators with a single space on
  either side: assignment (=), augmented assignment (+=, -= etc.),
  comparisons (==, <, >, !=, <=, >=, in, not in, is, is not),
  Booleans (and, or, not).

- If operators with different priorities are used, consider adding
  whitespace around the operators with the lowest priorities.

Okay: i = i + 1
Okay: submitted += 1
Okay: x = x * 2 - 1
Okay: hypot2 = x * x + y * y
Okay: c = (a + b) * (a - b)
Okay: foo(bar, key='word', *args, **kwargs)
Okay: alpha[:-i]

E225: i=i+1
E225: submitted +=1
E225: x = x /2 - 1
E225: z = x **y
E225: z = 1and 1
E226: c = (a+b) * (a-b)
E226: hypot2 = x*x + y*y
E227: c = a|b
E228: msg = fmt%(errno, errmsg)

    Whitespace before ')'
    Open

            mean    = np.mean( ft.real )
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Avoid extraneous whitespace.

    Avoid extraneous whitespace in these situations:
- Immediately inside parentheses, brackets or braces.
- Immediately before a comma, semicolon, or colon.

Okay: spam(ham[1], {eggs: 2})
E201: spam( ham[1], {eggs: 2})
E201: spam(ham[ 1], {eggs: 2})
E201: spam(ham[1], { eggs: 2})
E202: spam(ham[1], {eggs: 2} )
E202: spam(ham[1 ], {eggs: 2})
E202: spam(ham[1], {eggs: 2 })

E203: if x == 4: print x, y; x, y = y , x
E203: if x == 4: print x, y ; x, y = y, x
E203: if x == 4 : print x, y; x, y = y, x

    Missing whitespace after ','
    Open

        ax1 = fig.add_subplot(2,1,1)
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Each comma, semicolon or colon should be followed by whitespace.

    Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

    Missing whitespace after ','
    Open

        ax1.text(dT*20,3.0,"Sigma={:.2f}".format(sig))
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Each comma, semicolon or colon should be followed by whitespace.

    Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

    Missing whitespace after ','
    Open

        ax1.set_ylim(bottom=-4,top=4)
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Each comma, semicolon or colon should be followed by whitespace.

    Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

    Whitespace before ')'
    Open

            xi = math.floor(x + 0.5 + N/2 )
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Avoid extraneous whitespace.

    Avoid extraneous whitespace in these situations:
- Immediately inside parentheses, brackets or braces.
- Immediately before a comma, semicolon, or colon.

Okay: spam(ham[1], {eggs: 2})
E201: spam( ham[1], {eggs: 2})
E201: spam(ham[ 1], {eggs: 2})
E201: spam(ham[1], { eggs: 2})
E202: spam(ham[1], {eggs: 2} )
E202: spam(ham[1 ], {eggs: 2})
E202: spam(ham[1], {eggs: 2 })

E203: if x == 4: print x, y; x, y = y , x
E203: if x == 4: print x, y ; x, y = y, x
E203: if x == 4 : print x, y; x, y = y, x

    Missing whitespace after ','
    Open

            data[yi,xi] = data[yi,xi] + 1
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Each comma, semicolon or colon should be followed by whitespace.

    Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

    At least two spaces before inline comment
    Open

            bet  = ace['bet'] # Factor which determines the amplitude dependence of the gaussian amplitude noise.
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Separate inline comments by at least two spaces.

    An inline comment is a comment on the same line as a statement.
Inline comments should be separated by at least two spaces from the
statement. They should start with a # and a single space.

Each line of a block comment starts with a # and a single space
(unless it is indented text inside the comment).

Okay: x = x + 1  # Increment x
Okay: x = x + 1    # Increment x
Okay: # Block comment
E261: x = x + 1 # Increment x
E262: x = x + 1  #Increment x
E262: x = x + 1  #  Increment x
E265: #Block comment
E266: ### Block comment

    At least two spaces before inline comment
    Open

            std     = np.std( ft.real, ddof=1) # sqrt( SUM((x-<x>)**2)/(N-1) )
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Separate inline comments by at least two spaces.

    An inline comment is a comment on the same line as a statement.
Inline comments should be separated by at least two spaces from the
statement. They should start with a # and a single space.

Each line of a block comment starts with a # and a single space
(unless it is indented text inside the comment).

Okay: x = x + 1  # Increment x
Okay: x = x + 1    # Increment x
Okay: # Block comment
E261: x = x + 1 # Increment x
E262: x = x + 1  #Increment x
E262: x = x + 1  #  Increment x
E265: #Block comment
E266: ### Block comment

    Whitespace after '('
    Open

            acedata = ( ft.real - mean ) / std # Centering and normalizing with std.
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Avoid extraneous whitespace.

    Avoid extraneous whitespace in these situations:
- Immediately inside parentheses, brackets or braces.
- Immediately before a comma, semicolon, or colon.

Okay: spam(ham[1], {eggs: 2})
E201: spam( ham[1], {eggs: 2})
E201: spam(ham[ 1], {eggs: 2})
E201: spam(ham[1], { eggs: 2})
E202: spam(ham[1], {eggs: 2} )
E202: spam(ham[1 ], {eggs: 2})
E202: spam(ham[1], {eggs: 2 })

E203: if x == 4: print x, y; x, y = y , x
E203: if x == 4: print x, y ; x, y = y, x
E203: if x == 4 : print x, y; x, y = y, x

    Missing whitespace after ','
    Open

        ax1.text(dT*20,3.0,"Sigma={:.2f}".format(sig))
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Each comma, semicolon or colon should be followed by whitespace.

    Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

    Line too long (119 > 79 characters)
    Open

            f0   = ace['f0']  # Boundary frequency between low-freq white noise region and high-freq pow-law region in PSD.
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    Missing whitespace after ','
    Open

        ax2 = fig.add_subplot(2,1,2)
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Each comma, semicolon or colon should be followed by whitespace.

    Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

    Line too long (89 > 79 characters)
    Open

            acedata (ndarray): Time-series data of the calculated ace normalized with stddev.
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    Line too long (109 > 79 characters)
    Open

            bet  = ace['bet'] # Factor which determines the amplitude dependence of the gaussian amplitude noise.
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    Line too long (80 > 79 characters)
    Open

                                               # PSD of the result (not normalized).
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    The backslash is redundant between brackets
    Open

        p2  = ax2.plot(FR,psdn[0:int(N/2+1)], marker='o',\
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Avoid explicit line join between brackets.

    The preferred way of wrapping long lines is by using Python's
implied line continuation inside parentheses, brackets and braces.
Long lines can be broken over multiple lines by wrapping expressions
in parentheses.  These should be used in preference to using a
backslash for line continuation.

E502: aaa = [123, \\n       123]
E502: aaa = ("bbb " \\n       "ccc")

Okay: aaa = [123,\n       123]
Okay: aaa = ("bbb "\n       "ccc")
Okay: aaa = "bbb " \\n    "ccc"
Okay: aaa = 123  # \\

    At least two spaces before inline comment
    Open

        dT = T/N # Time step.
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Separate inline comments by at least two spaces.

    An inline comment is a comment on the same line as a statement.
Inline comments should be separated by at least two spaces from the
statement. They should start with a # and a single space.

Each line of a block comment starts with a # and a single space
(unless it is indented text inside the comment).

Okay: x = x + 1  # Increment x
Okay: x = x + 1    # Increment x
Okay: # Block comment
E261: x = x + 1 # Increment x
E262: x = x + 1  #Increment x
E262: x = x + 1  #  Increment x
E265: #Block comment
E266: ### Block comment

    At least two spaces before inline comment
    Open

                H = np.empty(nmax) # Half-width half-maximum
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Separate inline comments by at least two spaces.

    An inline comment is a comment on the same line as a statement.
Inline comments should be separated by at least two spaces from the
statement. They should start with a # and a single space.

Each line of a block comment starts with a # and a single space
(unless it is indented text inside the comment).

Okay: x = x + 1  # Increment x
Okay: x = x + 1    # Increment x
Okay: # Block comment
E261: x = x + 1 # Increment x
E262: x = x + 1  #Increment x
E262: x = x + 1  #  Increment x
E265: #Block comment
E266: ### Block comment

    Missing whitespace after ','
    Open

        fig.savefig(plotfile,transparent=True)
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Each comma, semicolon or colon should be followed by whitespace.

    Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

    Missing whitespace after ','
    Open

        data = np.zeros( (N,N) , dtype=int)
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Each comma, semicolon or colon should be followed by whitespace.

    Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

    Line too long (83 > 79 characters)
    Open

            psdn    (ndarray): Calculated PSD data (Not normalized; just for checking).
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    Line too long (84 > 79 characters)
    Open

            sig   = s0**bet              # Sigma of the gaussian noise in the next line.
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    Whitespace after '('
    Open

        data = np.zeros( (N,N) , dtype=int)
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Avoid extraneous whitespace.

    Avoid extraneous whitespace in these situations:
- Immediately inside parentheses, brackets or braces.
- Immediately before a comma, semicolon, or colon.

Okay: spam(ham[1], {eggs: 2})
E201: spam( ham[1], {eggs: 2})
E201: spam(ham[ 1], {eggs: 2})
E201: spam(ham[1], { eggs: 2})
E202: spam(ham[1], {eggs: 2} )
E202: spam(ham[1 ], {eggs: 2})
E202: spam(ham[1], {eggs: 2 })

E203: if x == 4: print x, y; x, y = y , x
E203: if x == 4: print x, y ; x, y = y, x
E203: if x == 4 : print x, y; x, y = y, x

    Line too long (85 > 79 characters)
    Open

        This function generates a one-dimensional dummy attitue control error (ACE) data.
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    Missing whitespace after ','
    Open

                       markersize=1,linestyle='None')
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Each comma, semicolon or colon should be followed by whitespace.

    Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

    Whitespace before ','
    Open

        data = np.zeros( (N,N) , dtype=int)
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Avoid extraneous whitespace.

    Avoid extraneous whitespace in these situations:
- Immediately inside parentheses, brackets or braces.
- Immediately before a comma, semicolon, or colon.

Okay: spam(ham[1], {eggs: 2})
E201: spam( ham[1], {eggs: 2})
E201: spam(ham[ 1], {eggs: 2})
E201: spam(ham[1], { eggs: 2})
E202: spam(ham[1], {eggs: 2} )
E202: spam(ham[1 ], {eggs: 2})
E202: spam(ham[1], {eggs: 2 })

E203: if x == 4: print x, y; x, y = y , x
E203: if x == 4: print x, y ; x, y = y, x
E203: if x == 4 : print x, y; x, y = y, x

    Line too long (87 > 79 characters)
    Open

        The returned ACE data (acedata) is normalized with the resulted standard deviation.
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    Multiple spaces after operator
    Open

            data.real[tt] =  data.real[t+1]
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Avoid extraneous whitespace around an operator.

    Okay: a = 12 + 3
E221: a = 4  + 5
E222: a = 4 +  5
E223: a = 4\t+ 5
E224: a = 4 +\t5

    Line too long (80 > 79 characters)
    Open

            acedata = ( ft.real - mean ) / std # Centering and normalizing with std.
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    At least two spaces before inline comment
    Open

            acedata = ( ft.real - mean ) / std # Centering and normalizing with std.
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Separate inline comments by at least two spaces.

    An inline comment is a comment on the same line as a statement.
Inline comments should be separated by at least two spaces from the
statement. They should start with a # and a single space.

Each line of a block comment starts with a # and a single space
(unless it is indented text inside the comment).

Okay: x = x + 1  # Increment x
Okay: x = x + 1    # Increment x
Okay: # Block comment
E261: x = x + 1 # Increment x
E262: x = x + 1  #Increment x
E262: x = x + 1  #  Increment x
E265: #Block comment
E266: ### Block comment

    Line too long (97 > 79 characters)
    Open

            alp  = ace['alp'] # Factor which determines the fraction of the gaussian amplitude noise.
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    At least two spaces before inline comment
    Open

        dT  = T/N # time step
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Separate inline comments by at least two spaces.

    An inline comment is a comment on the same line as a statement.
Inline comments should be separated by at least two spaces from the
statement. They should start with a # and a single space.

Each line of a block comment starts with a # and a single space
(unless it is indented text inside the comment).

Okay: x = x + 1  # Increment x
Okay: x = x + 1    # Increment x
Okay: # Block comment
E261: x = x + 1 # Increment x
E262: x = x + 1  #Increment x
E262: x = x + 1  #  Increment x
E265: #Block comment
E266: ### Block comment

    Line too long (90 > 79 characters)
    Open

        The generated PSD is also returned as 'psdn', but this is not normalized as 'acedata'.
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    At least two spaces before inline comment
    Open

            alp  = ace['alp'] # Factor which determines the fraction of the gaussian amplitude noise.
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Separate inline comments by at least two spaces.

    An inline comment is a comment on the same line as a statement.
Inline comments should be separated by at least two spaces from the
statement. They should start with a # and a single space.

Each line of a block comment starts with a # and a single space
(unless it is indented text inside the comment).

Okay: x = x + 1  # Increment x
Okay: x = x + 1    # Increment x
Okay: # Block comment
E261: x = x + 1 # Increment x
E262: x = x + 1  #Increment x
E262: x = x + 1  #  Increment x
E265: #Block comment
E266: ### Block comment

    At least two spaces before inline comment
    Open

                F = np.empty(nmax) # Frequency
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Separate inline comments by at least two spaces.

    An inline comment is a comment on the same line as a statement.
Inline comments should be separated by at least two spaces from the
statement. They should start with a # and a single space.

Each line of a block comment starts with a # and a single space
(unless it is indented text inside the comment).

Okay: x = x + 1  # Increment x
Okay: x = x + 1    # Increment x
Okay: # Block comment
E261: x = x + 1 # Increment x
E262: x = x + 1  #Increment x
E262: x = x + 1  #  Increment x
E265: #Block comment
E266: ### Block comment

    Line too long (80 > 79 characters)
    Open

            dummyace (ndarray): A dummy ACE, zero-padded array with the size of `N`.
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    Whitespace before ')'
    Open

            yi = math.floor(y + 0.5 + N/2 )
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Avoid extraneous whitespace.

    Avoid extraneous whitespace in these situations:
- Immediately inside parentheses, brackets or braces.
- Immediately before a comma, semicolon, or colon.

Okay: spam(ham[1], {eggs: 2})
E201: spam( ham[1], {eggs: 2})
E201: spam(ham[ 1], {eggs: 2})
E201: spam(ham[1], { eggs: 2})
E202: spam(ham[1], {eggs: 2} )
E202: spam(ham[1 ], {eggs: 2})
E202: spam(ham[1], {eggs: 2 })

E203: if x == 4: print x, y; x, y = y , x
E203: if x == 4: print x, y ; x, y = y, x
E203: if x == 4 : print x, y; x, y = y, x

    Indentation is not a multiple of 4 (comment)
    Open

                                               # PSD of the result (not normalized).
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Use indent_size (PEP8 says 4) spaces per indentation level.

    For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

    Trailing whitespace
    Open

        """
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Trailing whitespace is superfluous.

    The warning returned varies on whether the line itself is blank,
for easier filtering for those who want to indent their blank lines.

Okay: spam(1)\n#
W291: spam(1) \n#
W293: class Foo(object):\n    \n    bang = 12

    Trailing whitespace
    Open

        The ACE is assumed to have a power spectral distribution (PSD)
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Trailing whitespace is superfluous.

    The warning returned varies on whether the line itself is blank,
for easier filtering for those who want to indent their blank lines.

Okay: spam(1)\n#
W291: spam(1) \n#
W293: class Foo(object):\n    \n    bang = 12

    At least two spaces before inline comment
    Open

            noise = rg.normal(scale=sig) # Gaussian noise.
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Separate inline comments by at least two spaces.

    An inline comment is a comment on the same line as a statement.
Inline comments should be separated by at least two spaces from the
statement. They should start with a # and a single space.

Each line of a block comment starts with a # and a single space
(unless it is indented text inside the comment).

Okay: x = x + 1  # Increment x
Okay: x = x + 1    # Increment x
Okay: # Block comment
E261: x = x + 1 # Increment x
E262: x = x + 1  #Increment x
E262: x = x + 1  #  Increment x
E265: #Block comment
E266: ### Block comment

    Whitespace after '('
    Open

            mean    = np.mean( ft.real )
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Avoid extraneous whitespace.

    Avoid extraneous whitespace in these situations:
- Immediately inside parentheses, brackets or braces.
- Immediately before a comma, semicolon, or colon.

Okay: spam(ham[1], {eggs: 2})
E201: spam( ham[1], {eggs: 2})
E201: spam(ham[ 1], {eggs: 2})
E201: spam(ham[1], { eggs: 2})
E202: spam(ham[1], {eggs: 2} )
E202: spam(ham[1 ], {eggs: 2})
E202: spam(ham[1], {eggs: 2 })

E203: if x == 4: print x, y; x, y = y , x
E203: if x == 4: print x, y ; x, y = y, x
E203: if x == 4 : print x, y; x, y = y, x

    Whitespace after '('
    Open

            std     = np.std( ft.real, ddof=1) # sqrt( SUM((x-<x>)**2)/(N-1) )
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Avoid extraneous whitespace.

    Avoid extraneous whitespace in these situations:
- Immediately inside parentheses, brackets or braces.
- Immediately before a comma, semicolon, or colon.

Okay: spam(ham[1], {eggs: 2})
E201: spam( ham[1], {eggs: 2})
E201: spam(ham[ 1], {eggs: 2})
E201: spam(ham[1], { eggs: 2})
E202: spam(ham[1], {eggs: 2} )
E202: spam(ham[1 ], {eggs: 2})
E202: spam(ham[1], {eggs: 2 })

E203: if x == 4: print x, y; x, y = y , x
E203: if x == 4: print x, y ; x, y = y, x
E203: if x == 4 : print x, y; x, y = y, x

    Missing whitespace after ','
    Open

        ax2 = fig.add_subplot(2,1,2)
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Each comma, semicolon or colon should be followed by whitespace.

    Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

    Missing whitespace after ','
    Open

            data = pyfftw.zeros_aligned((N),dtype='complex128')
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Each comma, semicolon or colon should be followed by whitespace.

    Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

    Missing whitespace after ','
    Open

            data[yi,xi] = data[yi,xi] + 1
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Each comma, semicolon or colon should be followed by whitespace.

    Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

    Line too long (96 > 79 characters)
    Open

        The arguents are the same as `calc_ace` but not used except for the number of elements, `N`.
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    Expected 2 blank lines, found 1
    Open

    def calc_ace(rg, N, T, ace):
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Separate top-level function and class definitions with two blank lines.

    Method definitions inside a class are separated by a single blank
line.

Extra blank lines may be used (sparingly) to separate groups of
related functions.  Blank lines may be omitted between a bunch of
related one-liners (e.g. a set of dummy implementations).

Use blank lines in functions, sparingly, to indicate logical
sections.

Okay: def a():\n    pass\n\n\ndef b():\n    pass
Okay: def a():\n    pass\n\n\nasync def b():\n    pass
Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
Okay: default = 1\nfoo = 1
Okay: classify = 1\nfoo = 1

E301: class Foo:\n    b = 0\n    def bar():\n        pass
E302: def a():\n    pass\n\ndef b(n):\n    pass
E302: def a():\n    pass\n\nasync def b(n):\n    pass
E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
E303: def a():\n\n\n\n    pass
E304: @decorator\n\ndef a():\n    pass
E305: def a():\n    pass\na()
E306: def a():\n    def b():\n        pass\n    def c():\n        pass

    Missing whitespace after ','
    Open

        p2  = ax2.plot(FR,psdn[0:int(N/2+1)], marker='o',\
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Each comma, semicolon or colon should be followed by whitespace.

    Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

    Too many leading '#' for block comment
    Open

            ## To make the data real values, set some phases to be zero.
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Separate inline comments by at least two spaces.

    An inline comment is a comment on the same line as a statement.
Inline comments should be separated by at least two spaces from the
statement. They should start with a # and a single space.

Each line of a block comment starts with a # and a single space
(unless it is indented text inside the comment).

Okay: x = x + 1  # Increment x
Okay: x = x + 1    # Increment x
Okay: # Block comment
E261: x = x + 1 # Increment x
E262: x = x + 1  #Increment x
E262: x = x + 1  #  Increment x
E265: #Block comment
E266: ### Block comment

    Whitespace before ')'
    Open

            acedata = ( ft.real - mean ) / std # Centering and normalizing with std.
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Avoid extraneous whitespace.

    Avoid extraneous whitespace in these situations:
- Immediately inside parentheses, brackets or braces.
- Immediately before a comma, semicolon, or colon.

Okay: spam(ham[1], {eggs: 2})
E201: spam( ham[1], {eggs: 2})
E201: spam(ham[ 1], {eggs: 2})
E201: spam(ham[1], { eggs: 2})
E202: spam(ham[1], {eggs: 2} )
E202: spam(ham[1 ], {eggs: 2})
E202: spam(ham[1], {eggs: 2 })

E203: if x == 4: print x, y; x, y = y , x
E203: if x == 4: print x, y ; x, y = y, x
E203: if x == 4 : print x, y; x, y = y, x

    Unexpected indentation (comment)
    Open

                                               # PSD of the result (not normalized).
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Use indent_size (PEP8 says 4) spaces per indentation level.

    For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

    Missing whitespace after ','
    Open

        ax1 = fig.add_subplot(2,1,1)
    Severity: Minor
    Found in src/jis/photonsim/ace.py by pep8

    Each comma, semicolon or colon should be followed by whitespace.

    Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

    There are no issues that match your filters.

    Category
    Status