JASMINE-Mission/jasmine-imagesim

View on GitHub
src/jis/photonsim/psf.py

Summary

Maintainability
C
7 hrs
Test Coverage
F
0%

Cyclomatic complexity is too high in function calc_psf. (9)
Open

def calc_psf(wfe, wN, WL, NP, Ntot, Stel, adata, M, aN, fN=520):
    """
    This function calculates the psf in e-/sec/fp-cell
    based on the wavefront error (wfe),
    the spectral information (NP), and
Severity: Minor
Found in src/jis/photonsim/psf.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function calc_dummy_psf has 10 arguments (exceeds 5 allowed). Consider refactoring.
Open

def calc_dummy_psf(wfe, wN, WL, NP, Ntot, Stel, adata, M, aN, fN=520):
Severity: Major
Found in src/jis/photonsim/psf.py - About 1 hr to fix

    Function calc_psf has 10 arguments (exceeds 5 allowed). Consider refactoring.
    Open

    def calc_psf(wfe, wN, WL, NP, Ntot, Stel, adata, M, aN, fN=520):
    Severity: Major
    Found in src/jis/photonsim/psf.py - About 1 hr to fix

      Function calc_psf has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      def calc_psf(wfe, wN, WL, NP, Ntot, Stel, adata, M, aN, fN=520):
          """
          This function calculates the psf in e-/sec/fp-cell
          based on the wavefront error (wfe),
          the spectral information (NP), and
      Severity: Minor
      Found in src/jis/photonsim/psf.py - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Either merge this branch with the identical one on line "116" or change one of the implementations.
      Open

                  offset=0.5
      Severity: Major
      Found in src/jis/photonsim/psf.py by sonar-python

      Having two branches in the same if structure with the same implementation is at best duplicate code, and at worst a coding error. If the same logic is truly needed for both instances, then they should be combined.

      Noncompliant Code Example

      if 0 <= a < 10:
          do_the_thing()
      elif 10 <= a < 20:
          do_the_other_thing()
      elif 20 <= a < 50:
          do_the_thing()  # Noncompliant; duplicates first condition
      else:
          do_the_rest()
      
      b = 4 if a > 12 else 4
      

      Compliant Solution

      if (0 <= a < 10) or (20 <= a < 50):
          do_the_thing()
      elif 10 <= a < 20:
          do_the_other_thing()
      else:
          do_the_rest()
      
      b = 4
      

      or

      if 0 <= a < 10:
          do_the_thing()
      elif 10 <= a < 20:
          do_the_other_thing()
      elif 20 <= a < 50:
          do_the_third_thing()
      else:
          do_the_rest()
      
      b = 8 if a > 12 else 4
      

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              NPm   = (NP[i] + NP[i+1])/2
      Severity: Minor
      Found in src/jis/photonsim/psf.py and 1 other location - About 45 mins to fix
      src/jis/photonsim/psf.py on lines 81..81

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          sigma = fwhm/2.0/np.sqrt(2*np.log(2))
      Severity: Minor
      Found in src/jis/photonsim/psf.py and 1 other location - About 45 mins to fix
      src/jis/photonsim/psf.py on lines 179..179

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              WLm = (WL[i] + WL[i+1])/2
      Severity: Minor
      Found in src/jis/photonsim/psf.py and 1 other location - About 45 mins to fix
      src/jis/photonsim/psf.py on lines 109..109

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          sigma         = fwhm_fp_cell/2./np.sqrt(2.*np.log(2.))
      Severity: Minor
      Found in src/jis/photonsim/psf.py and 1 other location - About 45 mins to fix
      src/jis/photonsim/psf.py on lines 154..154

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              wfec.real = np.cos(wfer/WLm*2.*np.pi)
      Severity: Minor
      Found in src/jis/photonsim/psf.py and 1 other location - About 35 mins to fix
      src/jis/photonsim/psf.py on lines 96..96

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              wfec.imag = np.sin(wfer/WLm*2.*np.pi)
      Severity: Minor
      Found in src/jis/photonsim/psf.py and 1 other location - About 35 mins to fix
      src/jis/photonsim/psf.py on lines 95..95

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Line too long (82 > 79 characters)
      Open

              fN    (int)    : Number of fp-cells of the output psf data (Default: 520).
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Whitespace after '('
      Open

          wfec = np.empty( (wN,wN),dtype='complex128')
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Avoid extraneous whitespace.

      Avoid extraneous whitespace in these situations:
      - Immediately inside parentheses, brackets or braces.
      - Immediately before a comma, semicolon, or colon.
      
      Okay: spam(ham[1], {eggs: 2})
      E201: spam( ham[1], {eggs: 2})
      E201: spam(ham[ 1], {eggs: 2})
      E201: spam(ham[1], { eggs: 2})
      E202: spam(ham[1], {eggs: 2} )
      E202: spam(ham[1 ], {eggs: 2})
      E202: spam(ham[1], {eggs: 2 })
      
      E203: if x == 4: print x, y; x, y = y , x
      E203: if x == 4: print x, y ; x, y = y, x
      E203: if x == 4 : print x, y; x, y = y, x

      Missing whitespace around modulo operator
      Open

              elif (N%2==1) and (fN%2==0):
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Surround operators with a single space on either side.

      - Always surround these binary operators with a single space on
        either side: assignment (=), augmented assignment (+=, -= etc.),
        comparisons (==, <, >, !=, <=, >=, in, not in, is, is not),
        Booleans (and, or, not).
      
      - If operators with different priorities are used, consider adding
        whitespace around the operators with the lowest priorities.
      
      Okay: i = i + 1
      Okay: submitted += 1
      Okay: x = x * 2 - 1
      Okay: hypot2 = x * x + y * y
      Okay: c = (a + b) * (a - b)
      Okay: foo(bar, key='word', *args, **kwargs)
      Okay: alpha[:-i]
      
      E225: i=i+1
      E225: submitted +=1
      E225: x = x /2 - 1
      E225: z = x **y
      E225: z = 1and 1
      E226: c = (a+b) * (a-b)
      E226: hypot2 = x*x + y*y
      E227: c = a|b
      E228: msg = fmt%(errno, errmsg)

      At least two spaces before inline comment
      Open

          fp_cell_scale = 1.e-3/M # rad/fp-cell.
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Separate inline comments by at least two spaces.

      An inline comment is a comment on the same line as a statement.
      Inline comments should be separated by at least two spaces from the
      statement. They should start with a # and a single space.
      
      Each line of a block comment starts with a # and a single space
      (unless it is indented text inside the comment).
      
      Okay: x = x + 1  # Increment x
      Okay: x = x + 1    # Increment x
      Okay: # Block comment
      E261: x = x + 1 # Increment x
      E262: x = x + 1  #Increment x
      E262: x = x + 1  #  Increment x
      E265: #Block comment
      E266: ### Block comment

      Whitespace after '('
      Open

          wfer = np.nan_to_num( wfe )
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Avoid extraneous whitespace.

      Avoid extraneous whitespace in these situations:
      - Immediately inside parentheses, brackets or braces.
      - Immediately before a comma, semicolon, or colon.
      
      Okay: spam(ham[1], {eggs: 2})
      E201: spam( ham[1], {eggs: 2})
      E201: spam(ham[ 1], {eggs: 2})
      E201: spam(ham[1], { eggs: 2})
      E202: spam(ham[1], {eggs: 2} )
      E202: spam(ham[1 ], {eggs: 2})
      E202: spam(ham[1], {eggs: 2 })
      
      E203: if x == 4: print x, y; x, y = y , x
      E203: if x == 4: print x, y ; x, y = y, x
      E203: if x == 4 : print x, y; x, y = y, x

      Whitespace before ')'
      Open

          wfer = np.nan_to_num( wfe )
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Avoid extraneous whitespace.

      Avoid extraneous whitespace in these situations:
      - Immediately inside parentheses, brackets or braces.
      - Immediately before a comma, semicolon, or colon.
      
      Okay: spam(ham[1], {eggs: 2})
      E201: spam( ham[1], {eggs: 2})
      E201: spam(ham[ 1], {eggs: 2})
      E201: spam(ham[1], { eggs: 2})
      E202: spam(ham[1], {eggs: 2} )
      E202: spam(ham[1 ], {eggs: 2})
      E202: spam(ham[1], {eggs: 2 })
      
      E203: if x == 4: print x, y; x, y = y , x
      E203: if x == 4: print x, y ; x, y = y, x
      E203: if x == 4 : print x, y; x, y = y, x

      Whitespace after '('
      Open

          image = np.zeros( (fN, fN) ,dtype ='float' )
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Avoid extraneous whitespace.

      Avoid extraneous whitespace in these situations:
      - Immediately inside parentheses, brackets or braces.
      - Immediately before a comma, semicolon, or colon.
      
      Okay: spam(ham[1], {eggs: 2})
      E201: spam( ham[1], {eggs: 2})
      E201: spam(ham[ 1], {eggs: 2})
      E201: spam(ham[1], { eggs: 2})
      E202: spam(ham[1], {eggs: 2} )
      E202: spam(ham[1 ], {eggs: 2})
      E202: spam(ham[1], {eggs: 2 })
      
      E203: if x == 4: print x, y; x, y = y , x
      E203: if x == 4: print x, y ; x, y = y, x
      E203: if x == 4 : print x, y; x, y = y, x

      Missing whitespace after ','
      Open

              data = pyfftw.zeros_aligned((N,N),dtype='complex128')
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
      Okay: (3,)
      Okay: a[1:4]
      Okay: a[:4]
      Okay: a[1:]
      Okay: a[1:4:2]
      E231: ['a','b']
      E231: foo(bar,baz)
      E231: [{'a':'b'}]

      Missing whitespace around operator
      Open

              if   (N%2==0) and (fN%2==1):
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Surround operators with a single space on either side.

      - Always surround these binary operators with a single space on
        either side: assignment (=), augmented assignment (+=, -= etc.),
        comparisons (==, <, >, !=, <=, >=, in, not in, is, is not),
        Booleans (and, or, not).
      
      - If operators with different priorities are used, consider adding
        whitespace around the operators with the lowest priorities.
      
      Okay: i = i + 1
      Okay: submitted += 1
      Okay: x = x * 2 - 1
      Okay: hypot2 = x * x + y * y
      Okay: c = (a + b) * (a - b)
      Okay: foo(bar, key='word', *args, **kwargs)
      Okay: alpha[:-i]
      
      E225: i=i+1
      E225: submitted +=1
      E225: x = x /2 - 1
      E225: z = x **y
      E225: z = 1and 1
      E226: c = (a+b) * (a-b)
      E226: hypot2 = x*x + y*y
      E227: c = a|b
      E228: msg = fmt%(errno, errmsg)

      Missing whitespace around modulo operator
      Open

              elif (N%2==0) and (fN%2==0):
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Surround operators with a single space on either side.

      - Always surround these binary operators with a single space on
        either side: assignment (=), augmented assignment (+=, -= etc.),
        comparisons (==, <, >, !=, <=, >=, in, not in, is, is not),
        Booleans (and, or, not).
      
      - If operators with different priorities are used, consider adding
        whitespace around the operators with the lowest priorities.
      
      Okay: i = i + 1
      Okay: submitted += 1
      Okay: x = x * 2 - 1
      Okay: hypot2 = x * x + y * y
      Okay: c = (a + b) * (a - b)
      Okay: foo(bar, key='word', *args, **kwargs)
      Okay: alpha[:-i]
      
      E225: i=i+1
      E225: submitted +=1
      E225: x = x /2 - 1
      E225: z = x **y
      E225: z = 1and 1
      E226: c = (a+b) * (a-b)
      E226: hypot2 = x*x + y*y
      E227: c = a|b
      E228: msg = fmt%(errno, errmsg)

      Missing whitespace after ','
      Open

          xx,yy = np.meshgrid(arr,arr)
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
      Okay: (3,)
      Okay: a[1:4]
      Okay: a[:4]
      Okay: a[1:]
      Okay: a[1:4:2]
      E231: ['a','b']
      E231: foo(bar,baz)
      E231: [{'a':'b'}]

      Line too long (84 > 79 characters)
      Open

          # If their parities are different, the centers of wfe and apt will be different.
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Multiple spaces after keyword
      Open

              if   (N%2==0) and (fN%2==1):
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Avoid extraneous whitespace around keywords.

      Okay: True and False
      E271: True and  False
      E272: True  and False
      E273: True and\tFalse
      E274: True\tand False

      Missing whitespace around operator
      Open

                  offset=0.5
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Surround operators with a single space on either side.

      - Always surround these binary operators with a single space on
        either side: assignment (=), augmented assignment (+=, -= etc.),
        comparisons (==, <, >, !=, <=, >=, in, not in, is, is not),
        Booleans (and, or, not).
      
      - If operators with different priorities are used, consider adding
        whitespace around the operators with the lowest priorities.
      
      Okay: i = i + 1
      Okay: submitted += 1
      Okay: x = x * 2 - 1
      Okay: hypot2 = x * x + y * y
      Okay: c = (a + b) * (a - b)
      Okay: foo(bar, key='word', *args, **kwargs)
      Okay: alpha[:-i]
      
      E225: i=i+1
      E225: submitted +=1
      E225: x = x /2 - 1
      E225: z = x **y
      E225: z = 1and 1
      E226: c = (a+b) * (a-b)
      E226: hypot2 = x*x + y*y
      E227: c = a|b
      E228: msg = fmt%(errno, errmsg)

      Missing whitespace around modulo operator
      Open

              elif (N%2==1) and (fN%2==0):
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Surround operators with a single space on either side.

      - Always surround these binary operators with a single space on
        either side: assignment (=), augmented assignment (+=, -= etc.),
        comparisons (==, <, >, !=, <=, >=, in, not in, is, is not),
        Booleans (and, or, not).
      
      - If operators with different priorities are used, consider adding
        whitespace around the operators with the lowest priorities.
      
      Okay: i = i + 1
      Okay: submitted += 1
      Okay: x = x * 2 - 1
      Okay: hypot2 = x * x + y * y
      Okay: c = (a + b) * (a - b)
      Okay: foo(bar, key='word', *args, **kwargs)
      Okay: alpha[:-i]
      
      E225: i=i+1
      E225: submitted +=1
      E225: x = x /2 - 1
      E225: z = x **y
      E225: z = 1and 1
      E226: c = (a+b) * (a-b)
      E226: hypot2 = x*x + y*y
      E227: c = a|b
      E228: msg = fmt%(errno, errmsg)

      Missing whitespace after ','
      Open

          arr = np.arange(0,fN)-(fN-1.)/2.
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
      Okay: (3,)
      Okay: a[1:4]
      Okay: a[:4]
      Okay: a[1:]
      Okay: a[1:4:2]
      E231: ['a','b']
      E231: foo(bar,baz)
      E231: [{'a':'b'}]

      Whitespace before ','
      Open

          image = np.zeros( (fN, fN) ,dtype ='float' )
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Avoid extraneous whitespace.

      Avoid extraneous whitespace in these situations:
      - Immediately inside parentheses, brackets or braces.
      - Immediately before a comma, semicolon, or colon.
      
      Okay: spam(ham[1], {eggs: 2})
      E201: spam( ham[1], {eggs: 2})
      E201: spam(ham[ 1], {eggs: 2})
      E201: spam(ham[1], { eggs: 2})
      E202: spam(ham[1], {eggs: 2} )
      E202: spam(ham[1 ], {eggs: 2})
      E202: spam(ham[1], {eggs: 2 })
      
      E203: if x == 4: print x, y; x, y = y , x
      E203: if x == 4: print x, y ; x, y = y, x
      E203: if x == 4 : print x, y; x, y = y, x

      Missing whitespace after ','
      Open

              data[i3:i4,i3:i4] = data[i3:i4,i3:i4] * wfec
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
      Okay: (3,)
      Okay: a[1:4]
      Okay: a[:4]
      Okay: a[1:]
      Okay: a[1:4:2]
      E231: ['a','b']
      E231: foo(bar,baz)
      E231: [{'a':'b'}]

      Missing whitespace around operator
      Open

                  offset=1.0
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Surround operators with a single space on either side.

      - Always surround these binary operators with a single space on
        either side: assignment (=), augmented assignment (+=, -= etc.),
        comparisons (==, <, >, !=, <=, >=, in, not in, is, is not),
        Booleans (and, or, not).
      
      - If operators with different priorities are used, consider adding
        whitespace around the operators with the lowest priorities.
      
      Okay: i = i + 1
      Okay: submitted += 1
      Okay: x = x * 2 - 1
      Okay: hypot2 = x * x + y * y
      Okay: c = (a + b) * (a - b)
      Okay: foo(bar, key='word', *args, **kwargs)
      Okay: alpha[:-i]
      
      E225: i=i+1
      E225: submitted +=1
      E225: x = x /2 - 1
      E225: z = x **y
      E225: z = 1and 1
      E226: c = (a+b) * (a-b)
      E226: hypot2 = x*x + y*y
      E227: c = a|b
      E228: msg = fmt%(errno, errmsg)

      Missing whitespace after ','
      Open

              data.real[i1:i2,i1:i2] = adata[:,:]
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
      Okay: (3,)
      Okay: a[1:4]
      Okay: a[:4]
      Okay: a[1:]
      Okay: a[1:4:2]
      E231: ['a','b']
      E231: foo(bar,baz)
      E231: [{'a':'b'}]

      Missing whitespace around modulo operator
      Open

              if   (N%2==0) and (fN%2==1):
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Surround operators with a single space on either side.

      - Always surround these binary operators with a single space on
        either side: assignment (=), augmented assignment (+=, -= etc.),
        comparisons (==, <, >, !=, <=, >=, in, not in, is, is not),
        Booleans (and, or, not).
      
      - If operators with different priorities are used, consider adding
        whitespace around the operators with the lowest priorities.
      
      Okay: i = i + 1
      Okay: submitted += 1
      Okay: x = x * 2 - 1
      Okay: hypot2 = x * x + y * y
      Okay: c = (a + b) * (a - b)
      Okay: foo(bar, key='word', *args, **kwargs)
      Okay: alpha[:-i]
      
      E225: i=i+1
      E225: submitted +=1
      E225: x = x /2 - 1
      E225: z = x **y
      E225: z = 1and 1
      E226: c = (a+b) * (a-b)
      E226: hypot2 = x*x + y*y
      E227: c = a|b
      E228: msg = fmt%(errno, errmsg)

      Line too long (94 > 79 characters)
      Open

          The arguments are the same as `calc_psf` but not used except for `Ntot`, `Stel`, and `fN`.
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Missing whitespace after ','
      Open

          arr = np.linspace(-10,10,fN)
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
      Okay: (3,)
      Okay: a[1:4]
      Okay: a[:4]
      Okay: a[1:]
      Okay: a[1:4:2]
      E231: ['a','b']
      E231: foo(bar,baz)
      E231: [{'a':'b'}]

      Missing whitespace after ','
      Open

              data.real[i1:i2,i1:i2] = adata[:,:]
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
      Okay: (3,)
      Okay: a[1:4]
      Okay: a[:4]
      Okay: a[1:]
      Okay: a[1:4:2]
      E231: ['a','b']
      E231: foo(bar,baz)
      E231: [{'a':'b'}]

      Missing whitespace around operator
      Open

                  offset=0.5
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Surround operators with a single space on either side.

      - Always surround these binary operators with a single space on
        either side: assignment (=), augmented assignment (+=, -= etc.),
        comparisons (==, <, >, !=, <=, >=, in, not in, is, is not),
        Booleans (and, or, not).
      
      - If operators with different priorities are used, consider adding
        whitespace around the operators with the lowest priorities.
      
      Okay: i = i + 1
      Okay: submitted += 1
      Okay: x = x * 2 - 1
      Okay: hypot2 = x * x + y * y
      Okay: c = (a + b) * (a - b)
      Okay: foo(bar, key='word', *args, **kwargs)
      Okay: alpha[:-i]
      
      E225: i=i+1
      E225: submitted +=1
      E225: x = x /2 - 1
      E225: z = x **y
      E225: z = 1and 1
      E226: c = (a+b) * (a-b)
      E226: hypot2 = x*x + y*y
      E227: c = a|b
      E228: msg = fmt%(errno, errmsg)

      Missing whitespace around operator
      Open

              elif (N%2==1) and (fN%2==0):
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Surround operators with a single space on either side.

      - Always surround these binary operators with a single space on
        either side: assignment (=), augmented assignment (+=, -= etc.),
        comparisons (==, <, >, !=, <=, >=, in, not in, is, is not),
        Booleans (and, or, not).
      
      - If operators with different priorities are used, consider adding
        whitespace around the operators with the lowest priorities.
      
      Okay: i = i + 1
      Okay: submitted += 1
      Okay: x = x * 2 - 1
      Okay: hypot2 = x * x + y * y
      Okay: c = (a + b) * (a - b)
      Okay: foo(bar, key='word', *args, **kwargs)
      Okay: alpha[:-i]
      
      E225: i=i+1
      E225: submitted +=1
      E225: x = x /2 - 1
      E225: z = x **y
      E225: z = 1and 1
      E226: c = (a+b) * (a-b)
      E226: hypot2 = x*x + y*y
      E227: c = a|b
      E228: msg = fmt%(errno, errmsg)

      Unexpected spaces around keyword / parameter equals
      Open

          image = np.zeros( (fN, fN) ,dtype ='float' )
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Don't use spaces around the '=' sign in function arguments.

      Don't use spaces around the '=' sign when used to indicate a
      keyword argument or a default parameter value, except when
      using a type annotation.
      
      Okay: def complex(real, imag=0.0):
      Okay: return magic(r=real, i=imag)
      Okay: boolean(a == b)
      Okay: boolean(a != b)
      Okay: boolean(a <= b)
      Okay: boolean(a >= b)
      Okay: def foo(arg: int = 42):
      Okay: async def foo(arg: int = 42):
      
      E251: def complex(real, imag = 0.0):
      E251: return magic(r = real, i = imag)
      E252: def complex(real, image: float=0.0):

      Missing whitespace around operator
      Open

              elif (N%2==0) and (fN%2==0):
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Surround operators with a single space on either side.

      - Always surround these binary operators with a single space on
        either side: assignment (=), augmented assignment (+=, -= etc.),
        comparisons (==, <, >, !=, <=, >=, in, not in, is, is not),
        Booleans (and, or, not).
      
      - If operators with different priorities are used, consider adding
        whitespace around the operators with the lowest priorities.
      
      Okay: i = i + 1
      Okay: submitted += 1
      Okay: x = x * 2 - 1
      Okay: hypot2 = x * x + y * y
      Okay: c = (a + b) * (a - b)
      Okay: foo(bar, key='word', *args, **kwargs)
      Okay: alpha[:-i]
      
      E225: i=i+1
      E225: submitted +=1
      E225: x = x /2 - 1
      E225: z = x **y
      E225: z = 1and 1
      E226: c = (a+b) * (a-b)
      E226: hypot2 = x*x + y*y
      E227: c = a|b
      E228: msg = fmt%(errno, errmsg)

      Missing whitespace after ','
      Open

          arr = np.linspace(-10,10,fN)
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
      Okay: (3,)
      Okay: a[1:4]
      Okay: a[:4]
      Okay: a[1:]
      Okay: a[1:4:2]
      E231: ['a','b']
      E231: foo(bar,baz)
      E231: [{'a':'b'}]

      Missing whitespace after ','
      Open

          xx,yy = np.meshgrid(arr,arr)
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
      Okay: (3,)
      Okay: a[1:4]
      Okay: a[:4]
      Okay: a[1:]
      Okay: a[1:4:2]
      E231: ['a','b']
      E231: foo(bar,baz)
      E231: [{'a':'b'}]

      Missing whitespace around modulo operator
      Open

              elif (N%2==0) and (fN%2==0):
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Surround operators with a single space on either side.

      - Always surround these binary operators with a single space on
        either side: assignment (=), augmented assignment (+=, -= etc.),
        comparisons (==, <, >, !=, <=, >=, in, not in, is, is not),
        Booleans (and, or, not).
      
      - If operators with different priorities are used, consider adding
        whitespace around the operators with the lowest priorities.
      
      Okay: i = i + 1
      Okay: submitted += 1
      Okay: x = x * 2 - 1
      Okay: hypot2 = x * x + y * y
      Okay: c = (a + b) * (a - b)
      Okay: foo(bar, key='word', *args, **kwargs)
      Okay: alpha[:-i]
      
      E225: i=i+1
      E225: submitted +=1
      E225: x = x /2 - 1
      E225: z = x **y
      E225: z = 1and 1
      E226: c = (a+b) * (a-b)
      E226: hypot2 = x*x + y*y
      E227: c = a|b
      E228: msg = fmt%(errno, errmsg)

      Expected 2 blank lines, found 1
      Open

      def calc_psf(wfe, wN, WL, NP, Ntot, Stel, adata, M, aN, fN=520):
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Separate top-level function and class definitions with two blank lines.

      Method definitions inside a class are separated by a single blank
      line.
      
      Extra blank lines may be used (sparingly) to separate groups of
      related functions.  Blank lines may be omitted between a bunch of
      related one-liners (e.g. a set of dummy implementations).
      
      Use blank lines in functions, sparingly, to indicate logical
      sections.
      
      Okay: def a():\n    pass\n\n\ndef b():\n    pass
      Okay: def a():\n    pass\n\n\nasync def b():\n    pass
      Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
      Okay: default = 1\nfoo = 1
      Okay: classify = 1\nfoo = 1
      
      E301: class Foo:\n    b = 0\n    def bar():\n        pass
      E302: def a():\n    pass\n\ndef b(n):\n    pass
      E302: def a():\n    pass\n\nasync def b(n):\n    pass
      E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
      E303: def a():\n\n\n\n    pass
      E304: @decorator\n\ndef a():\n    pass
      E305: def a():\n    pass\na()
      E306: def a():\n    def b():\n        pass\n    def c():\n        pass

      Missing whitespace after ','
      Open

          wfec = np.empty( (wN,wN),dtype='complex128')
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
      Okay: (3,)
      Okay: a[1:4]
      Okay: a[:4]
      Okay: a[1:]
      Okay: a[1:4:2]
      E231: ['a','b']
      E231: foo(bar,baz)
      E231: [{'a':'b'}]

      Missing whitespace after ','
      Open

          image = np.zeros( (fN, fN) ,dtype ='float' )
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
      Okay: (3,)
      Okay: a[1:4]
      Okay: a[:4]
      Okay: a[1:]
      Okay: a[1:4:2]
      E231: ['a','b']
      E231: foo(bar,baz)
      E231: [{'a':'b'}]

      Missing whitespace after ','
      Open

              data[i3:i4,i3:i4] = data[i3:i4,i3:i4] * wfec
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
      Okay: (3,)
      Okay: a[1:4]
      Okay: a[:4]
      Okay: a[1:]
      Okay: a[1:4:2]
      E231: ['a','b']
      E231: foo(bar,baz)
      E231: [{'a':'b'}]

      Missing whitespace around modulo operator
      Open

              if   (N%2==0) and (fN%2==1):
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Surround operators with a single space on either side.

      - Always surround these binary operators with a single space on
        either side: assignment (=), augmented assignment (+=, -= etc.),
        comparisons (==, <, >, !=, <=, >=, in, not in, is, is not),
        Booleans (and, or, not).
      
      - If operators with different priorities are used, consider adding
        whitespace around the operators with the lowest priorities.
      
      Okay: i = i + 1
      Okay: submitted += 1
      Okay: x = x * 2 - 1
      Okay: hypot2 = x * x + y * y
      Okay: c = (a + b) * (a - b)
      Okay: foo(bar, key='word', *args, **kwargs)
      Okay: alpha[:-i]
      
      E225: i=i+1
      E225: submitted +=1
      E225: x = x /2 - 1
      E225: z = x **y
      E225: z = 1and 1
      E226: c = (a+b) * (a-b)
      E226: hypot2 = x*x + y*y
      E227: c = a|b
      E228: msg = fmt%(errno, errmsg)

      Line too long (83 > 79 characters)
      Open

          This function calculates a dummy point-spread function image in e-/sec/fp-cell.
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Missing whitespace after ','
      Open

          wfec = np.empty( (wN,wN),dtype='complex128')
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
      Okay: (3,)
      Okay: a[1:4]
      Okay: a[:4]
      Okay: a[1:]
      Okay: a[1:4:2]
      E231: ['a','b']
      E231: foo(bar,baz)
      E231: [{'a':'b'}]

      Line too long (82 > 79 characters)
      Open

              fN    (int)    : Number of fp-cells of the output psf data (Default: 520).
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Whitespace before ')'
      Open

          image = np.zeros( (fN, fN) ,dtype ='float' )
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Avoid extraneous whitespace.

      Avoid extraneous whitespace in these situations:
      - Immediately inside parentheses, brackets or braces.
      - Immediately before a comma, semicolon, or colon.
      
      Okay: spam(ham[1], {eggs: 2})
      E201: spam( ham[1], {eggs: 2})
      E201: spam(ham[ 1], {eggs: 2})
      E201: spam(ham[1], { eggs: 2})
      E202: spam(ham[1], {eggs: 2} )
      E202: spam(ham[1 ], {eggs: 2})
      E202: spam(ham[1], {eggs: 2 })
      
      E203: if x == 4: print x, y; x, y = y , x
      E203: if x == 4: print x, y ; x, y = y, x
      E203: if x == 4 : print x, y; x, y = y, x

      Missing whitespace after ','
      Open

              data = pyfftw.zeros_aligned((N,N),dtype='complex128')
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
      Okay: (3,)
      Okay: a[1:4]
      Okay: a[:4]
      Okay: a[1:]
      Okay: a[1:4:2]
      E231: ['a','b']
      E231: foo(bar,baz)
      E231: [{'a':'b'}]

      Missing whitespace around operator
      Open

              if   (N%2==0) and (fN%2==1):
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Surround operators with a single space on either side.

      - Always surround these binary operators with a single space on
        either side: assignment (=), augmented assignment (+=, -= etc.),
        comparisons (==, <, >, !=, <=, >=, in, not in, is, is not),
        Booleans (and, or, not).
      
      - If operators with different priorities are used, consider adding
        whitespace around the operators with the lowest priorities.
      
      Okay: i = i + 1
      Okay: submitted += 1
      Okay: x = x * 2 - 1
      Okay: hypot2 = x * x + y * y
      Okay: c = (a + b) * (a - b)
      Okay: foo(bar, key='word', *args, **kwargs)
      Okay: alpha[:-i]
      
      E225: i=i+1
      E225: submitted +=1
      E225: x = x /2 - 1
      E225: z = x **y
      E225: z = 1and 1
      E226: c = (a+b) * (a-b)
      E226: hypot2 = x*x + y*y
      E227: c = a|b
      E228: msg = fmt%(errno, errmsg)

      Missing whitespace around operator
      Open

              elif (N%2==0) and (fN%2==0):
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Surround operators with a single space on either side.

      - Always surround these binary operators with a single space on
        either side: assignment (=), augmented assignment (+=, -= etc.),
        comparisons (==, <, >, !=, <=, >=, in, not in, is, is not),
        Booleans (and, or, not).
      
      - If operators with different priorities are used, consider adding
        whitespace around the operators with the lowest priorities.
      
      Okay: i = i + 1
      Okay: submitted += 1
      Okay: x = x * 2 - 1
      Okay: hypot2 = x * x + y * y
      Okay: c = (a + b) * (a - b)
      Okay: foo(bar, key='word', *args, **kwargs)
      Okay: alpha[:-i]
      
      E225: i=i+1
      E225: submitted +=1
      E225: x = x /2 - 1
      E225: z = x **y
      E225: z = 1and 1
      E226: c = (a+b) * (a-b)
      E226: hypot2 = x*x + y*y
      E227: c = a|b
      E228: msg = fmt%(errno, errmsg)

      Missing whitespace around operator
      Open

              elif (N%2==1) and (fN%2==0):
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Surround operators with a single space on either side.

      - Always surround these binary operators with a single space on
        either side: assignment (=), augmented assignment (+=, -= etc.),
        comparisons (==, <, >, !=, <=, >=, in, not in, is, is not),
        Booleans (and, or, not).
      
      - If operators with different priorities are used, consider adding
        whitespace around the operators with the lowest priorities.
      
      Okay: i = i + 1
      Okay: submitted += 1
      Okay: x = x * 2 - 1
      Okay: hypot2 = x * x + y * y
      Okay: c = (a + b) * (a - b)
      Okay: foo(bar, key='word', *args, **kwargs)
      Okay: alpha[:-i]
      
      E225: i=i+1
      E225: submitted +=1
      E225: x = x /2 - 1
      E225: z = x **y
      E225: z = 1and 1
      E226: c = (a+b) * (a-b)
      E226: hypot2 = x*x + y*y
      E227: c = a|b
      E228: msg = fmt%(errno, errmsg)

      Missing whitespace around modulo operator
      Open

          if (wN+aN)%2 == 1:
      Severity: Minor
      Found in src/jis/photonsim/psf.py by pep8

      Surround operators with a single space on either side.

      - Always surround these binary operators with a single space on
        either side: assignment (=), augmented assignment (+=, -= etc.),
        comparisons (==, <, >, !=, <=, >=, in, not in, is, is not),
        Booleans (and, or, not).
      
      - If operators with different priorities are used, consider adding
        whitespace around the operators with the lowest priorities.
      
      Okay: i = i + 1
      Okay: submitted += 1
      Okay: x = x * 2 - 1
      Okay: hypot2 = x * x + y * y
      Okay: c = (a + b) * (a - b)
      Okay: foo(bar, key='word', *args, **kwargs)
      Okay: alpha[:-i]
      
      E225: i=i+1
      E225: submitted +=1
      E225: x = x /2 - 1
      E225: z = x **y
      E225: z = 1and 1
      E226: c = (a+b) * (a-b)
      E226: hypot2 = x*x + y*y
      E227: c = a|b
      E228: msg = fmt%(errno, errmsg)

      There are no issues that match your filters.

      Category
      Status