Showing 7 of 7 total issues
Function run has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
Open
public function run(): void
{
foreach ($this->routes as $route) {
if ($this->isMethodNotInRoutes($route)) {
// skip this route- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid unused private methods such as 'autoload'. Open
Open
private function autoload(string $class): void
{
$class = str_replace('\\', '/', $class); // revert path for old PHP on Linux
if (file_exists('classes/' . $class . '.php')) {
/** @noinspection PhpIncludeInspection */- Read upRead up
- Exclude checks
UnusedPrivateMethod
Since: 0.2
Unused Private Method detects when a private method is declared but is unused.
Example
class Something
{
private function foo() {} // unused
}Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod
The variable $parsed_url is not named in camelCase. Open
Open
public function init(): void
{
$parsed_url = parse_url(filter_input(INPUT_SERVER, 'REQUEST_URI', FILTER_SANITIZE_URL));
if (isset($parsed_url['path'])) {
$this->path = trim($parsed_url['path']);- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $header_array is not named in camelCase. Open
Open
public function headers(array $header_array): void
{
foreach ($header_array as $header => $value) {
$this->header($header, $value);
}- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $base_path is not named in camelCase. Open
Open
public function setBasepath(string $base_path = ''): void
{
$this->registry->set('basepath', $base_path);
}- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $parsed_url is not named in camelCase. Open
Open
public function init(): void
{
$parsed_url = parse_url(filter_input(INPUT_SERVER, 'REQUEST_URI', FILTER_SANITIZE_URL));
if (isset($parsed_url['path'])) {
$this->path = trim($parsed_url['path']);- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $parsed_url is not named in camelCase. Open
Open
public function init(): void
{
$parsed_url = parse_url(filter_input(INPUT_SERVER, 'REQUEST_URI', FILTER_SANITIZE_URL));
if (isset($parsed_url['path'])) {
$this->path = trim($parsed_url['path']);- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}