Sign upLogin

JLBoor/generator-jlb-angular

View on GitHub
Star

Showing 42 of 42 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

describe('The userDetailsController, ', function () {

    var user;

    var userRestService;
Severity: Major
Found in app/templates/skeleton/app/modules/user/details/_tests/user-details-controller.spec.js and 1 other location - About 4 days to fix
app/templates/skeleton/app/modules/company/details/_tests/company-details-controller.spec.js on lines 1..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 684.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

describe('The companyDetailsController, ', function () {

    var company;

    var companyRestService;
Severity: Major
Found in app/templates/skeleton/app/modules/company/details/_tests/company-details-controller.spec.js and 1 other location - About 4 days to fix
app/templates/skeleton/app/modules/user/details/_tests/user-details-controller.spec.js on lines 1..91

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 684.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function exports has 227 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function (grunt) {

    // load all grunt tasks
    require('load-grunt-tasks')(grunt);
Severity: Major
Found in app/templates/skeleton/Gruntfile.js - About 1 day to fix

    Function askForDir has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.askForDir = function(type,that,module,ownDir,cb){

    that.module = module;
    that.appname = module.name;
    that.dir = path.dirname(module.file);
    Severity: Major
    Found in utils.js - About 2 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      describe('<%= _.camelize(name) %>', function() {

  beforeEach(module('<%= appname %>'));

  var scope,compile;
      Severity: Major
      Found in directive/templates/complex/directive-spec.js and 1 other location - About 2 hrs to fix
      directive/templates/simple/directive-spec.js on lines 1..23

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 86.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      describe('<%= _.camelize(name) %>', function() {

  beforeEach(module('<%= appname %>'));

  var scope,compile;
      Severity: Major
      Found in directive/templates/simple/directive-spec.js and 1 other location - About 2 hrs to fix
      directive/templates/complex/directive-spec.js on lines 1..23

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 86.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      File Gruntfile.js has 252 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*jslint node: true */
'use strict';

var pkg = require('./package.json');
var _ = require('./package.json');
      Severity: Minor
      Found in app/templates/skeleton/Gruntfile.js - About 2 hrs to fix

        Function askForDir has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.askForDir = function(type,that,module,ownDir,cb){

    that.module = module;
    that.appname = module.name;
    that.dir = path.dirname(module.file);
        Severity: Minor
        Found in utils.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            it('should implement a get service', function () {
        companyRestService.get(company.id);
        $httpBackend.expectGET(expectedOperationUrl + '/' + company.id).respond();
        $httpBackend.flush();
    });
        Severity: Major
        Found in app/templates/skeleton/app/modules/company/_tests/company-rest-service.spec.js and 1 other location - About 1 hr to fix
        app/templates/skeleton/app/modules/user/_tests/user-rest-service.spec.js on lines 30..34

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 68.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                it('should return true when the identity has the required authority', function () {
            _stateWithAuthorities(['authorityA', 'authorityB']);
            identityService.getIdentity.andReturn({ authorities: ['authorityB']});

            expect(authorityService.hasAuthority()).toBe(false);
        Severity: Major
        Found in app/templates/skeleton/app/modules/configuration/identity/_tests/authority-config.spec.js and 1 other location - About 1 hr to fix
        app/templates/skeleton/app/modules/configuration/identity/_tests/authority-config.spec.js on lines 67..72

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 68.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                it('should return false when the identity does not have the required authority', function () {
            _stateWithAuthorities(['authorityA', 'authorityB']);
            identityService.getIdentity.andReturn({ authorities: ['authorityC']});

            expect(authorityService.hasAuthority()).toBe(false);
        Severity: Major
        Found in app/templates/skeleton/app/modules/configuration/identity/_tests/authority-config.spec.js and 1 other location - About 1 hr to fix
        app/templates/skeleton/app/modules/configuration/identity/_tests/authority-config.spec.js on lines 74..79

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 68.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            it('should implement a get service', function () {
        userRestService.get(user.id);
        $httpBackend.expectGET(userOperationUrl + '/' + user.id).respond();
        $httpBackend.flush();
    });
        Severity: Major
        Found in app/templates/skeleton/app/modules/user/_tests/user-rest-service.spec.js and 1 other location - About 1 hr to fix
        app/templates/skeleton/app/modules/company/_tests/company-rest-service.spec.js on lines 30..34

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 68.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function askFor has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        ServiceGenerator.prototype.askFor = function askFor() {
    var cb = this.async();
    var that = this;

    var prompts = [{
        Severity: Minor
        Found in service/index.js - About 1 hr to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              it('should implement a update service', function () {
        userRestService.update(user);
        $httpBackend.expectPUT(userOperationUrl + '/'  + user.id, user).respond();
        $httpBackend.flush();
    });
          Severity: Major
          Found in app/templates/skeleton/app/modules/user/_tests/user-rest-service.spec.js and 2 other locations - About 1 hr to fix
          app/templates/skeleton/app/modules/company/_tests/company-rest-service.spec.js on lines 42..46
          app/templates/skeleton/app/modules/user/_tests/user-rest-service.spec.js on lines 36..40

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  $stateProvider

            .state('page.company', {
                url: '/company',
                template: '<div ui-view></div>',
          Severity: Major
          Found in app/templates/skeleton/app/modules/company/company-config.js and 1 other location - About 1 hr to fix
          app/templates/skeleton/app/modules/user/user-config.js on lines 8..44

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              it('should implement a create service', function () {
        userRestService.create(user);
        $httpBackend.expectPOST(userOperationUrl + '/' + user.id, user).respond();
        $httpBackend.flush();
    });
          Severity: Major
          Found in app/templates/skeleton/app/modules/user/_tests/user-rest-service.spec.js and 2 other locations - About 1 hr to fix
          app/templates/skeleton/app/modules/company/_tests/company-rest-service.spec.js on lines 42..46
          app/templates/skeleton/app/modules/user/_tests/user-rest-service.spec.js on lines 42..46

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              it('should implement a update service', function () {
        companyRestService.update(company);
        $httpBackend.expectPUT(expectedOperationUrl + '/'  + company.id, company).respond();
        $httpBackend.flush();
    });
          Severity: Major
          Found in app/templates/skeleton/app/modules/company/_tests/company-rest-service.spec.js and 2 other locations - About 1 hr to fix
          app/templates/skeleton/app/modules/user/_tests/user-rest-service.spec.js on lines 36..40
          app/templates/skeleton/app/modules/user/_tests/user-rest-service.spec.js on lines 42..46

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  $stateProvider

            .state('page.user', {
                url: '/user',
                template: '<div ui-view></div>',
          Severity: Major
          Found in app/templates/skeleton/app/modules/user/user-config.js and 1 other location - About 1 hr to fix
          app/templates/skeleton/app/modules/company/company-config.js on lines 8..42

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function exports has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = function (config) {
    config.set({

        // base path that will be used to resolve all patterns (eg. files, exclude)
        basePath: '',
          Severity: Minor
          Found in app/templates/skeleton/karma.conf.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                it('should implement a delete service', function () {
        companyRestService.delete(company);
        $httpBackend.expectDELETE(expectedOperationUrl + '/' + company.id).respond();
        $httpBackend.flush();
    });
            Severity: Major
            Found in app/templates/skeleton/app/modules/company/_tests/company-rest-service.spec.js and 1 other location - About 1 hr to fix
            app/templates/skeleton/app/modules/user/_tests/user-rest-service.spec.js on lines 48..52

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language