Sign upLogin

JPadley18/pydrake

View on GitHub
Star
pydrake/pydrake.py

Summary

Maintainability
A
45 mins
Test Coverage

Function _call_api has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Invalid

    def _call_api(self, region, extension):
        """
        Returns a JSON response object from the Riot Games API.
        This function should only be used internally.
        :param region: The region code of the API server to use. A ValueError
Severity: Minor
Found in pydrake/pydrake.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if self.show_rate_warnings:
                            warnings.warn("Rate Limit exceeded - waiting {} seconds".format(retry), RateLimitWarning)
                        time.sleep(retry)
Severity: Major
Found in pydrake/pydrake.py - About 45 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Invalid

        def get_summoner_matchlist(self, summoner):
        """Retrieves the matchlist (recent match history ~150 games) for the
        given summoner

        :param summoner: The summoner to retrieve match data for
    Severity: Major
    Found in pydrake/pydrake.py and 1 other location - About 1 hr to fix
    pydrake/pydrake.py on lines 154..163

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 39.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Invalid

        def get_match_from_matchlist(self, match):
        """Retrieves the full data for a match from an item in a MatchList object

        :param match: The entry from a MatchList object to retrieve further
            data for
    Severity: Major
    Found in pydrake/pydrake.py and 1 other location - About 1 hr to fix
    pydrake/pydrake.py on lines 144..152

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 39.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status