JS-Tech/resj

View on GitHub

Showing 15 of 15 total issues

Function initialize has 110 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  initialize() {
    const mapElement = this.mapTarget;
    if (!mapElement) {
      console.error("Mapbox HTML element not found.")
      return
Severity: Major
Found in app/javascript/controllers/cards/location_controller.js - About 4 hrs to fix

    Function mapLoaded has 106 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      mapLoaded() {
        const map = this.map;
    
        map.addSource('items', {
          type: "geojson",
    Severity: Major
    Found in app/javascript/controllers/cards/list_controller.js - About 4 hrs to fix

      Function exports has 66 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function(api) {
        var validEnv = ['development', 'test', 'production']
        var currentEnv = api.env()
        var isDevelopmentEnv = api.env('development')
        var isProductionEnv = api.env('production')
      Severity: Major
      Found in babel.config.js - About 2 hrs to fix

        Function initialize has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          initialize() {
            const mapElement = document.getElementById('mapbox');
        
            if (!mapElement) {
              console.error("mapbox html element not found")
        Severity: Minor
        Found in app/javascript/controllers/cards/list_controller.js - About 2 hrs to fix

          Function snapifyTable has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function snapifyTable(snaptable) {
          
            var tableButtons = snaptable.querySelector(".table_buttons"),
                editButton = tableButtons.querySelector("a.edit"),
                deleteButton = tableButtons.querySelector("a.delete"),
          Severity: Minor
          Found in app/javascript/admin/snaptable.js - About 1 hr to fix

            Function getBoundingBox has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

              getBoundingBox(data) {
                var bounds = {}, coords, point, latitude, longitude;
            
                for (var i = 0; i < data.length; i++) {
                  coords = data[i].geometry.coordinates;
            Severity: Minor
            Found in app/javascript/controllers/cards/list_controller.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                const map = new mapboxgl.Map({
                  container: 'mapbox',
                  style: 'mapbox://styles/nkcr/ck4vla6vz2ir81cnya5cl6uog',
                  minZoom: 6,
                  center: [6.637289636687626, 46.60327680658895],
            Severity: Minor
            Found in app/javascript/controllers/cards/location_controller.js and 1 other location - About 40 mins to fix
            app/javascript/controllers/cards/list_controller.js on lines 26..33

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                const map = new mapboxgl.Map({
                  container: 'mapbox',
                  style: 'mapbox://styles/nkcr/ckoxc46cg1eqy17pfcfzq79gx',
                  minZoom: 7,
                  center: [7.1960, 46.6221],
            Severity: Minor
            Found in app/javascript/controllers/cards/list_controller.js and 1 other location - About 40 mins to fix
            app/javascript/controllers/cards/location_controller.js on lines 23..30

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                  context.fillStyle = "rgb(" + rgb[0] + "," + rgb[1] + "," + rgb[2] + ")";
            Severity: Minor
            Found in app/javascript/controllers/cards/location_controller.js and 1 other location - About 35 mins to fix
            app/javascript/controllers/cards/list_controller.js on lines 65..65

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                  context.fillStyle = "rgb(" + rgb[0] + "," + rgb[1] + "," + rgb[2] + ")";
            Severity: Minor
            Found in app/javascript/controllers/cards/list_controller.js and 1 other location - About 35 mins to fix
            app/javascript/controllers/cards/location_controller.js on lines 59..59

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              open() {
                this.containerTarget.style.display = "flex";
                this.openTarget.style.display = "none";
              }
            Severity: Minor
            Found in app/javascript/controllers/header_controller.js and 1 other location - About 35 mins to fix
            app/javascript/controllers/header_controller.js on lines 6..9

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              close() {
                this.containerTarget.style.display = "none";
                this.openTarget.style.display = "block";
              }
            Severity: Minor
            Found in app/javascript/controllers/header_controller.js and 1 other location - About 35 mins to fix
            app/javascript/controllers/header_controller.js on lines 11..14

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method update_with_password has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def update_with_password(current_password, params)
                authenticated = authenticate(current_password)
                assign_attributes(params)
                if valid? && authenticated
                  save
            Severity: Minor
            Found in app/models/user.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def create
                @orator = Orator.new(orator_params)
                @orator.user = current_user if signed_in?
                if @orator.save
                  UserMailer.confirmation(@orator.user).deliver_now unless signed_in?
            Severity: Minor
            Found in app/controllers/orators_controller.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function submit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              async submit() {
                const formData = new FormData(this.formTarget);
                formData.append("card[current_step]", this.data.get("step"));
                try {
                  const res = await fetch(this.formTarget.getAttribute("action"), { method: "PATCH", body: formData });
            Severity: Minor
            Found in app/javascript/controllers/cards/form_controller.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language