Sign upLogin

JamesBrooks/hash_validator

View on GitHub
Star
lib/hash_validator/validators/array_validator.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method validate has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

  def validate(key, value, specification, errors)
    # the first item in specification is always ":array"
    unless specification[0] == :array
      errors[key] = "Wrong array specification. The #{:array} is expected as first item."
      return
Severity: Minor
Found in lib/hash_validator/validators/array_validator.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def validate(key, value, specification, errors)
    # the first item in specification is always ":array"
    unless specification[0] == :array
      errors[key] = "Wrong array specification. The #{:array} is expected as first item."
      return
Severity: Minor
Found in lib/hash_validator/validators/array_validator.rb - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

        return if wrong_keys.size < 1
    Severity: Major
    Found in lib/hash_validator/validators/array_validator.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return
      Severity: Major
      Found in lib/hash_validator/validators/array_validator.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return if array_spec.empty?
        Severity: Major
        Found in lib/hash_validator/validators/array_validator.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return if array_spec.nil? # array specification is optional
          Severity: Major
          Found in lib/hash_validator/validators/array_validator.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return
            Severity: Major
            Found in lib/hash_validator/validators/array_validator.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                  return
              Severity: Major
              Found in lib/hash_validator/validators/array_validator.rb - About 30 mins to fix

                Method should_validate? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  def should_validate?(rhs)
    return false unless rhs.is_a?(Array)
    return false unless rhs.size > 0
    return false unless rhs[0] == :array
                Severity: Minor
                Found in lib/hash_validator/validators/array_validator.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                There are no issues that match your filters.

                Category
                Status