Sign upLogin

JamesonNetworks/Nirodha

View on GitHub
Star

Showing 42 of 42 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        function(cb) {
            logger.log('Entering loop to add css libraries', 7);
            logger.log('CSS Library length: ' + cssfiles.length, 7);
            // Insert references to the new css library files
            var cssincludes = "";
Severity: Major
Found in bin/server.js and 1 other location - About 6 hrs to fix
bin/server.js on lines 220..237

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 172.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        function(cb) {
            logger.log('Entering loop to add js libraries', 7);
            logger.log('JS Library lengths: ' + jsfiles.length, 7);
            // Insert references to the new js library files
            var jsincludes = "";
Severity: Major
Found in bin/server.js and 1 other location - About 6 hrs to fix
bin/server.js on lines 239..256

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 172.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File view.js has 351 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var fs = require('fs');
var logger = require('jslogging');
var async = require('async');
var compressor = require('node-minify');
Severity: Minor
Found in bin/view.js - About 4 hrs to fix

    Function handleRequest has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

    function handleRequest (req, res, rootDirectory, htmlFiles, callback) {
    logger.debug('req.url: ' + req.url);
    // Parse the request url
    var URI = req.url.substring(1, req.url.length);
    logger.log('Requested URI is: ' + URI, 7);
    Severity: Minor
    Found in bin/server.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function generateSupportFilesForDeploy has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

    View.prototype.generateSupportFilesForDeploy = function(type, minify, callback) {
    
    var viewHandle = this;
    if(typeof(this.includes) === 'undefined') {
        throw new Error('Includes was undefined');
    Severity: Minor
    Found in bin/view.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function handleRequest has 80 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function handleRequest (req, res, rootDirectory, htmlFiles, callback) {
    logger.debug('req.url: ' + req.url);
    // Parse the request url
    var URI = req.url.substring(1, req.url.length);
    logger.log('Requested URI is: ' + URI, 7);
    Severity: Major
    Found in bin/server.js - About 3 hrs to fix

      Function create has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

      View.prototype.create = function(callback) {
    var viewname = this.name;
    if(typeof(this.name) === 'undefined' || this.name === '') {
        throw new Error('No view name, did you call view.init with a name?');
    }
      Severity: Minor
      Found in bin/view.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function create has 76 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      View.prototype.create = function(callback) {
    var viewname = this.name;
    if(typeof(this.name) === 'undefined' || this.name === '') {
        throw new Error('No view name, did you call view.init with a name?');
    }
      Severity: Major
      Found in bin/view.js - About 3 hrs to fix

        Function generateSupportFilesForDeploy has 73 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        View.prototype.generateSupportFilesForDeploy = function(type, minify, callback) {
    
    var viewHandle = this;
    if(typeof(this.includes) === 'undefined') {
        throw new Error('Includes was undefined');
        Severity: Major
        Found in bin/view.js - About 2 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  createDefaultJavascript: function(cb) {
            utils.copyFile(nirodhaPath + 'tmpl/defaultView.js', 'custom/js/' + viewname + '.js', function(err) {
                if(err) {
                    cb(err);
                }
          Severity: Major
          Found in bin/view.js and 1 other location - About 2 hrs to fix
          bin/view.js on lines 74..84

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 87.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  createDefaultCSS: function(cb) {
            utils.copyFile(nirodhaPath + 'tmpl/defaultView.css', 'custom/css/' + viewname + '.css', function(err) {
                if(err) {
                    cb(err);
                }
          Severity: Major
          Found in bin/view.js and 1 other location - About 2 hrs to fix
          bin/view.js on lines 63..73

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 87.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function init has 49 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          LibraryManager.prototype.init = function() {

    //debugger;
    if(typeof(this.includes) === 'undefined') {
        this.includes = [];
          Severity: Minor
          Found in bin/libraryManager.js - About 1 hr to fix

            Function exports has 49 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            module.exports = function (args, settings) {
    var nm = require('./nirodhaManager.js');
    nm.setSettings(settings);

    var rootDirectory;
            Severity: Minor
            Found in bin/start.js - About 1 hr to fix

              Function insertLibrariesAt has 48 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function insertLibrariesAt(text, libobject, callback) {

    // logger.log('text dump: ' + JSON.stringify(text));
    logger.debug('libobject dump: ' + JSON.stringify(libobject));
    var start = text.indexOf(libobject.title);
              Severity: Minor
              Found in bin/server.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            utils.copyFile(nirodhaPath + 'tmpl/defaultView.html', viewname + '.html', function(err) {
                if(err) {
                    cb(err);
                }
                else {
                Severity: Major
                Found in bin/view.js and 1 other location - About 1 hr to fix
                bin/view.js on lines 87..95

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 71.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            utils.copyFile(nirodhaPath + 'tmpl/defaultView.json', viewname + '.json', function(err) {
                if(err) {
                    cb(err);
                }
                else {
                Severity: Major
                Found in bin/view.js and 1 other location - About 1 hr to fix
                bin/view.js on lines 53..61

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 71.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function parse has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function parse(res, directory, view, callback) {
    /*
    *   Parse the libraries included in the thtml
    */
    logger.debug('Directory: ' + directory);
                Severity: Minor
                Found in bin/server.js - About 1 hr to fix

                  Function _deploy has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  NirodhaManager.prototype._deploy = function(minify, settings, viewname, callback) {
    var views = [];
    if(typeof(viewname) === 'undefined') {

        logger.debug('No viewname specified!');
                  Severity: Minor
                  Found in bin/nirodhaManager.js - About 1 hr to fix

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                                monitor.on("removed", function (f) {
                logger.log('Removed file ' + f);
                if(!(f.indexOf('deploy/') > -1)) {
                    wm.projectFileChangeEventHandler(f, callback);
                }
                    Severity: Major
                    Found in bin/watch.js and 2 other locations - About 1 hr to fix
                    bin/watch.js on lines 16..21
                    bin/watch.js on lines 22..27

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 68.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                                monitor.on("created", function (f) {
                logger.log('Created file ' + f);
                if(!(f.indexOf('deploy/') > -1)) {
                    wm.projectFileChangeEventHandler(f, callback);
                }
                    Severity: Major
                    Found in bin/watch.js and 2 other locations - About 1 hr to fix
                    bin/watch.js on lines 22..27
                    bin/watch.js on lines 28..33

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 68.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language