Sign upLogin

JamieMason/syncpack

View on GitHub
Star
src/version-group/lib/get-preferred-version.ts

Summary

Maintainability
A
3 hrs
Test Coverage
A
100%

Function compareSemver has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

function compareSemver(a: string, b: string): -1 | 0 | 1 {
  if (a.startsWith('workspace:')) return LT;
  if (b.startsWith('workspace:')) return GT;
  if (a === b) return EQ;
  if (a === '*') return GT;
Severity: Minor
Found in src/version-group/lib/get-preferred-version.ts - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

  if (scoreA < scoreB) return LT;
Severity: Major
Found in src/version-group/lib/get-preferred-version.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

      if (scoreA > scoreB) return GT;
    Severity: Major
    Found in src/version-group/lib/get-preferred-version.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        if (b === '*') return LT;
      Severity: Major
      Found in src/version-group/lib/get-preferred-version.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

          if (gt(cleanA, cleanB)) return GT;
        Severity: Major
        Found in src/version-group/lib/get-preferred-version.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            return EQ;
          Severity: Major
          Found in src/version-group/lib/get-preferred-version.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

              if (lt(cleanA, cleanB)) return LT;
            Severity: Major
            Found in src/version-group/lib/get-preferred-version.ts - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status