Sign upLogin

Jasig/WebproxyPortlet

View on GitHub
Star
src/main/java/org/jasig/portlet/proxy/mvc/portlet/proxy/EditProxyController.java

Summary

Maintainability
B
5 hrs
Test Coverage

Method updatePortlet has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @ActionMapping
    public void updatePortlet(@ModelAttribute("form") ProxyPortletForm form, ActionRequest request,
                              ActionResponse response, @RequestParam(value="Save", required=false) String save)
                              throws PortletModeException {
        if (StringUtils.isNotBlank(save)) {
Severity: Major
Found in src/main/java/org/jasig/portlet/proxy/mvc/portlet/proxy/EditProxyController.java - About 2 hrs to fix

    Method updatePortlet has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        @ActionMapping
    public void updatePortlet(@ModelAttribute("form") ProxyPortletForm form, ActionRequest request,
                              ActionResponse response, @RequestParam(value="Save", required=false) String save)
                              throws PortletModeException {
        if (StringUtils.isNotBlank(save)) {
    Severity: Minor
    Found in src/main/java/org/jasig/portlet/proxy/mvc/portlet/proxy/EditProxyController.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getForm has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public ProxyPortletForm getForm(PortletRequest request) {
        final PortletPreferences preferences = request.getPreferences();
        final ProxyPortletForm form = new ProxyPortletForm();

        form.setContentService(preferences.getValue(ProxyPortletController.CONTENT_SERVICE_KEY, null));
    Severity: Minor
    Found in src/main/java/org/jasig/portlet/proxy/mvc/portlet/proxy/EditProxyController.java - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status