Jellyvision/lateralus

View on GitHub

Showing 8 of 8 total issues

Function delegateLateralusEvents has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

mixins.delegateLateralusEvents = function () {
  this.setupProviders();

  _.each({
      /**
Severity: Minor
Found in src/lateralus.mixins.js - About 1 hr to fix

    Function addComponent has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    mixins.addComponent = function (Component, viewOptions, options) {
      options = options || {};
    
      // If this object belongs to a Lateralus.Component (such as a
      // Lateralus.Component.View or Lateralus.Component.Model), add the new
    Severity: Minor
    Found in src/lateralus.mixins.js - About 1 hr to fix

      Function addComponent has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      mixins.addComponent = function (Component, viewOptions, options) {
        options = options || {};
      
        // If this object belongs to a Lateralus.Component (such as a
        // Lateralus.Component.View or Lateralus.Component.Model), add the new
      Severity: Minor
      Found in src/lateralus.mixins.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function Component has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function Component (lateralus, options, viewOptions, opt_parentComponent) {
      
        /**
         * A reference to the central {@link Lateralus} instance.
         * @member Lateralus.Component#lateralus
      Severity: Minor
      Found in src/lateralus.component.js - About 1 hr to fix

        Function Component has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        function Component (lateralus, options, viewOptions, opt_parentComponent) {
        
          /**
           * A reference to the central {@link Lateralus} instance.
           * @member Lateralus.Component#lateralus
        Severity: Minor
        Found in src/lateralus.component.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function dispose has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        fn.dispose = function () {
          _(this).lateralusDispose(() => {
            if (this.view) {
              this.view.dispose();
            }
        Severity: Minor
        Found in src/lateralus.component.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          output: {
            path: path.join(__dirname, 'dist'),
            publicPath: '/assets/',
            filename: 'lateralus.js',
            library: 'lateralus',
        Severity: Minor
        Found in webpack.config.js and 1 other location - About 30 mins to fix
        webpack.test.config.js on lines 6..13

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          output: {
            path: path.join(__dirname, 'dist'),
            publicPath: '/assets/',
            filename: 'index.js',
            library: 'index',
        Severity: Minor
        Found in webpack.test.config.js and 1 other location - About 30 mins to fix
        webpack.config.js on lines 6..13

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language