Sign upLogin

JiriChara/bavaria-ipsum

View on GitHub
Star

Showing 6 of 6 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            it('generates sentence of given length', function () {
                var i = 500;

                while (i-- > 0) {
                    expect(this.bavariaIpsum.generateSentence(1)).toMatch(
Severity: Major
Found in test/bavaria-ipsum.spec.js and 1 other location - About 2 hrs to fix
test/bavaria-ipsum.spec.js on lines 173..185

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            it('generates given count of sentences', function () {
                var i = 500;

                while (i-- > 0) {
                    expect(this.bavariaIpsum.generateParagraph(1)).toMatch(
Severity: Major
Found in test/bavaria-ipsum.spec.js and 1 other location - About 2 hrs to fix
test/bavaria-ipsum.spec.js on lines 110..122

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function exports has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function (grunt) {
    'use strict';

    var jsFiles = [
        'Gruntfile.js',
Severity: Major
Found in Gruntfile.js - About 2 hrs to fix

    Function generateParagraph has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        generateParagraph: function (length, opts) {
        var sentences = [],
            args = Array.prototype.slice.call(arguments),
            argsLen = args.length,
            i;
    Severity: Minor
    Found in src/bavaria-ipsum.js - About 1 hr to fix

      Function exports has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function(config) {
    'use strict';

    config.set({
      Severity: Minor
      Found in karma.conf.js - About 1 hr to fix

        Function generateParagraph has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            generateParagraph: function (length, opts) {
        var sentences = [],
            args = Array.prototype.slice.call(arguments),
            argsLen = args.length,
            i;
        Severity: Minor
        Found in src/bavaria-ipsum.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language