Sign upLogin

JoeKarlsson/data-structures

View on GitHub
Star
search/binary-search-tree.js

Summary

Maintainability
F
3 days
Test Coverage

Function remove has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

  remove(value) {
    let found = false;
    let childCount;
    let replacement;
    let replacementParent;
Severity: Minor
Found in search/binary-search-tree.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File binary-search-tree.js has 281 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const LinkedList = require('../linked-list/linkedList');

// Private Helper functions
const makeNode = ( value ) => {
  const node = {};
Severity: Minor
Found in search/binary-search-tree.js - About 2 hrs to fix

    Function remove has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      remove(value) {
    let found = false;
    let childCount;
    let replacement;
    let replacementParent;
    Severity: Major
    Found in search/binary-search-tree.js - About 2 hrs to fix

      Function nodeAverages has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        nodeAverages() {
    const node = this.root;
    const result = {};
    const depthAverages = [];
      Severity: Minor
      Found in search/binary-search-tree.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function nodeAverages has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        nodeAverages() {
    const node = this.root;
    const result = {};
    const depthAverages = [];
      Severity: Minor
      Found in search/binary-search-tree.js - About 1 hr to fix

        Function insert has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          insert(currentNode) {
    const value = currentNode.value;

    const traverse = (node) => {
      if (value > node.value) {
        Severity: Minor
        Found in search/binary-search-tree.js - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getDepth has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          getDepth() {
    let maxDepth = 0;
    const node = this.root;
    const traverse = (node, depth) => {
      if ( !node ) return null;
        Severity: Minor
        Found in search/binary-search-tree.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function contains has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          contains(value) {
    const node = this.root;
    const traverse = ( node ) => {
      if (!node) {
        return false;
        Severity: Minor
        Found in search/binary-search-tree.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function countLeaves has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          countLeaves() {
    let count = 0;
    const node = this.root;
    const traverse = ( node ) => {
      if ( !node) {
        Severity: Minor
        Found in search/binary-search-tree.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          breadthFirstLTR() {
    let node = this.root;
    const queue = [node];
    const result = [];
    while (node) {
        Severity: Major
        Found in search/binary-search-tree.js and 1 other location - About 4 hrs to fix
        search/binary-search-tree.js on lines 289..300

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 117.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          breadthFirstRTL() {
    let node = this.root;
    const queue = [node];
    const result = [];
    while (node) {
        Severity: Major
        Found in search/binary-search-tree.js and 1 other location - About 4 hrs to fix
        search/binary-search-tree.js on lines 276..287

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 117.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          findMin() {
    const node = this.root;
    const traverse = ( node ) => {
      return !node.left ? node.value : traverse( node.left );
    };
        Severity: Major
        Found in search/binary-search-tree.js and 1 other location - About 1 hr to fix
        search/binary-search-tree.js on lines 194..200

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          findMax() {
    const node = this.root;
    const traverse = ( node ) => {
      return !node.right ? node.value : traverse( node.right );
    };
        Severity: Major
        Found in search/binary-search-tree.js and 1 other location - About 1 hr to fix
        search/binary-search-tree.js on lines 185..191

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status