Sign upLogin

JohnCoates/Aerial

View on GitHub
Star
Aerial/Source/Models/Hardware/HardwareDetection.swift

Summary

Maintainability
C
1 day
Test Coverage

Function getSuggestedFormat has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    func getSuggestedFormat() -> VideoFormat {
        switch isHEVCMain10HWDecodingAvailable() {
        case .supported:
            if #available(OSX 10.15, *) {
                return .v4KHDR
Severity: Minor
Found in Aerial/Source/Models/Hardware/HardwareDetection.swift - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getSuggestedFormat has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    func getSuggestedFormat() -> VideoFormat {
        switch isHEVCMain10HWDecodingAvailable() {
        case .supported:
            if #available(OSX 10.15, *) {
                return .v4KHDR
Severity: Minor
Found in Aerial/Source/Models/Hardware/HardwareDetection.swift - About 1 hr to fix

    Function isHEVCMain10HWDecodingAvailable has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        func isHEVCMain10HWDecodingAvailable() -> HEVCMain10Support {
        let macModel = getMacModel()

        // Apple silicon supports everything!
        if isAppleSilicon() {
    Severity: Minor
    Found in Aerial/Source/Models/Hardware/HardwareDetection.swift - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                return getHEVCMain10Support(macModel: macModel, macSubmodel: "MacBookAir", partial: 8.0, full: 8.0)
    Severity: Major
    Found in Aerial/Source/Models/Hardware/HardwareDetection.swift - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return getHEVCMain10Support(macModel: macModel, macSubmodel: "MacBook", partial: 9.0, full: 10.0)
      Severity: Major
      Found in Aerial/Source/Models/Hardware/HardwareDetection.swift - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return getHEVCMain10Support(macModel: macModel, macSubmodel: "Macmini", partial: 8.0, full: 8.0)
        Severity: Major
        Found in Aerial/Source/Models/Hardware/HardwareDetection.swift - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return .v1080pH264
          Severity: Major
          Found in Aerial/Source/Models/Hardware/HardwareDetection.swift - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return .v1080pH264
            Severity: Major
            Found in Aerial/Source/Models/Hardware/HardwareDetection.swift - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return getHEVCMain10Support(macModel: macModel, macSubmodel: "MacPro", partial: 7.0, full: 7.0)
              Severity: Major
              Found in Aerial/Source/Models/Hardware/HardwareDetection.swift - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return .unsure
                Severity: Major
                Found in Aerial/Source/Models/Hardware/HardwareDetection.swift - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                      return .v1080pH264
                  Severity: Major
                  Found in Aerial/Source/Models/Hardware/HardwareDetection.swift - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                        return .v1080pHEVC
                    Severity: Major
                    Found in Aerial/Source/Models/Hardware/HardwareDetection.swift - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                      return .v1080pH264
                      Severity: Major
                      Found in Aerial/Source/Models/Hardware/HardwareDetection.swift - About 30 mins to fix

                        Function isAppleSilicon has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            func isAppleSilicon() -> Bool {
        if #available(macOS 12, *) {
            var systeminfo = utsname()
            uname(&systeminfo)
            let machine = withUnsafeBytes(of: &systeminfo.machine) {bufPtr->String in
                        Severity: Minor
                        Found in Aerial/Source/Models/Hardware/HardwareDetection.swift - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                    } else if macModel.starts(with: "MacBookPro") {
                let ver = extractMacVersion(macModel: macModel, macSubmodel: "MacBookPro")
                // MacBookPro full 14+
                if ver >= 17.0 {
                    return .v1080pHEVC
                        Severity: Minor
                        Found in Aerial/Source/Models/Hardware/HardwareDetection.swift and 1 other location - About 30 mins to fix
                        Aerial/Source/Models/Hardware/HardwareDetection.swift on lines 60..82

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 40.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                    if macModel.starts(with: "iMac") {
                // iMacs, as far as we know, partial 17+, full 18+
                let ver = extractMacVersion(macModel: macModel, macSubmodel: "iMac")
                if ver >= 17.0 {
                    return .v4KHEVC
                        Severity: Minor
                        Found in Aerial/Source/Models/Hardware/HardwareDetection.swift and 1 other location - About 30 mins to fix
                        Aerial/Source/Models/Hardware/HardwareDetection.swift on lines 68..82

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 40.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status