Sign upLogin

JohnCoates/Aerial

View on GitHub
Star
Aerial/Source/Models/Hardware/NightShift.swift

Summary

Maintainability
B
6 hrs
Test Coverage

Function getInformation has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    static func getInformation() -> (Bool, sunrise: Date?, sunset: Date?, error: String?) {
        // Sonoma workaround
        if !Aerial.helper.underCompanion {
            if #available(macOS 14.0, *) {
                if CompanionBridge.nightShiftSunrise != nil {
Severity: Minor
Found in Aerial/Source/Models/Hardware/NightShift.swift - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getInformation has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    static func getInformation() -> (Bool, sunrise: Date?, sunset: Date?, error: String?) {
        // Sonoma workaround
        if !Aerial.helper.underCompanion {
            if #available(macOS 14.0, *) {
                if CompanionBridge.nightShiftSunrise != nil {
Severity: Minor
Found in Aerial/Source/Models/Hardware/NightShift.swift - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

                return (true, sunrise, sunset, nil)
    Severity: Major
    Found in Aerial/Source/Models/Hardware/NightShift.swift - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return (false, nil, nil, "Location services may be disabled")
      Severity: Major
      Found in Aerial/Source/Models/Hardware/NightShift.swift - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return (false, nil, nil, "Your Mac does not support Night Shift")
        Severity: Major
        Found in Aerial/Source/Models/Hardware/NightShift.swift - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status