JohnCoates/Aerial

View on GitHub
Aerial/Source/Models/Locations.swift

Summary

Maintainability
B
4 hrs
Test Coverage

Function getCoordinates has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    func getCoordinates(failure: @escaping (_ error: String) -> Void,
                        success: @escaping (_ response: CLLocationCoordinate2D) -> Void) {
        // Sonoma workaround via CompanionBridge
        if !Aerial.helper.underCompanion {
            if #available(macOS 14.0, *) {
Severity: Minor
Found in Aerial/Source/Models/Locations.swift - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getCoordinates has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    func getCoordinates(failure: @escaping (_ error: String) -> Void,
                        success: @escaping (_ response: CLLocationCoordinate2D) -> Void) {
        // Sonoma workaround via CompanionBridge
        if !Aerial.helper.underCompanion {
            if #available(macOS 14.0, *) {
Severity: Minor
Found in Aerial/Source/Models/Locations.swift - About 1 hr to fix

    Function locationManager has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        func locationManager(_ manager: CLLocationManager, didChangeAuthorization status: CLAuthorizationStatus) {
            debugLog("LMauth status change : \(status.rawValue)")
            if status == .denied {
                if PrefsTime.cachedLatitude != 0 {
                    debugLog("Couldn't retrieve your location, using latest cached coordinates instead")
    Severity: Minor
    Found in Aerial/Source/Models/Locations.swift - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function locationManager has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        func locationManager(_ manager: CLLocationManager, didFailWithError error: Error) {
            // So we failed, but maybe we have something cached to pretent we didn't fail
            if PrefsTime.cachedLatitude != 0 {
                debugLog("Couldn't retrieve your location: \(error.localizedDescription), using latest cached coordinates instead")
                // Store them
    Severity: Minor
    Found in Aerial/Source/Models/Locations.swift - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status