JohnCoates/Aerial

View on GitHub
Aerial/Source/Models/Sources/SourceList.swift

Summary

Maintainability
D
3 days
Test Coverage

File SourceList.swift has 379 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Foundation

struct SourceHeader {
    let name: String
    let sources: [Source]
Severity: Minor
Found in Aerial/Source/Models/Sources/SourceList.swift - About 5 hrs to fix

    Function updateLocalSource has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        static func updateLocalSource(source: Source, reload: Bool) {
            // We need the raw manifest to find the path inside
            let videos = source.getUnprocessedVideos()
            let originalAssets = source.getUnprocessedAssets()
    
    
    Severity: Minor
    Found in Aerial/Source/Models/Sources/SourceList.swift - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function fetchOnlineManifest has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        static func fetchOnlineManifest(url: URL) {
            if let source = loadManifest(url: url) {
                debugLog("Source loaded")
                // Then save !
                let downloadManager = DownloadManager()
    Severity: Major
    Found in Aerial/Source/Models/Sources/SourceList.swift - About 2 hrs to fix

      Function fetchOnlineManifest has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          static func fetchOnlineManifest(url: URL) {
              if let source = loadManifest(url: url) {
                  debugLog("Source loaded")
                  // Then save !
                  let downloadManager = DownloadManager()
      Severity: Minor
      Found in Aerial/Source/Models/Sources/SourceList.swift - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function processPathForVideos has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          static func processPathForVideos(url: URL) {
              debugLog("processing url for videos : \(url) ")
              let folderName = url.lastPathComponent
      
              do {
      Severity: Minor
      Found in Aerial/Source/Models/Sources/SourceList.swift - About 1 hr to fix

        Function updateLocalSource has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            static func updateLocalSource(source: Source, reload: Bool) {
                // We need the raw manifest to find the path inside
                let videos = source.getUnprocessedVideos()
                let originalAssets = source.getUnprocessedAssets()
        
        
        Severity: Minor
        Found in Aerial/Source/Models/Sources/SourceList.swift - About 1 hr to fix

          Function categorizedSourceList has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              static func categorizedSourceList() -> [SourceHeader] {
                  var communities: [Source] = []
                  var online: [Source] = []
                  var local: [Source] = []
                  var apple: [Source] = []
          Severity: Minor
          Found in Aerial/Source/Models/Sources/SourceList.swift - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function categorizedSourceList has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              static func categorizedSourceList() -> [SourceHeader] {
                  var communities: [Source] = []
                  var online: [Source] = []
                  var local: [Source] = []
                  var apple: [Source] = []
          Severity: Minor
          Found in Aerial/Source/Models/Sources/SourceList.swift - About 1 hr to fix

            Function processPathForVideos has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                static func processPathForVideos(url: URL) {
                    debugLog("processing url for videos : \(url) ")
                    let folderName = url.lastPathComponent
            
                    do {
            Severity: Minor
            Found in Aerial/Source/Models/Sources/SourceList.swift - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function loadMetaManifest has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                static func loadMetaManifest(url: URL) -> [Source]? {
                    // Let's make sure we have the required files
                    if !areManifestPresent(url: url) && !url.absoluteString.starts(with: "http") {
                        return nil
                    }
            Severity: Minor
            Found in Aerial/Source/Models/Sources/SourceList.swift - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function parseSourceFromManifest has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                static private func parseSourceFromManifest(_ manifest: Manifest, url: URL?) -> Source {
                    var local = true
                    var mURL: String
                    if let isLocal = manifest.local {
                        local = isLocal
            Severity: Minor
            Found in Aerial/Source/Models/Sources/SourceList.swift - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        for lurl in urls {
                            if lurl.path.lowercased().hasSuffix(".mp4") || lurl.path.lowercased().hasSuffix(".mov") {
                                assets.append(VideoAsset(accessibilityLabel: folderName,
                                                         id: NSUUID().uuidString,
                                                         title: lurl.lastPathComponent,
            Severity: Major
            Found in Aerial/Source/Models/Sources/SourceList.swift and 1 other location - About 1 hr to fix
            Aerial/Source/Controllers/CustomVideoController.swift on lines 182..200

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 114.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    do {
                        try json!.write(to: URL(fileURLWithPath:
                                                Cache.supportPath.appending("/"+source.name+"/manifest.json")))
                    } catch {
                        errorLog("Can't save local source : \(error.localizedDescription)")
            Severity: Minor
            Found in Aerial/Source/Models/Sources/SourceList.swift and 1 other location - About 50 mins to fix
            Aerial/Source/Models/Sources/SourceList.swift on lines 386..391

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    do {
                        try json!.write(to: URL(fileURLWithPath:
                                                Cache.supportPath.appending("/"+source.name+"/entries.json")))
                    } catch {
                        errorLog("Can't save local entries : \(error.localizedDescription)")
            Severity: Minor
            Found in Aerial/Source/Models/Sources/SourceList.swift and 1 other location - About 50 mins to fix
            Aerial/Source/Models/Sources/SourceList.swift on lines 375..380

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                static let macOS14 = Source(name: "macOS 14",
                                    description: "High framerate videos from macOS 14 Sonoma",
                                    manifestUrl: "https://sylvan.apple.com/itunes-assets/Aerials126/v4/82/2e/34/822e344c-f5d2-878c-3d56-508d5b09ed61/resources-14-0-10.tar",
                                    type: .macOS,
                                    scenes: [.nature, .city, .space, .sea],
            Severity: Minor
            Found in Aerial/Source/Models/Sources/SourceList.swift and 2 other locations - About 30 mins to fix
            Aerial/Source/Models/Sources/SourceList.swift on lines 29..36
            Aerial/Source/Models/Sources/SourceList.swift on lines 39..46

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 40.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                static let tvOS13 = Source(name: "tvOS 13",
                                    description: "Apple TV screensavers from tvOS 13",
                                    manifestUrl: "https://sylvan.apple.com/Aerials/resources-13.tar",
                                    type: .tvOS12,
                                    scenes: [.nature, .city, .space, .sea],
            Severity: Minor
            Found in Aerial/Source/Models/Sources/SourceList.swift and 2 other locations - About 30 mins to fix
            Aerial/Source/Models/Sources/SourceList.swift on lines 19..26
            Aerial/Source/Models/Sources/SourceList.swift on lines 29..36

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 40.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                static let tvOS16 = Source(name: "tvOS 16",
                                    description: "Apple TV screensavers from tvOS 16",
                                    manifestUrl: "https://sylvan.apple.com/Aerials/resources-16.tar",
                                    type: .tvOS12,
                                    scenes: [.nature, .city, .space, .sea],
            Severity: Minor
            Found in Aerial/Source/Models/Sources/SourceList.swift and 2 other locations - About 30 mins to fix
            Aerial/Source/Models/Sources/SourceList.swift on lines 19..26
            Aerial/Source/Models/Sources/SourceList.swift on lines 39..46

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 40.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Multiline comment should end with whitespace
            Open

                                    more: "")*/

            comment-whitespace

            Prefer at least one whitespace character after a comment opening symbol (//, ///, /*, or /**) and at least one whitespace character before a comment closing symbol (*/).

            Preferred

            // This is a comment
            
            /// This is a documentation comment
            
            /* This is a
            multi-line comment */
            
            /* This is a
            multi-line comment
            */
            
            /** This is a
            documentation multi-line
            comment
            */

            Not Preferred

            //This is a comment
            
            ///This is a documentation comment
            
            /*This is a
            multi-line comment*/
            
            /**This is a multi-line
            documentation comment */

            Closure is the function's final argument and may be passed as a trailing closure instead
            Open

                                                 scenes: source.scenes.map({ $0.rawValue }),

            trailing-closure

            Closures that are the last argument of a function should be passed into the function using trailing closure syntax.

            Preferred

            reversed = names.sort { s1, s2 in return s1 > s2 }

            Not Preferred

            reversed = names.sort({ s1, s2 in return s1 > s2 })

            Multiline comment should end with whitespace
            Open

                                    more: "")*/

            comment-whitespace

            Prefer at least one whitespace character after a comment opening symbol (//, ///, /*, or /**) and at least one whitespace character before a comment closing symbol (*/).

            Preferred

            // This is a comment
            
            /// This is a documentation comment
            
            /* This is a
            multi-line comment */
            
            /* This is a
            multi-line comment
            */
            
            /** This is a
            documentation multi-line
            comment
            */

            Not Preferred

            //This is a comment
            
            ///This is a documentation comment
            
            /*This is a
            multi-line comment*/
            
            /**This is a multi-line
            documentation comment */

            Line should not have any trailing whitespace
            Open

                            

            trailing-whitespace

            Flag whitespace after the last non-whitespace character on each line until the newline.

            Preferred

            let number = 42¬

            Not Preferred

            let number = 42••¬

            Multiline comment should start with whitespace
            Open

                /*static let tvOS12 = Source(name: "tvOS 12",

            comment-whitespace

            Prefer at least one whitespace character after a comment opening symbol (//, ///, /*, or /**) and at least one whitespace character before a comment closing symbol (*/).

            Preferred

            // This is a comment
            
            /// This is a documentation comment
            
            /* This is a
            multi-line comment */
            
            /* This is a
            multi-line comment
            */
            
            /** This is a
            documentation multi-line
            comment
            */

            Not Preferred

            //This is a comment
            
            ///This is a documentation comment
            
            /*This is a
            multi-line comment*/
            
            /**This is a multi-line
            documentation comment */

            Function should have at least one blank line after it
            Open

                }

            function-whitespace

            Every function and method declaration should have one blank line before and after itself. An exception to this rule are functions that are declared at the start of a file (only need one blank line after their declaration) or at the end of a file (only need one blank line before their declaration). Comments immediately before a function declaration (no blank lines between them and the function) are considered to be part of the declaration.

            Preferred

            func function1() {
              var text = 1
              var text = 2
            }
            
            function1()
            
            // a comment
            func function2() {
              // something goes here
            }
            
            struct SomeStruct {
            
              func function3() {
                // something goes here
              }
            
              func function4() {
                // something else goes here
              };
            
            }
            
            func function5() {
              // something goes here
            }

            Not Preferred

            func function1() {
              var text = 1
              var text = 2
            }
            function1()
            // a comment
            func function2() {
              // something goes here
            }
            
            struct SomeStruct {
              func function3() {
                // something goes here
              }
            
              func function4() {
                // something else goes here
              };
            }
            func function5() {
              // something goes here
            }

            Line should not have any trailing whitespace
            Open

                            

            trailing-whitespace

            Flag whitespace after the last non-whitespace character on each line until the newline.

            Preferred

            let number = 42¬

            Not Preferred

            let number = 42••¬

            Function should have at least one blank line before it
            Open

                static func loadMetaManifest(url: URL) -> [Source]? {

            function-whitespace

            Every function and method declaration should have one blank line before and after itself. An exception to this rule are functions that are declared at the start of a file (only need one blank line after their declaration) or at the end of a file (only need one blank line before their declaration). Comments immediately before a function declaration (no blank lines between them and the function) are considered to be part of the declaration.

            Preferred

            func function1() {
              var text = 1
              var text = 2
            }
            
            function1()
            
            // a comment
            func function2() {
              // something goes here
            }
            
            struct SomeStruct {
            
              func function3() {
                // something goes here
              }
            
              func function4() {
                // something else goes here
              };
            
            }
            
            func function5() {
              // something goes here
            }

            Not Preferred

            func function1() {
              var text = 1
              var text = 2
            }
            function1()
            // a comment
            func function2() {
              // something goes here
            }
            
            struct SomeStruct {
              func function3() {
                // something goes here
              }
            
              func function4() {
                // something else goes here
              };
            }
            func function5() {
              // something goes here
            }

            Line should not have any trailing whitespace
            Open

                    

            trailing-whitespace

            Flag whitespace after the last non-whitespace character on each line until the newline.

            Preferred

            let number = 42¬

            Not Preferred

            let number = 42••¬

            There are no issues that match your filters.

            Category
            Status