Sign upLogin

JohnCoates/Aerial

View on GitHub
Star
Aerial/Source/Views/AerialView+Brightness.swift

Summary

Maintainability
B
4 hrs
Test Coverage

Function setDimTimers has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    func setDimTimers() {
        if #available(OSX 10.12, *) {
            let timeManagement = TimeManagement.sharedInstance
            let startValue = min(PrefsDisplays.startDim, Double(brightnessToRestore!))
Severity: Minor
Found in Aerial/Source/Views/AerialView+Brightness.swift - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function checkIfShouldSetBrightness has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    func checkIfShouldSetBrightness() {
        
        let timeManagement = TimeManagement.sharedInstance

        if PrefsDisplays.dimBrightness && !isPreview && brightnessToRestore == nil {
Severity: Minor
Found in Aerial/Source/Views/AerialView+Brightness.swift - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setDimTimers has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    func setDimTimers() {
        if #available(OSX 10.12, *) {
            let timeManagement = TimeManagement.sharedInstance
            let startValue = min(PrefsDisplays.startDim, Double(brightnessToRestore!))
Severity: Minor
Found in Aerial/Source/Views/AerialView+Brightness.swift - About 1 hr to fix

    Function should have at least one blank line before it
    Open

        func checkIfShouldSetBrightness() {
    Severity: Minor
    Found in Aerial/Source/Views/AerialView+Brightness.swift by tailor

    function-whitespace

    Every function and method declaration should have one blank line before and after itself. An exception to this rule are functions that are declared at the start of a file (only need one blank line after their declaration) or at the end of a file (only need one blank line before their declaration). Comments immediately before a function declaration (no blank lines between them and the function) are considered to be part of the declaration.

    Preferred

    func function1() {
  var text = 1
  var text = 2
}

function1()

// a comment
func function2() {
  // something goes here
}

struct SomeStruct {

  func function3() {
    // something goes here
  }

  func function4() {
    // something else goes here
  };

}

func function5() {
  // something goes here
}

    Not Preferred

    func function1() {
  var text = 1
  var text = 2
}
function1()
// a comment
func function2() {
  // something goes here
}

struct SomeStruct {
  func function3() {
    // something goes here
  }

  func function4() {
    // something else goes here
  };
}
func function5() {
  // something goes here
}

    Line should not have any trailing whitespace
    Open
    Severity: Minor
    Found in Aerial/Source/Views/AerialView+Brightness.swift by tailor

    trailing-whitespace

    Flag whitespace after the last non-whitespace character on each line until the newline.

    Preferred

    let number = 42¬

    Not Preferred

    let number = 42••¬

    Function should have at least one blank line after it
    Open

        }
    Severity: Minor
    Found in Aerial/Source/Views/AerialView+Brightness.swift by tailor

    function-whitespace

    Every function and method declaration should have one blank line before and after itself. An exception to this rule are functions that are declared at the start of a file (only need one blank line after their declaration) or at the end of a file (only need one blank line before their declaration). Comments immediately before a function declaration (no blank lines between them and the function) are considered to be part of the declaration.

    Preferred

    func function1() {
  var text = 1
  var text = 2
}

function1()

// a comment
func function2() {
  // something goes here
}

struct SomeStruct {

  func function3() {
    // something goes here
  }

  func function4() {
    // something else goes here
  };

}

func function5() {
  // something goes here
}

    Not Preferred

    func function1() {
  var text = 1
  var text = 2
}
function1()
// a comment
func function2() {
  // something goes here
}

struct SomeStruct {
  func function3() {
    // something goes here
  }

  func function4() {
    // something else goes here
  };
}
func function5() {
  // something goes here
}

    There are no issues that match your filters.

    Category
    Status