Sign upLogin

JohnCoates/Aerial

View on GitHub
Star
Resources/MainUI/Settings panels/AdvancedViewController.swift

Summary

Maintainability
C
1 day
Test Coverage

Function viewDidLoad has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    override func viewDidLoad() {
        super.viewDidLoad()

        DispatchQueue.main.async {
            self.scrollView.contentView.scroll(NSMakePoint(0,0))
Severity: Minor
Found in Resources/MainUI/Settings panels/AdvancedViewController.swift - About 1 hr to fix

    Function viewDidLoad has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        override func viewDidLoad() {
        super.viewDidLoad()

        DispatchQueue.main.async {
            self.scrollView.contentView.scroll(NSMakePoint(0,0))
    Severity: Minor
    Found in Resources/MainUI/Settings panels/AdvancedViewController.swift - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function setupPopover has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        func setupPopover() {
        // Help popover, GVA detection requires 10.13
        if #available(OSX 10.13, *) {
            if !VTIsHardwareDecodeSupported(kCMVideoCodecType_H264) {
                popoverH264Label.stringValue = "H264 acceleration not supported"
    Severity: Minor
    Found in Resources/MainUI/Settings panels/AdvancedViewController.swift - About 1 hr to fix

      Function setupPopover has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          func setupPopover() {
        // Help popover, GVA detection requires 10.13
        if #available(OSX 10.13, *) {
            if !VTIsHardwareDecodeSupported(kCMVideoCodecType_H264) {
                popoverH264Label.stringValue = "H264 acceleration not supported"
      Severity: Minor
      Found in Resources/MainUI/Settings panels/AdvancedViewController.swift - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function resetAllSettings has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          @IBAction func resetAllSettings(_ sender: NSButton) {
        if Aerial.helper.showAlert(
            question: "Reset all settings?",
            text: "This will reset all your settings. After they are reset, Aerial will close System Preferences, you will have to reload it to access settings again.\n\nAre you sure you want to reset your settings?",
            button1: "Reset my settings",
      Severity: Minor
      Found in Resources/MainUI/Settings panels/AdvancedViewController.swift - About 1 hr to fix

        Function resetAllSettings has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            @IBAction func resetAllSettings(_ sender: NSButton) {
        if Aerial.helper.showAlert(
            question: "Reset all settings?",
            text: "This will reset all your settings. After they are reset, Aerial will close System Preferences, you will have to reload it to access settings again.\n\nAre you sure you want to reset your settings?",
            button1: "Reset my settings",
        Severity: Minor
        Found in Resources/MainUI/Settings panels/AdvancedViewController.swift - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 17 locations. Consider refactoring.
        Open

            @IBAction func dolbyVisionClick(_ sender: Any) {
        let workspace = NSWorkspace.shared
        let url = URL(string: "https://en.wikipedia.org/wiki/Dolby_Laboratories#Video_processing")!
        workspace.open(url)
    }
        Severity: Major
        Found in Resources/MainUI/Settings panels/AdvancedViewController.swift and 16 other locations - About 35 mins to fix
        Resources/MainUI/First time setup/RecapViewController.swift on lines 24..28
        Resources/MainUI/First time setup/RecapViewController.swift on lines 30..34
        Resources/MainUI/First time setup/TimeSetupViewController.swift on lines 105..109
        Resources/MainUI/First time setup/VideoFormatViewController.swift on lines 59..63
        Resources/MainUI/Infos panels/CreditsViewController.swift on lines 21..25
        Resources/MainUI/Infos panels/CreditsViewController.swift on lines 27..31
        Resources/MainUI/Infos panels/CreditsViewController.swift on lines 33..37
        Resources/MainUI/Infos panels/CreditsViewController.swift on lines 39..43
        Resources/MainUI/Infos panels/HelpViewController.swift on lines 18..22
        Resources/MainUI/Infos panels/HelpViewController.swift on lines 24..28
        Resources/MainUI/Infos panels/HelpViewController.swift on lines 30..34
        Resources/MainUI/Infos panels/HelpViewController.swift on lines 36..40
        Resources/MainUI/Infos panels/InfoViewController.swift on lines 21..25
        Resources/MainUI/Infos panels/InfoViewController.swift on lines 27..31
        Resources/MainUI/Settings panels/AdvancedViewController.swift on lines 301..305
        Resources/MainUI/Settings panels/SourcesViewController.swift on lines 116..120

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 17 locations. Consider refactoring.
        Open

            @IBAction func projectPageClick(_ sender: Any) {
        let workspace = NSWorkspace.shared
        let url = URL(string: "https://github.com/JohnCoates/Aerial/blob/master/Documentation/HardwareDecoding.md")!
        workspace.open(url)
    }
        Severity: Major
        Found in Resources/MainUI/Settings panels/AdvancedViewController.swift and 16 other locations - About 35 mins to fix
        Resources/MainUI/First time setup/RecapViewController.swift on lines 24..28
        Resources/MainUI/First time setup/RecapViewController.swift on lines 30..34
        Resources/MainUI/First time setup/TimeSetupViewController.swift on lines 105..109
        Resources/MainUI/First time setup/VideoFormatViewController.swift on lines 59..63
        Resources/MainUI/Infos panels/CreditsViewController.swift on lines 21..25
        Resources/MainUI/Infos panels/CreditsViewController.swift on lines 27..31
        Resources/MainUI/Infos panels/CreditsViewController.swift on lines 33..37
        Resources/MainUI/Infos panels/CreditsViewController.swift on lines 39..43
        Resources/MainUI/Infos panels/HelpViewController.swift on lines 18..22
        Resources/MainUI/Infos panels/HelpViewController.swift on lines 24..28
        Resources/MainUI/Infos panels/HelpViewController.swift on lines 30..34
        Resources/MainUI/Infos panels/HelpViewController.swift on lines 36..40
        Resources/MainUI/Infos panels/InfoViewController.swift on lines 21..25
        Resources/MainUI/Infos panels/InfoViewController.swift on lines 27..31
        Resources/MainUI/Settings panels/AdvancedViewController.swift on lines 295..299
        Resources/MainUI/Settings panels/SourcesViewController.swift on lines 116..120

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                DispatchQueue.main.async {
            self.firstSetupWindowController!.windowDidLoad()
            self.firstSetupWindowController!.showWindow(self)
            self.firstSetupWindowController!.window!.makeKeyAndOrderFront(self)
        }
        Severity: Minor
        Found in Resources/MainUI/Settings panels/AdvancedViewController.swift and 1 other location - About 35 mins to fix
        Resources/MainUI/PanelWindowController.swift on lines 132..136

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status