Sign upLogin

JohnCoates/Aerial

View on GitHub
Star
Resources/MainUI/Settings panels/CacheViewController.swift

Summary

Maintainability
C
1 day
Test Coverage

Function updateCacheBox has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    func updateCacheBox() {
        let usedCache = Cache.size()
        let packsSize = Cache.packsSize()

        //print("pack size : \(packsSize)")
Severity: Minor
Found in Resources/MainUI/Settings panels/CacheViewController.swift - About 1 hr to fix

    Function updateCacheBox has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        func updateCacheBox() {
        let usedCache = Cache.size()
        let packsSize = Cache.packsSize()

        //print("pack size : \(packsSize)")
    Severity: Minor
    Found in Resources/MainUI/Settings panels/CacheViewController.swift - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function pickFolderButton has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @IBAction func pickFolderButton(_ sender: Any) {
        let openPanel = NSOpenPanel()

        openPanel.canChooseDirectories = true
        openPanel.canChooseFiles = false
    Severity: Minor
    Found in Resources/MainUI/Settings panels/CacheViewController.swift - About 1 hr to fix

      Function pickFolderButton has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          @IBAction func pickFolderButton(_ sender: Any) {
        let openPanel = NSOpenPanel()

        openPanel.canChooseDirectories = true
        openPanel.canChooseFiles = false
      Severity: Minor
      Found in Resources/MainUI/Settings panels/CacheViewController.swift - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function updateNetworkStatus has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          func updateNetworkStatus() {
        if PrefsCache.restrictOnWiFi {
            connectedIcon.isHidden = false
            connectedLabel.isHidden = false
            addCurrentNetworkButton.isHidden = false
      Severity: Minor
      Found in Resources/MainUI/Settings panels/CacheViewController.swift - About 1 hr to fix

        Function updateNetworkStatus has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            func updateNetworkStatus() {
        if PrefsCache.restrictOnWiFi {
            connectedIcon.isHidden = false
            connectedLabel.isHidden = false
            addCurrentNetworkButton.isHidden = false
        Severity: Minor
        Found in Resources/MainUI/Settings panels/CacheViewController.swift - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function viewDidLoad has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            override func viewDidLoad() {
        super.viewDidLoad()

        DispatchQueue.main.async {
            self.makeTimeMachineIgnore.state = TimeMachine.isExcluded() ? .on : .off
        Severity: Minor
        Found in Resources/MainUI/Settings panels/CacheViewController.swift - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status