Sign upLogin

JohnCoates/Aerial

View on GitHub
Star

Showing 1,136 of 1,136 total issues

Function fetchOnlineManifest has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    static func fetchOnlineManifest(url: URL) {
        if let source = loadManifest(url: url) {
            debugLog("Source loaded")
            // Then save !
            let downloadManager = DownloadManager()
Severity: Minor
Found in Aerial/Source/Models/Sources/SourceList.swift - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function drawInfoPanel has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    func drawInfoPanel(forType: InfoType) {
        resetInfoPanel()

        // Add the common block of features (enabled, font, position, screen)
        infoScrollableView.addSubview(infoCommonView)
Severity: Minor
Found in Resources/MainUI/Settings panels/OverlaysViewController.swift - About 1 hr to fix

    Function processPathForVideos has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        func processPathForVideos(url: URL) {
        debugLog("processing url for videos : \(url) ")
        let folderName = url.lastPathComponent
        // let manifestInstance = ManifestLoader.instance
    Severity: Minor
    Found in Aerial/Source/Controllers/CustomVideoController.swift - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          struct Countdown: CommonInfo, Codable {
        var isEnabled: Bool
        var fontName: String
        var fontSize: Double
        var corner: InfoCorner
      Severity: Major
      Found in Aerial/Source/Models/Prefs/PrefsInfo.swift and 2 other locations - About 1 hr to fix
      Aerial/Source/Models/Prefs/PrefsInfo.swift on lines 93..104
      Aerial/Source/Models/Prefs/PrefsInfo.swift on lines 175..186

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          struct Timer: CommonInfo, Codable {
        var isEnabled: Bool
        var fontName: String
        var fontSize: Double
        var corner: InfoCorner
      Severity: Major
      Found in Aerial/Source/Models/Prefs/PrefsInfo.swift and 2 other locations - About 1 hr to fix
      Aerial/Source/Models/Prefs/PrefsInfo.swift on lines 93..104
      Aerial/Source/Models/Prefs/PrefsInfo.swift on lines 162..173

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          static func exclude() {
        let process: Process = Process()

        debugLog("Trying to exclude our path \(Cache.path) in Time Machine")
      Severity: Major
      Found in Aerial/Source/Models/Cache/TimeMachine.swift and 1 other location - About 1 hr to fix
      Aerial/Source/Models/Cache/TimeMachine.swift on lines 60..78

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          struct Message: CommonInfo, Codable {
        var isEnabled: Bool
        var fontName: String
        var fontSize: Double
        var corner: InfoCorner
      Severity: Major
      Found in Aerial/Source/Models/Prefs/PrefsInfo.swift and 2 other locations - About 1 hr to fix
      Aerial/Source/Models/Prefs/PrefsInfo.swift on lines 162..173
      Aerial/Source/Models/Prefs/PrefsInfo.swift on lines 175..186

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          static func reinclude() {
        let process: Process = Process()

        debugLog("Trying to reinclude our path \(Cache.path) in Time Machine")
      Severity: Major
      Found in Aerial/Source/Models/Cache/TimeMachine.swift and 1 other location - About 1 hr to fix
      Aerial/Source/Models/Cache/TimeMachine.swift on lines 40..58

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function setupForVideo has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          override func setupForVideo(video: AerialVideo, player: AVPlayer) {
        let poiStringProvider = PoiStringProvider.sharedInstance
        // We need to make sure we actually have descriptions to show.
        // Custom videos, and earlier tvOS videos may not
        if poiStringProvider.hasPoiKeys(video: video) {
      Severity: Minor
      Found in Aerial/Source/Views/Layers/LocationLayer.swift - About 1 hr to fix

        Function windowDidLoad has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            override func windowDidLoad() {
        // debugLog("PWC2 wdl: Aerial version \(Aerial.version)")
        super.windowDidLoad()
        currentPath = "location:all"
        Severity: Minor
        Found in Resources/MainUI/PanelWindowController.swift - About 1 hr to fix

          Function processPathForVideos has 46 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              static func processPathForVideos(url: URL) {
        debugLog("processing url for videos : \(url) ")
        let folderName = url.lastPathComponent

        do {
          Severity: Minor
          Found in Aerial/Source/Models/Sources/SourceList.swift - About 1 hr to fix

            Function getInformation has 46 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                static func getInformation() -> (Bool, sunrise: Date?, sunset: Date?, error: String?) {
        // Sonoma workaround
        if !Aerial.helper.underCompanion {
            if #available(macOS 14.0, *) {
                if CompanionBridge.nightShiftSunrise != nil {
            Severity: Minor
            Found in Aerial/Source/Models/Hardware/NightShift.swift - About 1 hr to fix

              Function outlineView has 46 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  func outlineView(_ outlineView: NSOutlineView, shouldSelectItem item: Any) -> Bool {
        debugLog("selected \(item)")

        if let source = item as? Source {
            topPathControl.isHidden = false
              Severity: Minor
              Found in Aerial/Source/Controllers/CustomVideoController.swift - About 1 hr to fix

                Function viewDidLoad has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    override func viewDidLoad() {
        super.viewDidLoad()

        setupDarkMode()
        DispatchQueue.main.async {
                Severity: Minor
                Found in Resources/MainUI/Settings panels/TimeViewController.swift - About 1 hr to fix

                  Function updateCacheBox has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      func updateCacheBox() {
        let usedCache = Cache.size()
        let packsSize = Cache.packsSize()

        //print("pack size : \(packsSize)")
                  Severity: Minor
                  Found in Resources/MainUI/Settings panels/CacheViewController.swift - About 1 hr to fix

                    Function getCommunityPathForLocale has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        private func getCommunityPathForLocale() -> String {
        let locale: NSLocale = NSLocale(localeIdentifier: Locale.preferredLanguages[0])

        // Do we have a language override ?
        if PrefsAdvanced.ciOverrideLanguage != "" {
                    Severity: Minor
                    Found in Aerial/Source/Models/Cache/PoiStringProvider.swift - About 1 hr to fix

                      Function updateLocalSource has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          static func updateLocalSource(source: Source, reload: Bool) {
        // We need the raw manifest to find the path inside
        let videos = source.getUnprocessedVideos()
        let originalAssets = source.getUnprocessedAssets()
                      Severity: Minor
                      Found in Aerial/Source/Models/Sources/SourceList.swift - About 1 hr to fix

                        Function getTrimmedRect has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            private func getTrimmedRect() -> CGRect {
        let bmp = self.representations[0] as! NSBitmapImageRep
        let data: UnsafeMutablePointer<UInt8> = bmp.bitmapData!
        var alpha: UInt8
                        Severity: Minor
                        Found in Aerial/Source/Models/Extensions/NSImage+trim.swift - About 1 hr to fix

                          Function findDuplicate has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                          Open

                              func findDuplicate(id: String, url1080pH264: String) -> (Bool, AerialVideo?) {
        // We blacklist some duplicates
        if url1080pH264 != "" {
            if blacklist.contains((URL(string: url1080pH264)?.lastPathComponent)!) {
                return (true, nil)
                          Severity: Minor
                          Found in Aerial/Source/Models/ManifestLoader.swift - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function categorizedSourceList has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                          Open

                              static func categorizedSourceList() -> [SourceHeader] {
        var communities: [Source] = []
        var online: [Source] = []
        var local: [Source] = []
        var apple: [Source] = []
                          Severity: Minor
                          Found in Aerial/Source/Models/Sources/SourceList.swift - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language