Sign upLogin

JonMidhir/ruby-time_range

View on GitHub
Star
lib/time_range.rb

Summary

Maintainability
A
25 mins
Test Coverage

Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def initialize(b, e, exclude_end = false)
    raise TypeError unless [b, e].all? { |arg| arg.is_a?(Time) }

    valid_time = if exclude_end
                   (e - 1) >= b
Severity: Minor
Found in lib/time_range.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

%w-literals should be delimited by [ and ].
Open

    %w(begins_within? ends_within? encapsulates?).any? do |condition|
Severity: Minor
Found in lib/time_range.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Favor a normal if-statement over a modifier clause in a multiline statement.
Open

    self.class.new(
      [self.begin, time_range.begin].max,
      [max, time_range.max].min
    ) if overlaps?(time_range)
Severity: Minor
Found in lib/time_range.rb by rubocop

Checks for uses of if/unless modifiers with multiple-lines bodies.

Example:

# bad
{
  result: 'this should not happen'
} unless cond

# good
{ result: 'ok' } if cond

There are no issues that match your filters.

Category
Status