Sign upLogin

JordanHatch/maslow-redux

View on GitHub
Star

Showing 7 of 8 total issues

Function edit has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

MASLOW.need_criteria.edit = function () {
  var form = document.querySelector('form.need_criteria')
  var list = form.querySelector('ul')

  var baseTemplate = list.querySelector('li:first-child').cloneNode(true)
Severity: Major
Found in app/assets/javascripts/controllers/need_criteria.js - About 2 hrs to fix

    Class Need has 21 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class Need < ActiveRecord::Base
  include ActiveModel::AttributeMethods
  include Concerns::Followable

  has_many :taggings, dependent: :destroy
    Severity: Minor
    Found in app/models/need.rb - About 2 hrs to fix

      Function buildCriteria has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        var buildCriteria = function () {
    var item = baseTemplate.cloneNode(true)
    var index = getIndex()

    item.setAttribute('data-index', index)
      Severity: Minor
      Found in app/assets/javascripts/controllers/need_criteria.js - About 1 hr to fix

        Method format_field_value has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def format_field_value(value)
    if value.is_a?(Array)
      if value.empty? || value.reject(&:blank?).empty?
        "<ul><li><em>blank</em></li></ul>".html_safe
      else
        Severity: Minor
        Found in app/helpers/activity_items_helper.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method nav_link_to has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def nav_link_to(label, url, icon: nil, match_prefix: false)

    if content_for?(:selected_navigation_url)
      selected = (url == content_for(:selected_navigation_url))
    elsif match_prefix
        Severity: Minor
        Found in app/helpers/layout_helper.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def update
    authorize! :update, Need

    need.assign_attributes(need_params)
        Severity: Minor
        Found in app/controllers/needs_controller.rb and 1 other location - About 25 mins to fix
        app/controllers/needs_controller.rb on lines 54..64

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 30.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def create
    authorize! :create, Need

    need.assign_attributes(need_params)
        Severity: Minor
        Found in app/controllers/needs_controller.rb and 1 other location - About 25 mins to fix
        app/controllers/needs_controller.rb on lines 67..77

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 30.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language