Showing 5 of 8 total issues
Function edit
has 66 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
MASLOW.need_criteria.edit = function () {
var form = document.querySelector('form.need_criteria')
var list = form.querySelector('ul')
var baseTemplate = list.querySelector('li:first-child').cloneNode(true)
Class Need
has 21 methods (exceeds 20 allowed). Consider refactoring. Open
Open
class Need < ActiveRecord::Base
include ActiveModel::AttributeMethods
include Concerns::Followable
has_many :taggings, dependent: :destroy
Function buildCriteria
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
var buildCriteria = function () {
var item = baseTemplate.cloneNode(true)
var index = getIndex()
item.setAttribute('data-index', index)
Method format_field_value
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
def format_field_value(value)
if value.is_a?(Array)
if value.empty? || value.reject(&:blank?).empty?
"<ul><li><em>blank</em></li></ul>".html_safe
else
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method nav_link_to
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def nav_link_to(label, url, icon: nil, match_prefix: false)
if content_for?(:selected_navigation_url)
selected = (url == content_for(:selected_navigation_url))
elsif match_prefix
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"