Sign upLogin

JoseCage/kallun-api

View on GitHub
Star
routes/api.php

Summary

Maintainability
A
0 mins
Test Coverage

Define a constant instead of duplicating this literal "prefix" 3 times.
Open

Route::group(['prefix' => 'v1', 'namespace' => 'API'], function() {
Severity: Critical
Found in routes/api.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Expected 1 space after FUNCTION keyword; 0 found
Open

Route::group(['prefix' => 'v1', 'namespace' => 'API'], function() {
Severity: Minor
Found in routes/api.php by phpcodesniffer

Expected 1 space after FUNCTION keyword; 0 found
Open

    Route::group(['prefix' => 'slangs'], function($slang) {
Severity: Minor
Found in routes/api.php by phpcodesniffer

Expected 1 space after FUNCTION keyword; 0 found
Open

    Route::group(['prefix' => 'auth', 'namespace' => 'Auth'], function($auth) {
Severity: Minor
Found in routes/api.php by phpcodesniffer

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

});
Severity: Minor
Found in routes/api.php by phpcodesniffer

There are no issues that match your filters.

Category
Status