Sign upLogin

JumpstartLab/tracks

View on GitHub
Star
app/controllers/users_controller.rb

Summary

Maintainability
D
1 day
Test Coverage

Method create has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
Open

  def create
    if params['exception']
      render_failure "Expected post format is valid xml like so: <user><login>username</login><password>abc123</password></user>."
      return
    end
Severity: Minor
Found in app/controllers/users_controller.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create
    if params['exception']
      render_failure "Expected post format is valid xml like so: <user><login>username</login><password>abc123</password></user>."
      return
    end
Severity: Major
Found in app/controllers/users_controller.rb - About 2 hrs to fix

    Method check_create_user_params has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def check_create_user_params
    return false unless params.has_key?(:user)
    return false unless params[:user].has_key?(:login)
    return false if params[:user][:login].empty?
    return false unless params[:user].has_key?(:password)
    Severity: Minor
    Found in app/controllers/users_controller.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method new has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def new
    @auth_types = []
    unless session[:cas_user]
      Tracks::Config.auth_schemes.each {|auth| @auth_types << [auth,auth]}
    else
    Severity: Minor
    Found in app/controllers/users_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

        return true
    Severity: Major
    Found in app/controllers/users_controller.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                return
      Severity: Major
      Found in app/controllers/users_controller.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return
        Severity: Major
        Found in app/controllers/users_controller.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return false if params[:user][:password].empty?
          Severity: Major
          Found in app/controllers/users_controller.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                      return
            Severity: Major
            Found in app/controllers/users_controller.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return
              Severity: Major
              Found in app/controllers/users_controller.rb - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status