Sign upLogin

JumpstartLab/tracks

View on GitHub
Star
app/models/recurring_todo.rb

Summary

Maintainability
F
4 days
Test Coverage

Class RecurringTodo has 80 methods (exceeds 20 allowed). Consider refactoring.
Open

class RecurringTodo < ActiveRecord::Base
  attr_protected :user

  belongs_to :context
  belongs_to :project
Severity: Major
Found in app/models/recurring_todo.rb - About 1 day to fix

    File recurring_todo.rb has 516 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class RecurringTodo < ActiveRecord::Base
  attr_protected :user

  belongs_to :context
  belongs_to :project
    Severity: Major
    Found in app/models/recurring_todo.rb - About 1 day to fix

      Method get_weekly_date has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

        def get_weekly_date(previous)
    # determine start
    if previous == nil
      start = self.start_from.nil? ? Time.zone.now : self.start_from
    else
      Severity: Minor
      Found in app/models/recurring_todo.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_xth_day_of_month has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

        def get_xth_day_of_month(x, weekday, month, year)
    if x == 5
      # last -> count backwards. use UTC to avoid strange timezone oddities
      # where last_day -= 1.day seems to shift tz+0100 to tz+0000
      last_day = Time.utc(year, month, Time.days_in_month(month))
      Severity: Minor
      Found in app/models/recurring_todo.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method validate_monthly has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def validate_monthly
    case recurrence_selector
    when 0 # 'monthly_every_x_day'
      errors[:base] << "The day of the month may not be empty for recurrence setting" if monthly_every_x_day.blank?
      errors[:base] << "Every other nth month may not be empty for recurrence setting" if monthly_every_x_month.blank?
      Severity: Minor
      Found in app/models/recurring_todo.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_yearly_date has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def get_yearly_date(previous)
    start = determine_start(previous)
    day = self.every_other1
    month = self.every_other2
      Severity: Minor
      Found in app/models/recurring_todo.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method validate_yearly has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def validate_yearly
    case recurrence_selector
    when 0 # 'yearly_every_x_day'
      errors[:base] << "The month of the year may not be empty for recurrence setting" if yearly_month_of_year.blank?
      errors[:base] << "The day of the month may not be empty for recurrence setting" if yearly_every_x_day.blank?
      Severity: Minor
      Found in app/models/recurring_todo.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method determine_start has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def determine_start(previous, offset=0.day)

    if previous.nil?
      start = self.start_from.nil? ? Time.zone.now : self.start_from
      # skip to present
      Severity: Minor
      Found in app/models/recurring_todo.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_daily_date has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def get_daily_date(previous)
    # previous is the due date of the previous todo or it is the completed_at
    # date when the completed_at date is after due_date (i.e. you did not make
    # the due date in time)
    #
      Severity: Minor
      Found in app/models/recurring_todo.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method starts_and_ends_on_validations has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def starts_and_ends_on_validations
    errors[:base] << "The start date needs to be filled in" if start_from.blank?
    case self.ends_on
    when 'ends_on_number_of_times'
      errors[:base] << "The number of recurrences needs to be filled in for 'Ends on'" if number_of_occurences.blank?
      Severity: Minor
      Found in app/models/recurring_todo.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method monthly_recurrence_pattern has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def monthly_recurrence_pattern
    return "invalid repeat pattern" if every_other2.nil?
    if self.recurrence_selector == 0
      on_day = " #{I18n.t('todos.recurrence.pattern.on_day_n', :n => self.every_other1)}"
      if self.every_other2>1
      Severity: Minor
      Found in app/models/recurring_todo.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method set_recurrence_on_validations has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def set_recurrence_on_validations
    # show always or x days before due date. x not null
    case self.target
    when 'show_from_date'
      # no validations
      Severity: Minor
      Found in app/models/recurring_todo.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_monthly_date has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def get_monthly_date(previous)

    start = determine_start(previous)
    day = self.every_other1
    n = self.every_other2
      Severity: Minor
      Found in app/models/recurring_todo.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def validate_yearly
    case recurrence_selector
    when 0 # 'yearly_every_x_day'
      errors[:base] << "The month of the year may not be empty for recurrence setting" if yearly_month_of_year.blank?
      errors[:base] << "The day of the month may not be empty for recurrence setting" if yearly_every_x_day.blank?
      Severity: Major
      Found in app/models/recurring_todo.rb and 1 other location - About 1 hr to fix
      app/models/recurring_todo.rb on lines 66..76

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def validate_monthly
    case recurrence_selector
    when 0 # 'monthly_every_x_day'
      errors[:base] << "The day of the month may not be empty for recurrence setting" if monthly_every_x_day.blank?
      errors[:base] << "Every other nth month may not be empty for recurrence setting" if monthly_every_x_month.blank?
      Severity: Major
      Found in app/models/recurring_todo.rb and 1 other location - About 1 hr to fix
      app/models/recurring_todo.rb on lines 80..90

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status