Sign upLogin

Justinzh1/Emunah

View on GitHub
Star

Showing 36 of 36 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    <div className="input-group">
        <input 
          type="text" 
          className="form-control" 
          aria-describedby="basic-addon1"
Severity: Major
Found in app/assets/javascripts/components/submittal_list.es6.jsx and 2 other locations - About 1 hr to fix
app/assets/javascripts/components/family_list.es6.jsx on lines 135..143
app/assets/javascripts/components/user_list.es6.jsx on lines 66..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function render has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render () {
      users = []
      for (var i=0; i < this.state.users.length; i++) {
          var user = this.state.users[i]
          users.push(
Severity: Minor
Found in app/assets/javascripts/components/user_list.es6.jsx - About 1 hr to fix

    Method create has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def create
        @family = Family.find(params[:family_id])
        title, notes = submittal_params[:title], submittal_params[:notes]
        if !title.nil? and !notes.nil? and !title.empty? and !notes.empty?
            @family.submittals.build(submittal_params.merge(:family_name => @family.family_name)).save!
    Severity: Minor
    Found in app/controllers/submittals_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function render has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        render () {
    var name = (<a href={this.state.show}> {this.props.submittal.title}  </a>);
    var recent = 
      (<td className="blue-highlight">
        {this.printDate(Date(this.state.entry))}
    Severity: Minor
    Found in app/assets/javascripts/components/submittal_list.es6.jsx - About 1 hr to fix

      Function handleKeyPress has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        handleKeyPress(event) {
    str = String(event.target.value);
    if (str == '') {
      this.setState({
        families: this.state.total
      Severity: Minor
      Found in app/assets/javascripts/components/family_list.es6.jsx - About 1 hr to fix

        Function handleKeyPress has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          handleKeyPress(event) {
    str = String(event.target.value);
    if (str == '') {
      this.setState({
        submittals: this.state.total
        Severity: Minor
        Found in app/assets/javascripts/components/submittal_list.es6.jsx - About 1 hr to fix

          Function render has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            render () {
    var info = []
    for (var i=0; i<KEYS.length; i++) {
      var key = KEYS[i];
      var fam = String(this.props.family[key]).split(', ')
          Severity: Minor
          Found in app/assets/javascripts/components/family_list.es6.jsx - About 1 hr to fix

            Function render has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                render () {
    var edit = "/families/" + this.props.family.id + "/families";
    var del = "/families/" + this.props.family.id;
    var show = "/families/" + this.props.family.id;
            Severity: Minor
            Found in app/assets/javascripts/components/family_list.es6.jsx - About 1 hr to fix

              Function render has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                render () {
      people = []
      for (var i=0; i < this.state.people.length; i++) {
          var person = this.state.people[i]
          people.push(
              Severity: Minor
              Found in app/assets/javascripts/components/person_list.es6.jsx - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    def revoke
        @user ||= User.find(session[:user_id]) if session[:user_id]
        if @user.can_revoke?
            submittal = Submittal.find(params[:submittal_id])
            submittal.revoke
                Severity: Major
                Found in app/controllers/submittals_controller.rb and 1 other location - About 1 hr to fix
                app/controllers/submittals_controller.rb on lines 90..99

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    def approve
        @user ||= User.find(session[:user_id]) if session[:user_id]
        if @user.can_revoke?
            submittal = Submittal.find(params[:submittal_id])
            submittal.approve
                Severity: Major
                Found in app/controllers/submittals_controller.rb and 1 other location - About 1 hr to fix
                app/controllers/submittals_controller.rb on lines 102..111

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function render has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                  render () {
      families = []
      for (var i=0; i < this.state.families.length; i++) {
          var family = this.state.families[i]
                Severity: Minor
                Found in app/assets/javascripts/components/family_list.es6.jsx - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method update has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    def update 
        @submittal = Submittal.find(params[:id])
        @submittal.update_attributes!(submittal_params)
        @family = Family.find_by(params[:family_id])
        user = User.find(params[:user][:id])
                Severity: Minor
                Found in app/controllers/submittals_controller.rb - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method dash has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                  def dash
    @user ||= User.find(session[:user_id]) if session[:user_id]
    if @user == nil
      redirect_to home_path
    else
                Severity: Minor
                Found in app/controllers/home_controller.rb - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function render has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    render () {
    var name = (<a href={this.state.show}> {this.props.submittal.title}  </a>);
    var recent = 
      (<td className="blue-highlight">
        {this.printDate(Date(this.state.entry))}
                Severity: Minor
                Found in app/assets/javascripts/components/submittal_list.es6.jsx - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  def create
    # Modify change to family_name
    last_name = params[:person][:last_name]
    family = Family.find_by(family_name: last_name)
    if family != nil
                Severity: Minor
                Found in app/controllers/families_controller.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language