Sign upLogin

KDEJewellers/aptly-api

View on GitHub
Star

Showing 3 of 3 total issues

Method publish has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def publish(sources, prefix = '', source_kind = 'local',
                connection = Connection.new, **kwords)
Severity: Minor
Found in lib/aptly.rb - About 35 mins to fix

    Method mangle_post has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def mangle_post(body, headers, kwords)
      if body
        headers ||= {}
        headers['Content-Type'] = 'application/json'
      else
    Severity: Minor
    Found in lib/aptly/connection.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method published_in has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def published_in
      Aptly::PublishedRepository.list(connection).select do |pub|
        next false unless pub.Sources.any? do |src|
          src.Name == self.Name
        end
    Severity: Minor
    Found in lib/aptly/publishable.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language