Sign upLogin

KarrLab/wc_utils

View on GitHub
Star
wc_utils/util/units.py

Summary

Maintainability
B
5 hrs
Test Coverage
C
71%

Function are_units_equivalent has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

def are_units_equivalent(units1, units2, check_same_magnitude=True):
    """ Determine if two units are equivalent

    Args:
        units1 (:obj:`pint.unit._Unit`): units
Severity: Minor
Found in wc_utils/util/units.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

                    return units1_expr.compare(units2_expr, operator.eq) or \
Severity: Major
Found in wc_utils/util/units.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                    return True
    Severity: Major
    Found in wc_utils/util/units.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                          return False
      Severity: Major
      Found in wc_utils/util/units.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return False
        Severity: Major
        Found in wc_utils/util/units.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return units1_expr.check(units2_expr)
          Severity: Major
          Found in wc_utils/util/units.py - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status