Sign upLogin

Katello/katello

View on GitHub
Star
app/controllers/katello/api/v2/api_controller.rb

Summary

Maintainability
C
1 day
Test Coverage

Method scoped_search has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

    def scoped_search(query, default_sort_by, default_sort_order, options = {})
      params[:sort_by] ||= default_sort_by
      params[:sort_order] ||= default_sort_order

      resource = options[:resource_class] || resource_class
Severity: Minor
Found in app/controllers/katello/api/v2/api_controller.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class ApiController has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Api::V2::ApiController < ::Api::V2::BaseController
    include Concerns::Api::ApiController
    include Api::Version2
    include Api::V2::Rendering
    include Api::V2::ErrorHandling
Severity: Minor
Found in app/controllers/katello/api/v2/api_controller.rb - About 2 hrs to fix

    Method scoped_search has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def scoped_search(query, default_sort_by, default_sort_order, options = {})
      params[:sort_by] ||= default_sort_by
      params[:sort_order] ||= default_sort_order

      resource = options[:resource_class] || resource_class
    Severity: Major
    Found in app/controllers/katello/api/v2/api_controller.rb - About 2 hrs to fix

      There are no issues that match your filters.

      Category
      Status