Sign upLogin

Katello/katello

View on GitHub
Star
app/lib/actions/middleware/backend_services_check.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method plan has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def plan(*args)
        if Setting[:check_services_before_actions]
          #To prevent the ping from happening multiple times, keep track on the initial entry action
          #If capsule_id is passed as in args from an action, Katello::Ping checks the pulp server on the capsule
          parent = source_action
Severity: Minor
Found in app/lib/actions/middleware/backend_services_check.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method capsule_id has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def capsule_id(args)
        capsule_id = nil
        args.each do |arg|
          case arg
          when SmartProxy
Severity: Minor
Found in app/lib/actions/middleware/backend_services_check.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status