Sign upLogin

Katello/katello

View on GitHub
Star
app/models/katello/content_view.rb

Summary

Maintainability
F
4 days
Test Coverage

Class ContentView has 95 methods (exceeds 20 allowed). Consider refactoring.
Open

  class ContentView < Katello::Model
    audited :associations => [:repositories, :environments, :filters]
    has_associated_audits
    include Ext::LabelFromName
    include Katello::Authorization::ContentView
Severity: Major
Found in app/models/katello/content_view.rb - About 1 day to fix

    File content_view.rb has 725 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module Katello
  # rubocop:disable Metrics/ClassLength
  class ContentView < Katello::Model
    audited :associations => [:repositories, :environments, :filters]
    has_associated_audits
    Severity: Major
    Found in app/models/katello/content_view.rb - About 1 day to fix

      Method needs_publish? has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          def needs_publish?
      #Returns
      # True:
      #     a) When content/repo/filter change audit records exist
      #     b) CV hasn't ever been published
      Severity: Minor
      Found in app/models/katello/content_view.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check_composite_action_allowed! has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          def check_composite_action_allowed!(env)
      if composite? && Setting['restrict_composite_view']
        if components.size != content_view_components.size
          fail _("Make sure all the component content views are published before publishing/promoting the composite content view. "\
               "This restriction is optional and can be modified in the Administrator -> Settings -> Content "\
      Severity: Minor
      Found in app/models/katello/content_view.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check_ready_to_publish! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def check_ready_to_publish!(importing: false, syncable: false)
      fail _("User must be logged in.") if ::User.current.nil?
      fail _("Cannot publish default content view") if default?

      if importing
      Severity: Minor
      Found in app/models/katello/content_view.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

            return true if cv_repo_indexed_after_last_published?
      Severity: Major
      Found in app/models/katello/content_view.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return nil unless latest_version_object&.audits&.where(action: "create")&.exists?
        Severity: Major
        Found in app/models/katello/content_view.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return true if dependency_solving_changed?
          Severity: Major
          Found in app/models/katello/content_view.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return true if audited_changes_present?
            Severity: Major
            Found in app/models/katello/content_view.rb - About 30 mins to fix

              Method repositories_to_publish has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def repositories_to_publish(override_components = nil)
      if composite?
        components_to_publish = []
        components.each do |component|
          override_component = override_components&.detect do |override_cvv|
              Severity: Minor
              Found in app/models/katello/content_view.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method check_docker_repository_names! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def check_docker_repository_names!(environments)
      environments.each do |environment|
        repositories = []
        publish_repositories do |all_repositories|
          repositories += all_repositories.keep_if { |repository| repository.content_type == Katello::Repository::DOCKER_TYPE }
              Severity: Minor
              Found in app/models/katello/content_view.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  def check_repositories_blocking_publish!
      blocking_tasks = repositories&.map { |repo| repo.blocking_task }&.compact

      if blocking_tasks&.any?
        errored_tasks = blocking_tasks.uniq.map { |task| "- #{Setting['foreman_url']}/foreman_tasks/tasks/#{task&.id}" }.join("\n")
              Severity: Minor
              Found in app/models/katello/content_view.rb and 1 other location - About 40 mins to fix
              app/models/katello/repository.rb on lines 668..677

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 38.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status