Sign upLogin

KazW/RintCore

View on GitHub
Star

Showing 33 of 33 total issues

Method analyze has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def analyze(file)
      unless RintCore::GCode::Object.is_file?(file)
        puts "Non-exsitant file: #{file}"
        exit
      end
Severity: Minor
Found in lib/rint_core/cli.rb - About 1 hr to fix

    Method listen has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def listen
        clear_to_send!
        listen_until_online
        while listen_can_continue? do
          line = readline!
    Severity: Minor
    Found in lib/rint_core/driver/operations.rb - About 1 hr to fix

      Method run_main_queue has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

            def run_main_queue
        p "Run main ququeueueu 111"
        return nil if paused?
        p "Run main ququeueueu 22"
        if @queue_index < @queue_length
      Severity: Minor
      Found in lib/rint_core/driver/queueing.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method set_line_properties has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

            def set_line_properties(line)
        return false unless line
        return line if line.command.nil?
        @tool_number = line.tool_number unless line.tool_number.nil?
        line.tool_number = @tool_number if line.tool_number.nil?
      Severity: Minor
      Found in lib/rint_core/g_code/object.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method print_file! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def print_file!(file)
        p "Print file!"
        return false unless can_print?
        p "Print file! 1"
        return false unless File.exist?(file) && File.file?(file)
      Severity: Minor
      Found in lib/rint_core/driver/operations.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method print has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def print
        p "privatge print"
        @machine_history = []
        config.callbacks[:start].call unless config.callbacks[:start].nil?
        p "enter ing loop"
      Severity: Minor
      Found in lib/rint_core/driver/operations.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method hypot3d has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def hypot3d(x1, y1, z1, x2 = 0.0, y2 = 0.0, z2 = 0.0)
      Severity: Minor
      Found in lib/rint_core/g_code/object.rb - About 45 mins to fix

        Method initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def initialize(line)
        (line.nil? || line.empty?) ? @raw = '' : @raw = line
        @matches = @raw.match(GCODE_PATTERN)
        @f = @matches[:f_data].to_f unless @matches[:f_data].nil?
        @tool_number = command_number if !command_letter.nil? && command_letter == 'T'
        Severity: Minor
        Found in lib/rint_core/g_code/line.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method connect! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def connect!
        return false if connected?
        unless config.port.nil? && config.baud.nil?
          disable_hup(config.port)
          @connection = SerialPort.new(config.port, config.baud)
        Severity: Minor
        Found in lib/rint_core/driver/operations.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                  return true
        Severity: Major
        Found in lib/rint_core/driver/queueing.rb - About 30 mins to fix

          Method apply_multipliers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                def apply_multipliers
        @gcode_object.lines[@queue_index].speed_multiplier = config.speed_multiplier unless config.speed_multiplier.nil?
        @gcode_object.lines[@queue_index].extrusion_multiplier = config.extrusion_multiplier unless config.extrusion_multiplier.nil?
        @gcode_object.lines[@queue_index].travel_multiplier = config.travel_multiplier unless config.travel_multiplier.nil?
      end
          Severity: Minor
          Found in lib/rint_core/driver/queueing.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method print! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                def print!(gcode, start_index = 0)
        p "Starting print!"
        return false unless gcode.is_a?(RintCore::GCode::Object)
        prep_to_print(start_index)
        return false unless gcode.present?
          Severity: Minor
          Found in lib/rint_core/driver/operations.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method process has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                def process
        set_processing_variables

        @lines.each do |line|
          case line.command
          Severity: Minor
          Found in lib/rint_core/g_code/object.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language