Sign upLogin

Kerrigan29a/recipe

View on GitHub
Star
task.go

Summary

Maintainability
A
2 hrs
Test Coverage

Method Task.Execute has 6 return statements (exceeds 4 allowed).
Open

func (t *Task) Execute(r *Recipe) error {
    t.mu.RLock()
    defer t.mu.RUnlock()

    if t.Cmd == "" {
Severity: Major
Found in task.go - About 40 mins to fix

    Method Task.composeInterpreterCmd has 5 return statements (exceeds 4 allowed).
    Open

    func (t *Task) composeInterpreterCmd(spell string, r *Recipe) []string {
    // Check task config
    if parts := t.Interpreter(); parts != nil {
        if len(parts) == 0 {
            return t.composeDefaultInterpreterCmd(spell)
    Severity: Major
    Found in task.go - About 35 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      func (t *Task) serialize(indent bool) *bytes.Buffer {
    t.mu.RLock()
    defer t.mu.RUnlock()
    b := bytes.Buffer{}
    e := json.NewEncoder(&b)
      Severity: Major
      Found in task.go and 2 other locations - About 1 hr to fix
      recipe.go on lines 295..308
      state.go on lines 90..103

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 143.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      exported method Task.PrettyString should have comment or be unexported
      Open

      func (t *Task) PrettyString() string {
      Severity: Minor
      Found in task.go by golint

      exported method Task.Environ should have comment or be unexported
      Open

      func (t *Task) Environ() map[string]string {
      Severity: Minor
      Found in task.go by golint

      exported method Task.Execute should have comment or be unexported
      Open

      func (t *Task) Execute(r *Recipe) error {
      Severity: Minor
      Found in task.go by golint

      exported type Task should have comment or be unexported
      Open

      type Task struct {
      Severity: Minor
      Found in task.go by golint

      exported method Task.Interpreter should have comment or be unexported
      Open

      func (t *Task) Interpreter() []string {
      Severity: Minor
      Found in task.go by golint

      There are no issues that match your filters.

      Category
      Status